https://github.com/Kitware/CMake
Revision 3f976bf201983b399dacbcde51ef10b0a6de9b06 authored by Brad King on 30 March 2020, 15:08:10 UTC, committed by Brad King on 30 March 2020, 15:33:55 UTC
Since commit b8626261e9 (Precompile headers: Add methods to generate PCH sources, 2019-07-13, v3.16.0-rc1~182^2~4) we look up source files for a target using an upper-case configuration even though an original-case name is sufficient. Since commit 36ded610af (PCH: Generate sources during Compute step, 2019-10-05, v3.16.0-rc1~2^2) the source file lookup is the first time we compute many on-demand structures that depend on the configuration name. This caused the `$<CONFIG>` generator expression to evaluate to the upper-case configuration name in some cases where we used original-case before. Fix this by switching the source file lookup to the original-case config name. Add a test covering the symptom that led to the discovery of this problem. Fixes: #20517
1 parent e3185e3
Tip revision: 3f976bf201983b399dacbcde51ef10b0a6de9b06 authored by Brad King on 30 March 2020, 15:08:10 UTC
target_link_libraries: Fix regression in case of $<CONFIG> genex
target_link_libraries: Fix regression in case of $<CONFIG> genex
Tip revision: 3f976bf
| File | Mode | Size |
|---|---|---|
| .github | ||
| Auxiliary | ||
| Help | ||
| Licenses | ||
| Modules | ||
| Packaging | ||
| Source | ||
| Templates | ||
| Tests | ||
| Utilities | ||
| .clang-format | -rw-r--r-- | 1.3 KB |
| .clang-tidy | -rw-r--r-- | 1010 bytes |
| .gitattributes | -rw-r--r-- | 1.1 KB |
| .gitignore | -rw-r--r-- | 132 bytes |
| .hooks-config | -rw-r--r-- | 418 bytes |
| CMakeCPack.cmake | -rw-r--r-- | 9.7 KB |
| CMakeCPackOptions.cmake.in | -rw-r--r-- | 11.9 KB |
| CMakeGraphVizOptions.cmake | -rw-r--r-- | 153 bytes |
| CMakeLists.txt | -rw-r--r-- | 30.8 KB |
| CMakeLogo.gif | -rw-r--r-- | 4.4 KB |
| CONTRIBUTING.rst | -rw-r--r-- | 3.1 KB |
| CTestConfig.cmake | -rw-r--r-- | 440 bytes |
| CTestCustom.cmake.in | -rw-r--r-- | 6.7 KB |
| CompileFlags.cmake | -rw-r--r-- | 4.2 KB |
| Copyright.txt | -rw-r--r-- | 5.2 KB |
| DartConfig.cmake | -rw-r--r-- | 374 bytes |
| README.rst | -rw-r--r-- | 3.9 KB |
| bootstrap | -rwxr-xr-x | 53.2 KB |
| cmake_uninstall.cmake.in | -rw-r--r-- | 789 bytes |
| configure | -rwxr-xr-x | 99 bytes |
| doxygen.config | -rw-r--r-- | 27.4 KB |
Computing file changes ...
