Skip to main content

Browse the archive

https://github.com/torvalds/linux
05 April 2024, 19:05:47 UTC
Revision 409ae5a76e0505c8ffe1424f9c00dbf2ec7b5eea authored by Matias Bjørling on 10 November 2016, 11:26:57 UTC, committed by Jens Axboe on 12 November 2016, 01:27:32 UTC 
lightnvm: invalid offset calculation for lba_shift
 
The ns->lba_shift assumes its value to be the logarithmic of the
LA size. A previous patch duplicated the lba_shift calculation into
lightnvm. It prematurely also subtracted a 512byte shift, which commonly
is applied per-command. The 512byte shift being subtracted twice led to
data loss when restoring the logical to physical mapping table from
device and when issuing I/O commands using rrpc.

Fix offset by removing the 512byte shift subtraction when calculating
lba_shift.

Fixes: b0b4e09c1ae7 "lightnvm: control life of nvm_dev in driver"
Reported-by: Javier González <javier@cnexlabs.com>
Signed-off-by: Matias Bjørling <m@bjorling.me>
Signed-off-by: Jens Axboe <axboe@fb.com>
1 parent 86e4ee7
History
Tip revision: 409ae5a76e0505c8ffe1424f9c00dbf2ec7b5eea authored by Matias Bjørling on 10 November 2016, 11:26:57 UTC
lightnvm: invalid offset calculation for lba_shift
Tip revision: 409ae5a
File Mode Size
Makefile -rw-r--r-- 377 bytes
compat.c -rw-r--r-- 19.1 KB
compat_mq.c -rw-r--r-- 3.9 KB
ipc_sysctl.c -rw-r--r-- 5.4 KB
mq_sysctl.c -rw-r--r-- 2.9 KB
mqueue.c -rw-r--r-- 35.7 KB
msg.c -rw-r--r-- 23.3 KB
msgutil.c -rw-r--r-- 3.6 KB
namespace.c -rw-r--r-- 4.5 KB
sem.c -rw-r--r-- 56.3 KB
shm.c -rw-r--r-- 33.3 KB
syscall.c -rw-r--r-- 2.3 KB
util.c -rw-r--r-- 21.1 KB
util.h -rw-r--r-- 6.4 KB
back to top