Skip to main content

Browse the archive

Revision 410fe8465f4c5a51d25d95c62a53b569d980c1cf authored by Robert Ma on 19 March 2018, 15:34:37 UTC, committed by Robert Ma on 19 March 2018, 15:34:37 UTC 
Exit check_stability with an error when no tests run
 
Similar to #10030 (which was for `wpt run`), this commit makes `wpt
check-stability` return a non-zero exit code when no tests run.

Also fix some code smells:

* `run` was redefined by `do_delayed_imports` to a different function.
  Rename the other `run` method in this module to `setup_and_run`.
* `retcode` was unnecessarily defined in the top scope. Remove it to
  avoid redefinition.
* `global logger` and the call to `get_parser` were extraneous in `run`
  (now `setup_and_run`) and hence are removed.
1 parent 9b3bb05
Raw File
insert_adjacent_html.js 
function testThrowingNoParent(element, desc) {
  test(function() {
    assert_throws("NO_MODIFICATION_ALLOWED_ERR",
      function() { element.insertAdjacentHTML("afterend", "") }
    );
    assert_throws("NO_MODIFICATION_ALLOWED_ERR",
      function() { element.insertAdjacentHTML("beforebegin", "") }
    );
    assert_throws("NO_MODIFICATION_ALLOWED_ERR",
      function() { element.insertAdjacentHTML("afterend", "foo") }
    );
    assert_throws("NO_MODIFICATION_ALLOWED_ERR",
      function() { element.insertAdjacentHTML("beforebegin", "foo") }
    );
  }, "When the parent node is " + desc + ", insertAdjacentHTML should throw for beforebegin and afterend (text)");
  test(function() {
    assert_throws("NO_MODIFICATION_ALLOWED_ERR",
      function() { element.insertAdjacentHTML("afterend", "<!-- fail -->") }
    );
    assert_throws("NO_MODIFICATION_ALLOWED_ERR",
      function() { element.insertAdjacentHTML("beforebegin", "<!-- fail -->") }
    );
  }, "When the parent node is " + desc + ", insertAdjacentHTML should throw for beforebegin and afterend (comments)");
  test(function() {
    assert_throws("NO_MODIFICATION_ALLOWED_ERR",
      function() { element.insertAdjacentHTML("afterend", "<div></div>") }
    );
    assert_throws("NO_MODIFICATION_ALLOWED_ERR",
      function() { element.insertAdjacentHTML("beforebegin", "<div></div>") }
    );
  }, "When the parent node is " + desc + ", insertAdjacentHTML should throw for beforebegin and afterend (elements)");
}
back to top