Skip to main content

Browse the archive

Revision 410fe8465f4c5a51d25d95c62a53b569d980c1cf authored by Robert Ma on 19 March 2018, 15:34:37 UTC, committed by Robert Ma on 19 March 2018, 15:34:37 UTC 
Exit check_stability with an error when no tests run
 
Similar to #10030 (which was for `wpt run`), this commit makes `wpt
check-stability` return a non-zero exit code when no tests run.

Also fix some code smells:

* `run` was redefined by `do_delayed_imports` to a different function.
  Rename the other `run` method in this module to `setup_and_run`.
* `retcode` was unnecessarily defined in the top scope. Remove it to
  avoid redefinition.
* `global logger` and the call to `get_parser` were extraneous in `run`
  (now `setup_and_run`) and hence are removed.
1 parent 9b3bb05
Raw File
share-unicode-strings-manual.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>WebShare Test: Share with non-ASCII Unicode strings</title>
    <script src="/resources/testharness.js"></script>
    <script src="/resources/testharnessreport.js"></script>
    <script src="resources/manual-helper.js"></script>
  </head>
  <body>
    <script>
        setup({explicit_timeout: true});

        // Title is a string with BMP and non-BMP characters.
        // Text contains invalid surrogates which should be converted into U+FFFD.
        // URL contains non-ASCII characters in host and path.
        const title = 'fáncy 写作 😱';
        const url = 'https://测试.example.com/📄';
        // Host is IDNA-encoded. Path is percent-encoded.
        const url_ascii = 'https://xn--0zwm56d.example.com/%F0%9F%93%84';
        setupManualShareTest({title, text: '\ufffdx', url: url_ascii});
        callWhenButtonClicked(() => navigator.share({title, text: '\ud9a3x', url}));
    </script>
  </body>
</html>
back to top