Skip to main content

Browse the archive

Revision 410fe8465f4c5a51d25d95c62a53b569d980c1cf authored by Robert Ma on 19 March 2018, 15:34:37 UTC, committed by Robert Ma on 19 March 2018, 15:34:37 UTC 
Exit check_stability with an error when no tests run
 
Similar to #10030 (which was for `wpt run`), this commit makes `wpt
check-stability` return a non-zero exit code when no tests run.

Also fix some code smells:

* `run` was redefined by `do_delayed_imports` to a different function.
  Rename the other `run` method in this module to `setup_and_run`.
* `retcode` was unnecessarily defined in the top scope. Remove it to
  avoid redefinition.
* `global logger` and the call to `get_parser` were extraneous in `run`
  (now `setup_and_run`) and hence are removed.
1 parent 9b3bb05
Raw File
overridemimetype-blob.html 
<!doctype html>
<title>XMLHttpRequest: overrideMimeType() and responseType = "blob"</title>
<meta charset="utf-8">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<div id="log"></div>
<script>
async_test(t => {
  const client = new XMLHttpRequest()
  client.onload = t.step_func_done(() => {
    assert_equals(client.getResponseHeader("Content-Type"), "")
    assert_equals(client.response.type, "text/xml")
  })
  client.open("GET", "resources/status.py")
  client.responseType = "blob"
  client.send()
}, "Use text/xml as fallback MIME type")

async_test(t => {
  const client = new XMLHttpRequest()
  client.onload = t.step_func_done(() => {
    assert_equals(client.getResponseHeader("Content-Type"), "")
    assert_equals(client.response.type, "text/xml")
  })
  client.open("GET", "resources/status.py?content=thisshouldnotmakeadifferencebutdoes")
  client.responseType = "blob"
  client.send()
}, "Use text/xml as fallback MIME type, 2")

async_test(t => {
  const client = new XMLHttpRequest()
  client.onload = t.step_func_done(() => {
    assert_equals(client.getResponseHeader("Content-Type"), "")
    assert_equals(client.response.type, "application/octet-stream")
  })
  client.open("GET", "resources/status.py")
  client.responseType = "blob"
  client.overrideMimeType("bogus")
  client.send()
}, "Bogus MIME type should end up as application/octet-stream")

async_test(t => {
  const client = new XMLHttpRequest()
  client.onload = t.step_func_done(() => {
    assert_equals(client.getResponseHeader("Content-Type"), "")
    assert_equals(client.response.type, "application/octet-stream")
  })
  client.open("GET", "resources/status.py")
  client.responseType = "blob"
  client.overrideMimeType("text/xml;charset=†")
  client.send()
}, "Bogus MIME type should end up as application/octet-stream, 2")

async_test(t => {
  const client = new XMLHttpRequest()
  client.onload = t.step_func_done(() => {
    assert_equals(client.getResponseHeader("Content-Type"), "")
    assert_equals(client.response.type, "hi/x")
  })
  client.open("GET", "resources/status.py")
  client.responseType = "blob"
  client.overrideMimeType("HI/x;test=test")
  client.send()
}, "Valid MIME types need to be normalized")
</script>
back to top