https://github.com/torvalds/linux
Revision 412d582ec1dd59aab2353f8cb7e74f2c79cd20b9 authored by Chuck Lever on 18 August 2005, 18:24:11 UTC, committed by Linus Torvalds on 18 August 2005, 19:53:56 UTC
Introduce atomic bitops to manipulate the bits in the nfs_inode structure's
"flags" field.

Using bitops means we can use a generic wait_on_bit call instead of an ad hoc
locking scheme in fs/nfs/inode.c, so we can remove the "nfs_i_wait" field from
nfs_inode at the same time.

The other new flags field will continue to use bitmask and logic AND and OR.
This permits several flags to be set at the same time efficiently.  The
following patch adds a spin lock to protect these flags, and this spin lock
will later cover other fields in the nfs_inode structure, amortizing the cost
of using this type of serialization.

Test plan:
 Millions of fsx ops on SMP clients.

Signed-off-by: Chuck Lever <cel@netapp.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent 5529680
History
Tip revision: 412d582ec1dd59aab2353f8cb7e74f2c79cd20b9 authored by Chuck Lever on 18 August 2005, 18:24:11 UTC
[PATCH] NFS: use atomic bitops to manipulate flags in nfsi->flags
Tip revision: 412d582

README

back to top