https://github.com/torvalds/linux
Revision 41c93088127df2579e8ca64010929ec9e41d5543 authored by Ying Han on 12 April 2012, 19:49:16 UTC, committed by Linus Torvalds on 12 April 2012, 20:12:12 UTC
This reverts commit c38446cc65e1f2b3eb8630c53943b94c4f65f670.

Before the commit, the code makes senses to me but not after the commit.
The "nr_reclaimed" is the number of pages reclaimed by scanning through
the memcg's lru lists.  The "nr_to_reclaim" is the target value for the
whole function.  For example, we like to early break the reclaim if
reclaimed 32 pages under direct reclaim (not DEF_PRIORITY).

After the reverted commit, the target "nr_to_reclaim" is decremented each
time by "nr_reclaimed" but we still use it to compare the "nr_reclaimed".
It just doesn't make sense to me...

Signed-off-by: Ying Han <yinghan@google.com>
Acked-by: Hugh Dickins <hughd@google.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Hillf Danton <dhillf@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 66aebce
History
Tip revision: 41c93088127df2579e8ca64010929ec9e41d5543 authored by Ying Han on 12 April 2012, 19:49:16 UTC
Revert "mm: vmscan: fix misused nr_reclaimed in shrink_mem_cgroup_zone()"
Tip revision: 41c9308
File Mode Size
partitions
Kconfig -rw-r--r-- 3.3 KB
Kconfig.iosched -rw-r--r-- 1.8 KB
Makefile -rw-r--r-- 720 bytes
blk-cgroup.c -rw-r--r-- 43.0 KB
blk-cgroup.h -rw-r--r-- 11.3 KB
blk-core.c -rw-r--r-- 76.7 KB
blk-exec.c -rw-r--r-- 3.0 KB
blk-flush.c -rw-r--r-- 13.1 KB
blk-integrity.c -rw-r--r-- 11.5 KB
blk-ioc.c -rw-r--r-- 11.6 KB
blk-iopoll.c -rw-r--r-- 5.9 KB
blk-lib.c -rw-r--r-- 3.9 KB
blk-map.c -rw-r--r-- 8.2 KB
blk-merge.c -rw-r--r-- 12.1 KB
blk-settings.c -rw-r--r-- 25.7 KB
blk-softirq.c -rw-r--r-- 4.5 KB
blk-sysfs.c -rw-r--r-- 14.8 KB
blk-tag.c -rw-r--r-- 9.8 KB
blk-throttle.c -rw-r--r-- 32.5 KB
blk-timeout.c -rw-r--r-- 5.6 KB
blk.h -rw-r--r-- 7.3 KB
bsg-lib.c -rw-r--r-- 7.6 KB
bsg.c -rw-r--r-- 23.7 KB
cfq-iosched.c -rw-r--r-- 99.4 KB
cfq.h -rw-r--r-- 3.7 KB
compat_ioctl.c -rw-r--r-- 20.8 KB
deadline-iosched.c -rw-r--r-- 11.1 KB
elevator.c -rw-r--r-- 23.5 KB
genhd.c -rw-r--r-- 43.0 KB
ioctl.c -rw-r--r-- 8.7 KB
noop-iosched.c -rw-r--r-- 2.4 KB
partition-generic.c -rw-r--r-- 13.9 KB
scsi_ioctl.c -rw-r--r-- 19.6 KB

back to top