https://github.com/torvalds/linux
Revision 41c93088127df2579e8ca64010929ec9e41d5543 authored by Ying Han on 12 April 2012, 19:49:16 UTC, committed by Linus Torvalds on 12 April 2012, 20:12:12 UTC
This reverts commit c38446cc65e1f2b3eb8630c53943b94c4f65f670. Before the commit, the code makes senses to me but not after the commit. The "nr_reclaimed" is the number of pages reclaimed by scanning through the memcg's lru lists. The "nr_to_reclaim" is the target value for the whole function. For example, we like to early break the reclaim if reclaimed 32 pages under direct reclaim (not DEF_PRIORITY). After the reverted commit, the target "nr_to_reclaim" is decremented each time by "nr_reclaimed" but we still use it to compare the "nr_reclaimed". It just doesn't make sense to me... Signed-off-by: Ying Han <yinghan@google.com> Acked-by: Hugh Dickins <hughd@google.com> Cc: Rik van Riel <riel@redhat.com> Cc: Hillf Danton <dhillf@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 66aebce
Tip revision: 41c93088127df2579e8ca64010929ec9e41d5543 authored by Ying Han on 12 April 2012, 19:49:16 UTC
Revert "mm: vmscan: fix misused nr_reclaimed in shrink_mem_cgroup_zone()"
Revert "mm: vmscan: fix misused nr_reclaimed in shrink_mem_cgroup_zone()"
Tip revision: 41c9308
File | Mode | Size |
---|---|---|
debug | ||
events | ||
gcov | ||
irq | ||
power | ||
sched | ||
time | ||
trace | ||
.gitignore | -rw-r--r-- | 63 bytes |
Kconfig.freezer | -rw-r--r-- | 52 bytes |
Kconfig.hz | -rw-r--r-- | 1.7 KB |
Kconfig.locks | -rw-r--r-- | 4.4 KB |
Kconfig.preempt | -rw-r--r-- | 2.1 KB |
Makefile | -rw-r--r-- | 4.4 KB |
acct.c | -rw-r--r-- | 16.5 KB |
async.c | -rw-r--r-- | 9.0 KB |
audit.c | -rw-r--r-- | 40.2 KB |
audit.h | -rw-r--r-- | 5.5 KB |
audit_tree.c | -rw-r--r-- | 21.7 KB |
audit_watch.c | -rw-r--r-- | 14.2 KB |
auditfilter.c | -rw-r--r-- | 33.3 KB |
auditsc.c | -rw-r--r-- | 71.3 KB |
backtracetest.c | -rw-r--r-- | 2.1 KB |
bounds.c | -rw-r--r-- | 600 bytes |
capability.c | -rw-r--r-- | 11.0 KB |
cgroup.c | -rw-r--r-- | 137.8 KB |
cgroup_freezer.c | -rw-r--r-- | 9.3 KB |
compat.c | -rw-r--r-- | 29.9 KB |
configs.c | -rw-r--r-- | 2.8 KB |
cpu.c | -rw-r--r-- | 15.7 KB |
cpu_pm.c | -rw-r--r-- | 6.5 KB |
cpuset.c | -rw-r--r-- | 73.1 KB |
crash_dump.c | -rw-r--r-- | 1.2 KB |
cred.c | -rw-r--r-- | 22.2 KB |
delayacct.c | -rw-r--r-- | 5.0 KB |
dma.c | -rw-r--r-- | 3.6 KB |
elfcore.c | -rw-r--r-- | 459 bytes |
exec_domain.c | -rw-r--r-- | 4.3 KB |
exit.c | -rw-r--r-- | 47.2 KB |
extable.c | -rw-r--r-- | 3.7 KB |
fork.c | -rw-r--r-- | 43.4 KB |
freezer.c | -rw-r--r-- | 4.2 KB |
futex.c | -rw-r--r-- | 70.8 KB |
futex_compat.c | -rw-r--r-- | 4.5 KB |
groups.c | -rw-r--r-- | 6.0 KB |
hrtimer.c | -rw-r--r-- | 46.4 KB |
hung_task.c | -rw-r--r-- | 5.2 KB |
irq_work.c | -rw-r--r-- | 3.1 KB |
itimer.c | -rw-r--r-- | 7.1 KB |
jump_label.c | -rw-r--r-- | 10.8 KB |
kallsyms.c | -rw-r--r-- | 14.2 KB |
kexec.c | -rw-r--r-- | 39.6 KB |
kfifo.c | -rw-r--r-- | 12.7 KB |
kmod.c | -rw-r--r-- | 17.3 KB |
kprobes.c | -rw-r--r-- | 56.4 KB |
ksysfs.c | -rw-r--r-- | 5.1 KB |
kthread.c | -rw-r--r-- | 12.5 KB |
latencytop.c | -rw-r--r-- | 7.6 KB |
lockdep.c | -rw-r--r-- | 102.9 KB |
lockdep_internals.h | -rw-r--r-- | 4.5 KB |
lockdep_proc.c | -rw-r--r-- | 17.0 KB |
lockdep_states.h | -rw-r--r-- | 233 bytes |
module.c | -rw-r--r-- | 89.7 KB |
mutex-debug.c | -rw-r--r-- | 2.9 KB |
mutex-debug.h | -rw-r--r-- | 1.7 KB |
mutex.c | -rw-r--r-- | 13.2 KB |
mutex.h | -rw-r--r-- | 1.3 KB |
notifier.c | -rw-r--r-- | 16.0 KB |
nsproxy.c | -rw-r--r-- | 5.9 KB |
padata.c | -rw-r--r-- | 27.2 KB |
panic.c | -rw-r--r-- | 10.8 KB |
params.c | -rw-r--r-- | 21.8 KB |
pid.c | -rw-r--r-- | 14.0 KB |
pid_namespace.c | -rw-r--r-- | 5.9 KB |
posix-cpu-timers.c | -rw-r--r-- | 41.1 KB |
posix-timers.c | -rw-r--r-- | 29.1 KB |
printk.c | -rw-r--r-- | 44.6 KB |
profile.c | -rw-r--r-- | 16.7 KB |
ptrace.c | -rw-r--r-- | 26.3 KB |
range.c | -rw-r--r-- | 2.9 KB |
rcu.h | -rw-r--r-- | 3.8 KB |
rcupdate.c | -rw-r--r-- | 9.7 KB |
rcutiny.c | -rw-r--r-- | 10.2 KB |
rcutiny_plugin.h | -rw-r--r-- | 33.4 KB |
rcutorture.c | -rw-r--r-- | 54.6 KB |
rcutree.c | -rw-r--r-- | 79.3 KB |
rcutree.h | -rw-r--r-- | 19.0 KB |
rcutree_plugin.h | -rw-r--r-- | 66.9 KB |
rcutree_trace.c | -rw-r--r-- | 13.8 KB |
relay.c | -rw-r--r-- | 32.8 KB |
res_counter.c | -rw-r--r-- | 4.5 KB |
resource.c | -rw-r--r-- | 26.8 KB |
rtmutex-debug.c | -rw-r--r-- | 4.7 KB |
rtmutex-debug.h | -rw-r--r-- | 1.4 KB |
rtmutex-tester.c | -rw-r--r-- | 8.7 KB |
rtmutex.c | -rw-r--r-- | 26.3 KB |
rtmutex.h | -rw-r--r-- | 1.1 KB |
rtmutex_common.h | -rw-r--r-- | 3.3 KB |
rwsem.c | -rw-r--r-- | 2.3 KB |
seccomp.c | -rw-r--r-- | 1.7 KB |
semaphore.c | -rw-r--r-- | 7.2 KB |
signal.c | -rw-r--r-- | 85.1 KB |
smp.c | -rw-r--r-- | 21.3 KB |
softirq.c | -rw-r--r-- | 22.0 KB |
spinlock.c | -rw-r--r-- | 9.5 KB |
srcu.c | -rw-r--r-- | 11.2 KB |
stacktrace.c | -rw-r--r-- | 1.1 KB |
stop_machine.c | -rw-r--r-- | 15.5 KB |
sys.c | -rw-r--r-- | 47.0 KB |
sys_ni.c | -rw-r--r-- | 5.8 KB |
sysctl.c | -rw-r--r-- | 56.8 KB |
sysctl_binary.c | -rw-r--r-- | 51.5 KB |
taskstats.c | -rw-r--r-- | 16.0 KB |
test_kprobes.c | -rw-r--r-- | 8.5 KB |
time.c | -rw-r--r-- | 18.6 KB |
timeconst.pl | -rw-r--r-- | 7.2 KB |
timer.c | -rw-r--r-- | 48.9 KB |
tracepoint.c | -rw-r--r-- | 19.7 KB |
tsacct.c | -rw-r--r-- | 4.3 KB |
uid16.c | -rw-r--r-- | 5.3 KB |
up.c | -rw-r--r-- | 413 bytes |
user-return-notifier.c | -rw-r--r-- | 1.3 KB |
user.c | -rw-r--r-- | 4.8 KB |
user_namespace.c | -rw-r--r-- | 3.4 KB |
utsname.c | -rw-r--r-- | 2.5 KB |
utsname_sysctl.c | -rw-r--r-- | 3.0 KB |
wait.c | -rw-r--r-- | 8.2 KB |
watchdog.c | -rw-r--r-- | 14.6 KB |
workqueue.c | -rw-r--r-- | 104.0 KB |
workqueue_sched.h | -rw-r--r-- | 311 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...