Revision 42d6c2e185ecbe608bc04bb5bb0484b9d6fcaf16 authored by Thomas Letan on 09 January 2023, 13:10:10 UTC, committed by Thomas Letan on 09 January 2023, 13:13:49 UTC
1 parent e2e6ccc
Makefile
PACKAGES_SUBPROJECT:=$(patsubst %.opam,%,$(notdir $(shell find src vendors -name \*.opam -print)))
PACKAGES:=$(patsubst %.opam,%,$(notdir $(shell find opam -name \*.opam -print)))
define directory_of_version
src/proto_$(shell echo $1 | tr -- - _)
endef
# Opam is not present in some build environments. We don't strictly need it.
# Those environments set TEZOS_WITHOUT_OPAM.
ifndef TEZOS_WITHOUT_OPAM
current_opam_version := $(shell opam --version)
endif
include scripts/version.sh
DOCKER_IMAGE_NAME := tezos
DOCKER_IMAGE_VERSION := latest
DOCKER_BUILD_IMAGE_NAME := $(DOCKER_IMAGE_NAME)_build
DOCKER_BUILD_IMAGE_VERSION := latest
DOCKER_BARE_IMAGE_NAME := $(DOCKER_IMAGE_NAME)-bare
DOCKER_BARE_IMAGE_VERSION := latest
DOCKER_DEBUG_IMAGE_NAME := $(DOCKER_IMAGE_NAME)-debug
DOCKER_DEBUG_IMAGE_VERSION := latest
DOCKER_DEPS_IMAGE_NAME := registry.gitlab.com/tezos/opam-repository
DOCKER_DEPS_IMAGE_VERSION := runtime-build-dependencies--${opam_repository_tag}
DOCKER_DEPS_MINIMAL_IMAGE_VERSION := runtime-dependencies--${opam_repository_tag}
COVERAGE_REPORT := _coverage_report
COBERTURA_REPORT := _coverage_report/cobertura.xml
CODE_QUALITY_REPORT := _reports/gl-code-quality-report.json
PROFILE?=dev
VALID_PROFILES=dev release static
# See the documentation of [~release_status] in [manifest/manifest.mli].
RELEASED_EXECUTABLES := $(shell cat script-inputs/released-executables)
EXPERIMENTAL_EXECUTABLES := $(shell cat script-inputs/experimental-executables)
# Executables that developers need at the root of the repository but that
# are not useful for users.
# - scripts/snapshot_alpha.sh expects octez-protocol-compiler to be at the root.
# - Some tests expect octez-snoop to be at the root.
DEV_EXECUTABLES := octez-protocol-compiler octez-snoop
ALL_EXECUTABLES := $(RELEASED_EXECUTABLES) $(EXPERIMENTAL_EXECUTABLES) $(DEV_EXECUTABLES)
# See first mention of TEZOS_WITHOUT_OPAM.
ifndef TEZOS_WITHOUT_OPAM
ifeq ($(filter ${opam_version}.%,${current_opam_version}),)
$(error Unexpected opam version (found: ${current_opam_version}, expected: ${opam_version}.*))
endif
endif
ifeq ($(filter ${VALID_PROFILES},${PROFILE}),)
$(error Unexpected dune profile (got: ${PROFILE}, expecting one of: ${VALID_PROFILES}))
endif
# This check ensures that the `OCTEZ_EXECUTABLES` variable contains a subset of
# the `ALL_EXECUTABLE` variable. The `OCTEZ_EXECUTABLES` variable is used
# internally to select a subset of which executables to build.
# The reason for the `foreach` is so that we support both newlines and spaces.
ifneq ($(filter ${ALL_EXECUTABLES},${OCTEZ_EXECUTABLES}),$(foreach executable,${OCTEZ_EXECUTABLES},${executable}))
$(error Unexpected list of executables to build, make sure environment variable OCTEZ_EXECUTABLES is unset)
endif
# Where to copy executables.
# Used when building Docker images to help with the COPY instruction.
OCTEZ_BIN_DIR?=.
VALID_OCTEZ_BIN_DIRS=. bin
ifeq ($(filter ${VALID_OCTEZ_BIN_DIRS},${OCTEZ_BIN_DIR}),)
$(error Unexpected value for OCTEZ_BIN_DIR (got: ${OCTEZ_BIN_DIR}, expecting one of: ${VALID_OCTEZ_BIN_DIRS}))
endif
# See first mention of TEZOS_WITHOUT_OPAM.
ifdef TEZOS_WITHOUT_OPAM
current_ocaml_version := $(shell ocamlc -version)
else
current_ocaml_version := $(shell opam exec -- ocamlc -version)
endif
# Default target.
#
# Note that you can override the list of executables to build on the command-line, e.g.:
#
# make OCTEZ_EXECUTABLES='octez-node octez-client'
#
# This is more efficient than 'make octez-node octez-client'
# because it only calls 'dune' once.
#
# Targets 'all', 'release', 'experimental-release' and 'static' define different
# default lists of executables to build but they all can be overridden from the command-line.
.PHONY: all
all:
@$(MAKE) build OCTEZ_EXECUTABLES?="$(ALL_EXECUTABLES)"
.PHONY: release
release:
@$(MAKE) build PROFILE=release OCTEZ_EXECUTABLES?="$(RELEASED_EXECUTABLES)"
.PHONY: experimental-release
experimental-release:
@$(MAKE) build PROFILE=release OCTEZ_EXECUTABLES?="$(RELEASED_EXECUTABLES) $(EXPERIMENTAL_EXECUTABLES)"
.PHONY: static
static:
@$(MAKE) build PROFILE=static OCTEZ_EXECUTABLES?="$(RELEASED_EXECUTABLES)"
.PHONY: build-parameters
build-parameters:
@dune build --profile=$(PROFILE) $(COVERAGE_OPTIONS) @copy-parameters
.PHONY: $(ALL_EXECUTABLES)
$(ALL_EXECUTABLES):
dune build $(COVERAGE_OPTIONS) --profile=$(PROFILE) _build/install/default/bin/$@
cp -f _build/install/default/bin/$@ ./
# Remove the old names of executables.
# Depending on the commit you are updating from (v14.0, v15 or some version of master),
# the exact list can vary. We just remove all of them.
# Don't try to generate this list from *_EXECUTABLES: this list should not evolve as
# we add new executables, and this list should contain executables that were built
# before (e.g. old protocol daemons) but that are no longer built.
.PHONY: clean-old-names
clean-old-names:
@rm -f tezos-node
@rm -f tezos-validator
@rm -f tezos-client
@rm -f tezos-admin-client
@rm -f tezos-signer
@rm -f tezos-codec
@rm -f tezos-protocol-compiler
@rm -f tezos-proxy-server
@rm -f tezos-baker-012-Psithaca
@rm -f tezos-accuser-012-Psithaca
@rm -f tezos-baker-013-PtJakart
@rm -f tezos-accuser-013-PtJakart
@rm -f tezos-tx-rollup-node-013-PtJakart
@rm -f tezos-tx-rollup-client-013-PtJakart
@rm -f tezos-baker-014-PtKathma
@rm -f tezos-accuser-014-PtKathma
@rm -f tezos-tx-rollup-node-014-PtKathma
@rm -f tezos-tx-rollup-client-014-PtKathma
@rm -f tezos-baker-015-PtLimaPt
@rm -f tezos-accuser-015-PtLimaPt
@rm -f tezos-tx-rollup-node-015-PtLimaPt
@rm -f tezos-tx-rollup-client-015-PtLimaPt
@rm -f tezos-baker-alpha
@rm -f tezos-accuser-alpha
@rm -f tezos-smart-rollup-node-alpha
@rm -f tezos-smart-rollup-client-alpha
@rm -f tezos-snoop
@rm -f tezos-dal-node
# octez-validator should stay in this list for Octez 16.0 because we
# removed the executable
@rm -f octez-validator
@rm -f octez-baker-012-Psithaca
@rm -f octez-accuser-012-Psithaca
@rm -f octez-baker-013-PtJakart
@rm -f octez-accuser-013-PtJakart
@rm -f octez-tx-rollup-node-013-PtJakart
@rm -f octez-tx-rollup-client-013-PtJakart
@rm -f octez-baker-014-PtKathma
@rm -f octez-accuser-014-PtKathma
@rm -f octez-tx-rollup-node-014-PtKathma
@rm -f octez-tx-rollup-client-014-PtKathma
@rm -f octez-baker-015-PtLimaPt
@rm -f octez-accuser-015-PtLimaPt
@rm -f octez-tx-rollup-node-015-PtLimaPt
@rm -f octez-tx-rollup-client-015-PtLimaPt
# See comment of clean-old-names for an explanation regarding why we do not try
# to generate the symbolic links from *_EXECUTABLES.
.PHONY: build
build: clean-old-names
ifneq (${current_ocaml_version},${ocaml_version})
$(error Unexpected ocaml version (found: ${current_ocaml_version}, expected: ${ocaml_version}))
endif
ifeq (${OCTEZ_EXECUTABLES},)
$(error The build target requires OCTEZ_EXECUTABLES to be specified. Please use another target (e.g. 'make' or 'make release') and make sure that environment variable OCTEZ_EXECUTABLES is unset)
endif
@dune build --profile=$(PROFILE) $(COVERAGE_OPTIONS) \
$(foreach b, $(OCTEZ_EXECUTABLES), _build/install/default/bin/${b}) \
@copy-parameters
@mkdir -p $(OCTEZ_BIN_DIR)/
@cp -f $(foreach b, $(OCTEZ_EXECUTABLES), _build/install/default/bin/${b}) $(OCTEZ_BIN_DIR)/
@ln -s $(OCTEZ_BIN_DIR)/octez-node tezos-node
@ln -s $(OCTEZ_BIN_DIR)/octez-client tezos-client
@ln -s $(OCTEZ_BIN_DIR)/octez-admin-client tezos-admin-client
@ln -s $(OCTEZ_BIN_DIR)/octez-signer tezos-signer
@ln -s $(OCTEZ_BIN_DIR)/octez-codec tezos-codec
@ln -s $(OCTEZ_BIN_DIR)/octez-protocol-compiler tezos-protocol-compiler
@ln -s $(OCTEZ_BIN_DIR)/octez-proxy-server tezos-proxy-server
@ln -s $(OCTEZ_BIN_DIR)/octez-baker-PtKathma tezos-baker-014-PtKathma
@ln -s $(OCTEZ_BIN_DIR)/octez-accuser-PtKathma tezos-accuser-014-PtKathma
@ln -s $(OCTEZ_BIN_DIR)/octez-tx-rollup-node-PtKathma tezos-tx-rollup-node-014-PtKathma
@ln -s $(OCTEZ_BIN_DIR)/octez-tx-rollup-client-PtKathma tezos-tx-rollup-client-014-PtKathma
@ln -s $(OCTEZ_BIN_DIR)/octez-baker-PtLimaPt tezos-baker-015-PtLimaPt
@ln -s $(OCTEZ_BIN_DIR)/octez-accuser-PtLimaPt tezos-accuser-015-PtLimaPt
@ln -s $(OCTEZ_BIN_DIR)/octez-tx-rollup-node-PtLimaPt tezos-tx-rollup-node-015-PtLimaPt
@ln -s $(OCTEZ_BIN_DIR)/octez-tx-rollup-client-PtLimaPt tezos-tx-rollup-client-015-PtLimaPt
@ln -s $(OCTEZ_BIN_DIR)/octez-baker-alpha tezos-baker-alpha
@ln -s $(OCTEZ_BIN_DIR)/octez-accuser-alpha tezos-accuser-alpha
# List protocols, i.e. directories proto_* in src with a TEZOS_PROTOCOL file.
TEZOS_PROTOCOL_FILES=$(wildcard src/proto_*/lib_protocol/TEZOS_PROTOCOL)
PROTOCOLS=$(patsubst %/lib_protocol/TEZOS_PROTOCOL,%,${TEZOS_PROTOCOL_FILES})
.PHONY: all.pkg
all.pkg:
@dune build --profile=$(PROFILE) \
$(patsubst %.opam,%.install, $(shell find src vendors -name \*.opam -print))
$(addsuffix .pkg,${PACKAGES_SUBPROJECT}): %.pkg:
@dune build --profile=$(PROFILE) \
$(patsubst %.opam,%.install, $(shell find src vendors -name $*.opam -print))
$(addsuffix .pkg,${PACKAGES}): %.pkg:
dune build --profile=$(PROFILE) $(patsubst %.opam,%.install,$*.opam)
$(addsuffix .test,${PACKAGES_SUBPROJECT}): %.test:
@dune build --profile=$(PROFILE) \
@$(patsubst %/$*.opam,%,$(shell find src vendors -name $*.opam))/runtest
$(addsuffix .test,${PACKAGES}): %.test:
@echo "'make $*.test' is no longer supported"
.PHONY: coverage-report
coverage-report:
@bisect-ppx-report html --tree --ignore-missing-files -o ${COVERAGE_REPORT} --coverage-path ${COVERAGE_OUTPUT}
@echo "Report should be available in file://$(shell pwd)/${COVERAGE_REPORT}/index.html"
.PHONY: coverage-report-summary
coverage-report-summary:
@bisect-ppx-report summary --coverage-path ${COVERAGE_OUTPUT}
.PHONY: coverage-report-cobertura
coverage-report-cobertura:
@bisect-ppx-report cobertura --ignore-missing-file --coverage-path ${COVERAGE_OUTPUT} ${COBERTURA_REPORT}
@echo "Cobertura report should be available in ${COBERTURA_REPORT}"
.PHONY: enable-time-measurement
enable-time-measurement:
@$(MAKE) all DUNE_INSTRUMENT_WITH=tezos-time-measurement
.PHONY: test-protocol-compile
test-protocol-compile:
@dune build --profile=$(PROFILE) $(COVERAGE_OPTIONS) @runtest_compile_protocol
@dune build --profile=$(PROFILE) $(COVERAGE_OPTIONS) @runtest_out_of_opam
PROTO_DIRS := $(shell find src/ -maxdepth 1 -type d -path "src/proto_*" 2>/dev/null | LC_COLLATE=C sort)
NONPROTO_DIRS := $(shell find src/ -maxdepth 1 -mindepth 1 -type d -not -path "src/proto_*" 2>/dev/null | LC_COLLATE=C sort)
.PHONY: test-proto-unit
test-proto-unit:
DUNE_PROFILE=$(PROFILE) \
COVERAGE_OPTIONS="$(COVERAGE_OPTIONS)" \
scripts/test_wrapper.sh test-proto-unit \
$(addprefix @, $(addsuffix /runtest,$(PROTO_DIRS)))
.PHONY: test-nonproto-unit
test-nonproto-unit:
DUNE_PROFILE=$(PROFILE) \
COVERAGE_OPTIONS="$(COVERAGE_OPTIONS)" \
scripts/test_wrapper.sh test-nonproto-unit \
$(addprefix @, $(addsuffix /runtest,$(NONPROTO_DIRS)))
.PHONY: test-unit
test-unit: test-nonproto-unit test-proto-unit
.PHONY: test-unit-alpha
test-unit-alpha:
@dune build --profile=$(PROFILE) @src/proto_alpha/lib_protocol/runtest
.PHONY: test-python
test-python: all
@$(MAKE) -C tests_python all
.PHONY: test-python-alpha
test-python-alpha: all
@$(MAKE) -C tests_python alpha
.PHONY: test-python-tenderbake
test-python-tenderbake: all
@$(MAKE) -C tests_python tenderbake
# TODO: https://gitlab.com/tezos/tezos/-/issues/3018
# Disable verbose once the log file bug in Alcotest is fixed.
.PHONY: test-js
test-js:
@dune build --error-reporting=twice @runtest_js
.PHONY: build-tezt
build-tezt:
@dune build tezt
.PHONY: test-tezt
test-tezt:
@dune exec --profile=$(PROFILE) $(COVERAGE_OPTIONS) tezt/tests/main.exe
.PHONY: test-tezt-i
test-tezt-i:
@dune exec --profile=$(PROFILE) $(COVERAGE_OPTIONS) tezt/tests/main.exe -- --info
.PHONY: test-tezt-c
test-tezt-c:
@dune exec --profile=$(PROFILE) $(COVERAGE_OPTIONS) tezt/tests/main.exe -- --commands
.PHONY: test-tezt-v
test-tezt-v:
@dune exec --profile=$(PROFILE) $(COVERAGE_OPTIONS) tezt/tests/main.exe -- --verbose
.PHONY: test-tezt-coverage
test-tezt-coverage:
@dune exec --profile=$(PROFILE) $(COVERAGE_OPTIONS) tezt/tests/main.exe -- --keep-going --test-timeout 1800
.PHONY: test-code
test-code: test-protocol-compile test-unit test-python test-tezt
# This is as `make test-code` except we allow failure (prefix "-")
# because we still want the coverage report even if an individual
# test happens to fail.
.PHONY: test-coverage
test-coverage:
-@$(MAKE) test-protocol-compile
-@$(MAKE) test-unit
-@$(MAKE) test-python
-@$(MAKE) test-tezt
.PHONY: test-coverage-tenderbake
test-coverage-tenderbake:
-@$(MAKE) test-unit-alpha
-@$(MAKE) test-python-tenderbake
.PHONY: test-webassembly
test-webassembly:
@dune build --profile=$(PROFILE) @src/lib_webassembly/bin/runtest-python
.PHONY: lint-opam-dune
lint-opam-dune:
@dune build --profile=$(PROFILE) @runtest_dune_template
# Ensure that all unit tests are restricted to their opam package
# (change 'tezos-test-helpers' to one the most elementary packages of
# the repo if you add "internal" dependencies to tezos-test-helpers)
.PHONY: lint-tests-pkg
lint-tests-pkg:
@(dune build -p tezos-test-helpers @runtest @runtest_js) || \
{ echo "You have probably defined some tests in dune files without specifying to which 'package' they belong."; exit 1; }
TEST_DIRS := $(shell find src -name "test" -type d -print -o -name "test-*" -type d -print)
EXCLUDE_TEST_DIRS := $(addprefix --exclude-file ,$(addsuffix /,${TEST_DIRS}))
.PHONY: lint-ometrics
lint-ometrics:
@echo "Running ometrics analysis in your changes"
@ometrics check ${EXCLUDE_TEST_DIRS} \
--exclude-file "src/proto_alpha/lib_protocol/alpha_context.mli" \
--exclude-file "src/proto_alpha/lib_protocol/alpha_context.ml" \
--exclude-file "tezt/tests/" \
--exclude-entry-re "pp\|pp_.+" \
--exclude-entry-re "encoding\|encoding_.+\|.+_encoding" \
--exclude-entry-re "compare\|compare_.+\|.+_compare"
.PHONY: lint-ometrics-gitlab
lint-ometrics-gitlab:
@echo "Running ometrics analysis in your changes."
@mkdir -p _reports
@ometrics check-clone ${OMETRICS_GIT} --branch ${OMETRICS_BRANCH} \
${EXCLUDE_TEST_DIRS} \
--exclude-file "src/proto_alpha/lib_protocol/alpha_context.mli" \
--exclude-file "src/proto_alpha/lib_protocol/alpha_context.ml" \
--exclude-file "tezt/tests/" \
--exclude-entry-re "pp\|pp_.+" \
--exclude-entry-re "encoding\|encoding_.+\|.+_encoding" \
--exclude-entry-re "compare\|compare_.+\|.+_compare" \
--gitlab --output ${CODE_QUALITY_REPORT}
@echo "Report should be available in file://$(shell pwd)/${CODE_QUALITY_REPORT}"
.PHONY: test
test: test-code
.PHONY: check-linting check-python-linting check-ocaml-linting
check-linting:
@scripts/lint.sh --check-scripts
@scripts/lint.sh --check-ocamlformat
@scripts/lint.sh --check-coq-attributes
@dune build --profile=$(PROFILE) @fmt
check-python-linting:
@$(MAKE) -C tests_python lint
@$(MAKE) -C docs lint
check-ocaml-linting:
@./scripts/semgrep/lint-all-ocaml-sources.sh
.PHONY: fmt fmt-ocaml fmt-python
fmt: fmt-ocaml fmt-python
fmt-ocaml:
@dune build --profile=$(PROFILE) @fmt --auto-promote
fmt-python:
@$(MAKE) -C tests_python fmt
.PHONY: build-deps
build-deps:
@./scripts/install_build_deps.sh
.PHONY: build-dev-deps
build-dev-deps:
@./scripts/install_build_deps.sh --dev
.PHONY: lift-protocol-limits-patch
lift-protocol-limits-patch:
@git apply -R ./src/bin_tps_evaluation/lift_limits.patch || true
@git apply ./src/bin_tps_evaluation/lift_limits.patch
.PHONY: build-tps-deps
build-tps-deps:
@./scripts/install_build_deps.sh --tps
.PHONY: build-tps
build-tps: lift-protocol-limits-patch build build-tezt
@dune build ./src/bin_tps_evaluation
@cp -f ./_build/default/src/bin_tps_evaluation/main_tps_evaluation.exe tezos-tps-evaluation
@cp -f ./src/bin_tps_evaluation/tezos-tps-evaluation-benchmark-tps .
@cp -f ./src/bin_tps_evaluation/tezos-tps-evaluation-estimate-average-block .
@cp -f ./src/bin_tps_evaluation/tezos-tps-evaluation-gas-tps .
.PHONY: build-unreleased
build-unreleased: all
@echo 'Note: "make build-unreleased" is deprecated. Just use "make".'
.PHONY: docker-image-build
docker-image-build:
@docker build \
-t $(DOCKER_BUILD_IMAGE_NAME):$(DOCKER_BUILD_IMAGE_VERSION) \
-f build.Dockerfile \
--build-arg BASE_IMAGE=$(DOCKER_DEPS_IMAGE_NAME) \
--build-arg BASE_IMAGE_VERSION=$(DOCKER_DEPS_IMAGE_VERSION) \
.
.PHONY: docker-image-debug
docker-image-debug:
docker build \
-t $(DOCKER_DEBUG_IMAGE_NAME):$(DOCKER_DEBUG_IMAGE_VERSION) \
--build-arg BASE_IMAGE=$(DOCKER_DEPS_IMAGE_NAME) \
--build-arg BASE_IMAGE_VERSION=$(DOCKER_DEPS_MINIMAL_IMAGE_VERSION) \
--build-arg BUILD_IMAGE=$(DOCKER_BUILD_IMAGE_NAME) \
--build-arg BUILD_IMAGE_VERSION=$(DOCKER_BUILD_IMAGE_VERSION) \
--target=debug \
.
.PHONY: docker-image-bare
docker-image-bare:
@docker build \
-t $(DOCKER_BARE_IMAGE_NAME):$(DOCKER_BARE_IMAGE_VERSION) \
--build-arg=BASE_IMAGE=$(DOCKER_DEPS_IMAGE_NAME) \
--build-arg=BASE_IMAGE_VERSION=$(DOCKER_DEPS_MINIMAL_IMAGE_VERSION) \
--build-arg=BASE_IMAGE_VERSION_NON_MIN=$(DOCKER_DEPS_IMAGE_VERSION) \
--build-arg BUILD_IMAGE=$(DOCKER_BUILD_IMAGE_NAME) \
--build-arg BUILD_IMAGE_VERSION=$(DOCKER_BUILD_IMAGE_VERSION) \
--target=bare \
.
.PHONY: docker-image-minimal
docker-image-minimal:
@docker build \
-t $(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_VERSION) \
--build-arg=BASE_IMAGE=$(DOCKER_DEPS_IMAGE_NAME) \
--build-arg=BASE_IMAGE_VERSION=$(DOCKER_DEPS_MINIMAL_IMAGE_VERSION) \
--build-arg=BASE_IMAGE_VERSION_NON_MIN=$(DOCKER_DEPS_IMAGE_VERSION) \
--build-arg BUILD_IMAGE=$(DOCKER_BUILD_IMAGE_NAME) \
--build-arg BUILD_IMAGE_VERSION=$(DOCKER_BUILD_IMAGE_VERSION) \
.
.PHONY: docker-image
docker-image: docker-image-build docker-image-debug docker-image-bare docker-image-minimal
.PHONY: install
install:
@dune build --profile=$(PROFILE) @install
@dune install
.PHONY: uninstall
uninstall:
@dune uninstall
.PHONY: coverage-clean
coverage-clean:
@-rm -Rf ${COVERAGE_OUTPUT}/*.coverage ${COVERAGE_REPORT}
.PHONY: clean
clean: coverage-clean clean-old-names
@-dune clean
@-rm -f ${OCTEZ_BIN} ${UNRELEASED_OCTEZ_BIN}
@-${MAKE} -C docs clean
@-${MAKE} -C tests_python clean
@-rm -f docs/api/tezos-{baker,endorser,accuser}-alpha.html docs/api/tezos-{admin-,}client.html docs/api/tezos-signer.html
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...