Revision 4504ab0e6eb801555368cbb3011ab0530f659d4b authored by Vakul Garg on 12 March 2019, 08:22:57 UTC, committed by David S. Miller on 13 March 2019, 21:16:44 UTC
A previous fix ("tls: Fix write space handling") assumed that user space application gets informed about the socket send buffer availability when tls_push_sg() gets called. Inside tls_push_sg(), in case do_tcp_sendpages() returns 0, the function returns without calling ctx->sk_write_space. Further, the new function tls_sw_write_space() did not invoke ctx->sk_write_space. This leads to situation that user space application encounters a lockup always waiting for socket send buffer to become available. Rather than call ctx->sk_write_space from tls_push_sg(), it should be called from tls_write_space. So whenever tcp stack invokes sk->sk_write_space after freeing socket send buffer, we always declare the same to user space by the way of invoking ctx->sk_write_space. Fixes: 7463d3a2db0ef ("tls: Fix write space handling") Signed-off-by: Vakul Garg <vakul.garg@nxp.com> Reviewed-by: Boris Pismenny <borisp@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 5b5f99b
File | Mode | Size |
---|---|---|
Makefile | -rw-r--r-- | 793 bytes |
common.c | -rw-r--r-- | 19.0 KB |
generic.c | -rw-r--r-- | 9.0 KB |
generic_report.c | -rw-r--r-- | 4.1 KB |
init.c | -rw-r--r-- | 11.3 KB |
kasan.h | -rw-r--r-- | 6.9 KB |
quarantine.c | -rw-r--r-- | 8.8 KB |
report.c | -rw-r--r-- | 8.3 KB |
tags.c | -rw-r--r-- | 4.7 KB |
tags_report.c | -rw-r--r-- | 1.4 KB |
Computing file changes ...