Revision 4504ab0e6eb801555368cbb3011ab0530f659d4b authored by Vakul Garg on 12 March 2019, 08:22:57 UTC, committed by David S. Miller on 13 March 2019, 21:16:44 UTC
A previous fix ("tls: Fix write space handling") assumed that
user space application gets informed about the socket send buffer
availability when tls_push_sg() gets called. Inside tls_push_sg(), in
case do_tcp_sendpages() returns 0, the function returns without calling
ctx->sk_write_space. Further, the new function tls_sw_write_space()
did not invoke ctx->sk_write_space. This leads to situation that user
space application encounters a lockup always waiting for socket send
buffer to become available.

Rather than call ctx->sk_write_space from tls_push_sg(), it should be
called from tls_write_space. So whenever tcp stack invokes
sk->sk_write_space after freeing socket send buffer, we always declare
the same to user space by the way of invoking ctx->sk_write_space.

Fixes: 7463d3a2db0ef ("tls: Fix write space handling")
Signed-off-by: Vakul Garg <vakul.garg@nxp.com>
Reviewed-by: Boris Pismenny <borisp@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 5b5f99b
History
File Mode Size
ad1816a
ad1848
cs423x
es1688
galaxy
gus
msnd
opti9xx
sb
wavefront
wss
Kconfig -rw-r--r-- 12.7 KB
Makefile -rw-r--r-- 892 bytes
adlib.c -rw-r--r-- 2.6 KB
als100.c -rw-r--r-- 10.4 KB
azt2320.c -rw-r--r-- 9.6 KB
cmi8328.c -rw-r--r-- 13.4 KB
cmi8330.c -rw-r--r-- 22.6 KB
es18xx.c -rw-r--r-- 69.4 KB
opl3sa2.c -rw-r--r-- 29.0 KB
sc6000.c -rw-r--r-- 17.8 KB
sscape.c -rw-r--r-- 32.7 KB

back to top