Revision 450b24e6a7b915dda381fd5c35f4354988ddd333 authored by Vincenzo Eduardo Padulano on 03 June 2024, 06:34:42 UTC, committed by Vincenzo Eduardo Padulano on 04 June 2024, 15:03:53 UTC
In the RDataFrame computation graph execution, the `RAction::Run` method is responsible for requesting the values from the readers that are necessary for that action. This is done by calling `RColumnReaderBase::Get` with the correct template type given by the variadic argument type list of the action, which corresponds to the list of column types that action requires. So far, this variadic template function call was done by simply unpacking the argument pack as the arguments to the `Exec` function of the action helper data member. This meant that the execution order was never guaranteed (undefined until C++17, unspecified since), according to the explanation at https://en.cppreference.com/w/cpp/language/eval_order. This commit ensures that the execution order of the calls to the `Get` method of the readers is done left to right, following the same order of the template parameter pack. This is done by using the sequenced-before feature of the list-initialization of any C++ struct/class. A simple struct helper is used to this end.
1 parent 2ddc3b1
File | Mode | Size |
---|---|---|
.ci | ||
.github | ||
README | ||
bindings | ||
build | ||
builtins | ||
cmake | ||
config | ||
core | ||
doc | ||
documentation | ||
etc | ||
fonts | ||
geom | ||
graf2d | ||
graf3d | ||
gui | ||
hist | ||
html | ||
icons | ||
interpreter | ||
io | ||
js | ||
macros | ||
main | ||
man | ||
math | ||
misc | ||
montecarlo | ||
net | ||
proof | ||
roofit | ||
rootx | ||
sql | ||
test | ||
tmva | ||
tree | ||
tutorials | ||
ui5 | ||
.clang-format | -rw-r--r-- | 3.0 KB |
.clang-tidy | -rw-r--r-- | 22 bytes |
.git-commit-template | -rw-r--r-- | 813 bytes |
.gitattributes | -rw-r--r-- | 598 bytes |
.gitignore | -rw-r--r-- | 550 bytes |
.mailmap | -rw-r--r-- | 9.6 KB |
.travis.yml | -rw-r--r-- | 1.9 KB |
.typos.toml | -rw-r--r-- | 440 bytes |
CMakeLists.txt | -rw-r--r-- | 37.0 KB |
CONTRIBUTING.md | -rw-r--r-- | 7.8 KB |
LGPL2_1.txt | -rw-r--r-- | 23.9 KB |
LICENSE | -rw-r--r-- | 989 bytes |
README.md | -rw-r--r-- | 3.7 KB |
configure | -rwxr-xr-x | 180 bytes |
requirements.txt | -rw-r--r-- | 782 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...