Skip to main content

Browse the archive

https://github.com/torvalds/linux
26 November 2022, 15:45:29 UTC
Revision 452b94b8c8c7eb7dd0d0fa9a9776e0d02cd73b97 authored by Linus Torvalds on 20 March 2017, 02:00:47 UTC, committed by Linus Torvalds on 20 March 2017, 02:00:47 UTC 
mm/swap: don't BUG_ON() due to uninitialized swap slot cache
 
This BUG_ON() triggered for me once at shutdown, and I don't see a
reason for the check.  The code correctly checks whether the swap slot
cache is usable or not, so an uninitialized swap slot cache is not
actually problematic afaik.

I've temporarily just switched the BUG_ON() to a WARN_ON_ONCE(), since
I'm not sure why that seemingly pointless check was there.  I suspect
the real fix is to just remove it entirely, but for now we'll warn about
it but not bring the machine down.

Cc: "Huang, Ying" <ying.huang@intel.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent a07a6e4
History
Tip revision: 452b94b8c8c7eb7dd0d0fa9a9776e0d02cd73b97 authored by Linus Torvalds on 20 March 2017, 02:00:47 UTC
mm/swap: don't BUG_ON() due to uninitialized swap slot cache
Tip revision: 452b94b
File Mode Size
Documentation
arch
block
certs
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.cocciconfig -rw-r--r-- 59 bytes
.get_maintainer.ignore -rw-r--r-- 31 bytes
.gitattributes -rw-r--r-- 30 bytes
.gitignore -rw-r--r-- 1.3 KB
.mailmap -rw-r--r-- 7.7 KB
COPYING -rw-r--r-- 18.3 KB
CREDITS -rw-r--r-- 96.0 KB
Kbuild -rw-r--r-- 2.8 KB
Kconfig -rw-r--r-- 252 bytes
MAINTAINERS -rw-r--r-- 389.3 KB
Makefile -rw-r--r-- 57.7 KB
README -rw-r--r-- 722 bytes

README

back to top