Skip to main content

Browse the archive

https://github.com/torvalds/linux
05 April 2024, 19:05:47 UTC
Revision 45e77d314585869dfe43c82679f7e08c9b35b898 authored by Ilpo Järvinen on 19 July 2010, 01:16:18 UTC, committed by David S. Miller on 19 July 2010, 19:43:49 UTC 
tcp: fix crash in tcp_xmit_retransmit_queue
 
It can happen that there are no packets in queue while calling
tcp_xmit_retransmit_queue(). tcp_write_queue_head() then returns
NULL and that gets deref'ed to get sacked into a local var.

There is no work to do if no packets are outstanding so we just
exit early.

This oops was introduced by 08ebd1721ab8fd (tcp: remove tp->lost_out
guard to make joining diff nicer).

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Reported-by: Lennart Schulte <lennart.schulte@nets.rwth-aachen.de>
Tested-by: Lennart Schulte <lennart.schulte@nets.rwth-aachen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent b508998
History
Tip revision: 45e77d314585869dfe43c82679f7e08c9b35b898 authored by Ilpo Järvinen on 19 July 2010, 01:16:18 UTC
tcp: fix crash in tcp_xmit_retransmit_queue
Tip revision: 45e77d3
File Mode Size
Kconfig -rw-r--r-- 40.1 KB
Makefile -rw-r--r-- 1.0 KB
calibrate.c -rw-r--r-- 5.1 KB
do_mounts.c -rw-r--r-- 9.3 KB
do_mounts.h -rw-r--r-- 1.4 KB
do_mounts_initrd.c -rw-r--r-- 3.1 KB
do_mounts_md.c -rw-r--r-- 7.9 KB
do_mounts_rd.c -rw-r--r-- 8.0 KB
initramfs.c -rw-r--r-- 12.6 KB
main.c -rw-r--r-- 21.5 KB
noinitramfs.c -rw-r--r-- 1.4 KB
version.c -rw-r--r-- 1.1 KB
back to top