Skip to main content

Browse the archive

Revision 4624edc440a1623c2e548db7fd3db33a6380f4cc authored by Siying Dong on 22 February 2018, 21:23:53 UTC, committed by Facebook Github Bot on 22 February 2018, 21:28:12 UTC 
RocksDBOptionsParser::Parse()'s `ignore_unknown_options` argument only ingores options from higher version.
 
Summary:
RocksDB should always be able to parse an option file generated using the same or lower version. Unknown option should only happen if it is from a higher version. Change the behavior of RocksDBOptionsParser::Parse()'s behavior with ignore_unknown_options=true so that unknown option from a lower or the same version will never be skipped.
Closes https://github.com/facebook/rocksdb/pull/3527

Differential Revision: D7048851

Pulled By: siying

fbshipit-source-id: e261caea12f6515611a4a29f39acf2b619df2361
1 parent aba3409
Raw File
AUTHORS 
Facebook Inc.
Facebook Engineering Team

Google Inc.
# Initial version authors:
Jeffrey Dean <jeff@google.com>
Sanjay Ghemawat <sanjay@google.com>

# Partial list of contributors:
Kevin Regan <kevin.d.regan@gmail.com>
Johan Bilien <jobi@litl.com>
Matthew Von-Maszewski <https://github.com/matthewvon> (Basho Technologies)
back to top