Skip to main content

Browse the archive

Revision 46c8d39a9fde254df3398c681fd724990d289892 authored by Manuel Rego Casasnovas on 22 June 2018, 14:40:57 UTC, committed by Blink WPT Bot on 22 June 2018, 15:00:17 UTC 
[css-contain] Size containment replaced elements intrinsic size is zero
 
The spec is very clear about this
(https://drafts.csswg.org/css-contain/#containment-size):
  "Replaced elements must be treated as having an intrinsic width
   and height of 0."

The patch modifies LayoutReplaced::ComputeIntrinsicSizingInfo()
so that it returns zero for elements with "contain: size".

BUG=853441
TEST=external/wpt/css/css-contain/contain-size-013.html

Change-Id: I91490b120a110be20a91d564da4fdc3d9a11b70a
Reviewed-on: https://chromium-review.googlesource.com/1110819
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#569610}
1 parent fb04aed
Raw File
compressedTexImage2D.html 
<!doctype html>
<title>compressedTexImage2D</title>
<link rel=author href=mailto:Ms2ger@gmail.com title=Ms2ger>
<link rel=help href=https://www.khronos.org/registry/webgl/specs/latest/#5.14.8>
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>
<script src=common.js></script>

<div id=log></div>
<script>
test(function() {
  var COMPRESSED_RGB_S3TC_DXT1_EXT = 0x83F0;
  var gl = getGl();

  var tex = gl.createTexture();
  gl.bindTexture(gl.TEXTURE_2D, tex);

  shouldGenerateGLError(gl, gl.INVALID_ENUM, function() {
    gl.compressedTexImage2D(gl.TEXTURE_2D, 0, COMPRESSED_RGB_S3TC_DXT1_EXT, 4, 4, 0, new Uint8Array(8));
  });
  shouldGenerateGLError(gl, gl.INVALID_ENUM, function() {
    gl.compressedTexImage2D(gl.TEXTURE_2D, 0, COMPRESSED_RGB_S3TC_DXT1_EXT, 4, 4, 0, new Uint8Array(8), null);
  });
  test(function() {
    assert_throws(new TypeError(), function() {
      gl.compressedTexImage2D(gl.TEXTURE_2D, 0, COMPRESSED_RGB_S3TC_DXT1_EXT, 4, 4, 0);
    });
  }, "Should throw a TypeError when passing too few arguments.");
});
</script>
back to top