Skip to main content

Browse the archive

Revision 46c8d39a9fde254df3398c681fd724990d289892 authored by Manuel Rego Casasnovas on 22 June 2018, 14:40:57 UTC, committed by Blink WPT Bot on 22 June 2018, 15:00:17 UTC 
[css-contain] Size containment replaced elements intrinsic size is zero
 
The spec is very clear about this
(https://drafts.csswg.org/css-contain/#containment-size):
  "Replaced elements must be treated as having an intrinsic width
   and height of 0."

The patch modifies LayoutReplaced::ComputeIntrinsicSizingInfo()
so that it returns zero for elements with "contain: size".

BUG=853441
TEST=external/wpt/css/css-contain/contain-size-013.html

Change-Id: I91490b120a110be20a91d564da4fdc3d9a11b70a
Reviewed-on: https://chromium-review.googlesource.com/1110819
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#569610}
1 parent fb04aed
Raw File
responseurl.html 
<!doctype html>
<html>
  <head>
    <title>XMLHttpRequest: responseURL test</title>
    <script src="/resources/testharness.js"></script>
    <script src="/resources/testharnessreport.js"></script>
    <link rel="help" href="https://xhr.spec.whatwg.org/#the-responseurl-attribute"/>
  </head>
  <body>
    <div id="log"></div>
    <script>
      test(function() {
        var client = new XMLHttpRequest()
        assert_equals(client.responseURL, "")

        client.open("GET", "foo.html", false)
        client.send()

        expected = location.href.replace(/[^/]*$/, 'foo.html')
        assert_equals(client.status, 404)
        assert_equals(client.responseURL, expected)
      }, "404 response has proper responseURL")
      test(function() {
        var client = new XMLHttpRequest()
        assert_equals(client.responseURL, "")

        target = "image.gif"
        client.open("GET", "resources/redirect.py?location=" + target, false)
        client.send()

        expected = location.href.replace(/[^/]*$/, "resources/" + target)
        assert_equals(client.status, 200)
        assert_equals(client.responseURL, expected)
      }, "Redirected response has proper responseURL")
    </script>
  </body>
</html>
back to top