| 470738c | Jessica Janiuk | 14 December 2022, 19:05:36 UTC | release: cut the v15.0.4 release | 14 December 2022, 19:11:28 UTC |
| a2cb2b4 | Jens | 14 December 2022, 16:12:36 UTC | docs: update date from 2022 to 2023 (#48485) PR Close #48485 | 14 December 2022, 16:43:32 UTC |
| d0fbad9 | Jens | 14 December 2022, 12:33:10 UTC | docs: add planned release schedule till v16 (#48485) Add release dates for v15.1,v15.2 and v16 PR Close #48485 | 14 December 2022, 16:43:32 UTC |
| 9291bd9 | Andrew Scott | 07 November 2022, 18:05:02 UTC | refactor(router): Add opt-in provider for upcoming router change (#47988) This commit adds a swappable provider for an upcoming change to the implementation of `Router#createUrlTree`. This will be a breaking change and is planned to be included in V16. PR Close #47988 | 14 December 2022, 00:57:46 UTC |
| ba8a644 | Andrew Scott | 30 November 2022, 21:45:10 UTC | docs: Add doc page for 'textAttributeNotBinding' extended diagnostic (#48307) Adds documentation page for `textAttributeNotBinding` extended diagnostic. fixes #48291 PR Close #48307 | 14 December 2022, 00:56:06 UTC |
| aabf8be | Bob Watson | 13 December 2022, 22:14:34 UTC | docs: edit suggestion to meet style guide (#47979) PR Close #47979 | 13 December 2022, 22:47:34 UTC |
| 19c94c1 | lsst25 | 05 November 2022, 11:56:59 UTC | docs: add a link to hierarchical-dependency-injection (#47979) It is not clear that when we provide a service to some eagerly loaded module of an application, then that service is available for components of all eagerly loaded modules of that application. It would be better to give a link for more information at least. PR Close #47979 | 13 December 2022, 22:47:34 UTC |
| d181b93 | Andrew Scott | 28 November 2022, 22:43:18 UTC | docs(core): Document invalid multi token (#48267) Add error page for invalid multi token runtime error PR Close #48267 | 13 December 2022, 22:05:59 UTC |
| 0f61672 | Angular Robot | 13 December 2022, 06:05:23 UTC | build: update eslint dependencies to v5.46.1 (#48464) See associated pull request for more information. PR Close #48464 | 13 December 2022, 21:25:00 UTC |
| fccf32c | Lukas Matta | 09 December 2022, 22:03:43 UTC | fix(devtools): Replace material imports and styles (#48420) In the #48216 Material deps were updated to v15, but the components and modules in DevTools were not updated to MDC nor replaced with the legacy definitions. PR Close #48420 | 13 December 2022, 21:22:25 UTC |
| f7aa210 | piyush132000 | 10 December 2022, 06:25:31 UTC | docs: updated docs removed unnecessary imports and empty methods (#48429) Removed empty methods and unnecessary imports in files PR Close #48429 | 13 December 2022, 21:14:35 UTC |
| 9e0c464 | BrowserPerson | 13 December 2022, 08:57:25 UTC | docs: add maria korneeva to GDE resources (#48468) PR Close #48468 | 13 December 2022, 21:14:07 UTC |
| 531808e | Angular Robot | 13 December 2022, 15:04:28 UTC | docs: update events (#48474) Generated `events.json` with the latest events retrieved from the Firebase DB. PR Close #48474 | 13 December 2022, 21:13:17 UTC |
| 70b2508 | why520crazy | 15 November 2022, 01:54:48 UTC | docs: add docgeni to tooling of resources list (#48061) PR Close #48061 | 13 December 2022, 00:26:27 UTC |
| bdbff83 | Jessica Janiuk | 13 December 2022, 00:13:43 UTC | Revert "fix(common): Update `Location` to get a normalized URL valid in case a represented URL starts with the substring equals `APP_BASE_HREF`" (#48461) This reverts commit ae0efb6a09af213e069d1fc92061949afca4f5f7. PR Close #48461 | 13 December 2022, 00:18:47 UTC |
| 6c1064c | dario-piotrowicz | 10 December 2022, 19:26:32 UTC | fix(animations): fix incorrect handling of camel-case css properties (#48436) fix the issue of camel-case properties not being handled correctly in state transition causing them not to be applied to the element resolves #48246 PR Close #48436 | 12 December 2022, 23:17:45 UTC |
| 8981db4 | Angular Robot | 22 November 2022, 15:04:16 UTC | docs: update events (#48170) Generated `events.json` with the latest events retrieved from the Firebase DB. PR Close #48170 | 12 December 2022, 23:03:05 UTC |
| f24e514 | Yannick Baron | 07 December 2022, 20:50:10 UTC | docs: add yannick baron to list of aio GDEs (#48390) PR Close #48390 | 12 December 2022, 23:01:59 UTC |
| c23f286 | Aristeidis Bampakos | 11 December 2022, 09:35:14 UTC | docs: modify directive composition API guide (#48439) Add a minor change to indicate the difference from applying a directive in the template. PR Close #48439 | 12 December 2022, 22:58:17 UTC |
| 8ca95b8 | Aristeidis Bampakos | 11 December 2022, 10:33:05 UTC | docs: fix typo in search keywords guide (#48442) PR Close #48442 | 12 December 2022, 22:19:58 UTC |
| d8de15e | Aristeidis Bampakos | 11 December 2022, 10:19:25 UTC | docs: fix typos in reviewing content guide (#48441) PR Close #48441 | 12 December 2022, 22:05:37 UTC |
| f64f73d | Aristeidis Bampakos | 11 December 2022, 09:57:39 UTC | docs: fix style in contributors overview guide (#48440) PR Close #48440 | 12 December 2022, 22:05:00 UTC |
| 966c7cf | Bob Watson | 12 December 2022, 17:35:56 UTC | docs: make "app" a suggested replacement for "application" (#48456) This commit accommodates the recent terminology preference change from "application" to "app" when describing what an Angular project produces. For now, using "application" is not a blocker, but writers should be aware of the change in terminology. PR Close #48456 | 12 December 2022, 21:49:07 UTC |
| 5af826a | Bob Watson | 12 December 2022, 17:32:00 UTC | docs: remove spell checker from vale testing until vale bug is resolved (#48456) With vale 2.21, the spell checker style stopped working. This commit removes the spell checker from the list of styles to allow Vale to be used, minus the spell checker, until the bug is resolved or a workaround can be applied. PR Close #48456 | 12 December 2022, 21:49:07 UTC |
| 1a31815 | Bob Watson | 22 November 2022, 00:33:12 UTC | docs: move tour of heroes tutorial to a subdirectory (#48162) This commit prepares the documentation directories for future tutorials organized by directory. Also, it moves the Angular Libraries topic from the Tutorials section to Developer Guides in TOC PR Close #48162 | 12 December 2022, 20:07:47 UTC |
| f30d18a | Andrew Scott | 09 December 2022, 20:00:32 UTC | fix(common): Fix TestBed.overrideProvider type to include multi (#48424) TestBed.overrideProvider should include `multi` support in its type. The underlying implementation already supports it, as documented by the tests which are currently casting the override to `any` to get around the bad type. PR Close #48424 | 12 December 2022, 17:40:23 UTC |
| ffb2c9c | piyush132000 | 10 December 2022, 02:58:29 UTC | docs: updated docs removed unnecessary imports and empty methods (#48428) Removed empty methods and unnecessary imports in files PR Close #48428 | 12 December 2022, 17:39:22 UTC |
| 59c6bfb | Konstantin Kharitonov | 08 December 2022, 00:01:55 UTC | fix(common): Update `Location` to get a normalized URL valid in case a represented URL starts with the substring equals `APP_BASE_HREF` (#48394) ```ts @NgModule({ imports: [RouterModule.forRoot([{path: '/enigma', component: EnigmaComponent}])], providers: [{provide: APP_BASE_HREF, useValue: '/en'}] }) export class AppModule {} ``` Navigating to `/enigma` will redirect to `/en/igma` not to `/en/enigma` as it expects Fixes: #45744 PR Close #48394 | 12 December 2022, 17:37:36 UTC |
| a3fbc27 | Andrew Scott | 09 December 2022, 16:00:57 UTC | docs(router): Update ROUTES docs to not point to provideRoutes (#48417) provideRoutes is deprecated in favor of the ROUTES token directly for complex situations where it's necessary. fixes #48411 PR Close #48417 | 12 December 2022, 17:36:39 UTC |
| 6279fec | Bob Watson | 15 July 2022, 22:27:02 UTC | docs: update of landing page and backup pages (#47047) Updates the angular.io landing page with new messaging and new images. The Quick-start app has been updated to demonstrate a minimalist Angular app and the value proposition content has been updated. PR Close #47047 | 10 December 2022, 00:04:34 UTC |
| c4d17b9 | Virginia Dooley | 28 October 2022, 20:03:15 UTC | docs: Document extracted from the original Introduction document, which is to be retired. (#47913) docs: add to pullapprove PR Close #47913 | 09 December 2022, 23:06:50 UTC |
| 91f82ca | Virginia Dooley | 28 October 2022, 16:03:21 UTC | docs: Document extracted from the original Introduction document, which is to be retired. Linting suggested corrections made. Restructuring or rewording sentences to be shorter and clearer. (#47909) docs: add to pullapprove PR Close #47909 | 09 December 2022, 22:59:59 UTC |
| 2925c6a | Virginia Dooley | 28 October 2022, 19:51:18 UTC | docs: Document extracted from the original Introduction document, which is to be retired. Linting suggested corrections made. Restructuring or rewording sentences to be shorter and clearer. (#47912) PR Close #47912 | 09 December 2022, 22:29:00 UTC |
| 501ad04 | Virginia Dooley | 28 October 2022, 15:52:26 UTC | docs: Document extracted from the original Introduction document, which is to be retired. Linting suggested corrections made. Restructuring or rewording sentences to be shorter and clearer. (#47908) docs: add to pullapprove PR Close #47908 | 09 December 2022, 22:27:57 UTC |
| eea71de | Jessica Janiuk | 09 December 2022, 21:20:20 UTC | ci: Add jessicajaniuk to code-ownership pullapprove group (#48426) Add Jessica to the code-ownership group to allow approve PullApprove config changes. PR Close #48426 | 09 December 2022, 22:05:10 UTC |
| 0b79922 | piyush132000 | 07 December 2022, 07:35:07 UTC | docs: cleanup the components (#48382) Removed empty methods and import from files PR Close #48382 | 09 December 2022, 21:31:45 UTC |
| 126e798 | Andrew Scott | 09 December 2022, 18:41:00 UTC | docs(common): Add note to location about investigating base href handling (#48422) There have been/are several bugs related to base href handling in Angular (#45744, #48175, #19296). These all stem from the attempted custom handling of base href in the `Location` class. This logic does not really make an attempt to be fully compliant with the spec. PR Close #48422 | 09 December 2022, 20:39:00 UTC |
| 85d3f6f | Angular Robot | 09 December 2022, 19:03:21 UTC | build: update cross-repo angular dependencies (#48405) See associated pull request for more information. PR Close #48405 | 09 December 2022, 19:26:15 UTC |
| c47dd76 | Alan Agius | 09 December 2022, 08:26:05 UTC | build: update cross-repo angular dependencies (#48409) See associated pull request for more information. Closes: #48339 (cherry picked from commit 31742210a38b3e01e25cfa9c4e13f6f0e13bf1dd) PR Close #48409 | 09 December 2022, 19:00:59 UTC |
| 1f3e9d9 | Alan Agius | 09 December 2022, 14:11:36 UTC | refactor(migrations): remove unused migrations (#48414) These migrations can no longer run due to a single update version policy (IE: from 13 to 14, 14 to 15 etc..). Therefore these are redundant and can be deleted. We also remove the `-beta` suffix from the version which is not needed as the Angular CLI will add the prerelease suffixes automatically. PR Close #48414 | 09 December 2022, 18:04:04 UTC |
| 4aa4ca8 | piyush132000 | 06 December 2022, 06:08:25 UTC | docs: updated local variables and removed empty methods (#48344) Removed empty methods and import from files and updated variable assignment PR Close #48344 | 09 December 2022, 17:56:08 UTC |
| 06c918c | Angular Robot | 06 December 2022, 21:34:51 UTC | build: update dependency fs-extra to v11 (#48261) See associated pull request for more information. PR Close #48261 | 09 December 2022, 17:54:16 UTC |
| fca7d6b | Alan Agius | 09 December 2022, 08:20:08 UTC | build: update gitignore to ignore files which should not be commited. (#48399) Previous node_modules and logs where were being tracked. PR Close #48399 | 09 December 2022, 17:43:30 UTC |
| 6c593e3 | Alan Agius | 08 December 2022, 09:04:54 UTC | build: replace `package-lock` with `yarn.lock` (#48399) We use Yarn as our package manager and not NPM. PR Close #48399 | 09 December 2022, 17:43:30 UTC |
| b6e4e1b | Alan Agius | 08 December 2022, 08:59:41 UTC | ci: disable renovate from updating `marketing-first-app` (#48399) This application was added recently and we will stop renovate updates due to the following - It is causing `Artifact update problem`. See: https://github.com/angular/angular/pull/48388#issuecomment-1341681430 - Generally `examples` in aio in use a shared `package.json` PR Close #48399 | 09 December 2022, 17:43:30 UTC |
| 23cac41 | Joey Perrott | 09 December 2022, 14:50:28 UTC | build: update to latest @angular/ng-dev buid (#48416) Update to the latest commit to get caretaker check fixes. PR Close #48416 | 09 December 2022, 17:25:42 UTC |
| e7707db | Bob Watson | 08 December 2022, 16:13:18 UTC | docs: move marketing demo out of tested examples (#48404) PR Close #48404 | 08 December 2022, 23:39:42 UTC |
| 5af7ec2 | Andrew Kushnir | 08 December 2022, 21:56:10 UTC | refactor(router): use `RegExp` to check if a URL is absolute (#48406) Previously, this check looked like this: `/^(https?:)?\/\//.test(baseHref)`, but that resulted in syntactically incorrect code after Closure Compiler minification. This was likely caused by a bug in Closure Compiler, but for now, the check is rewritten to use `new RegExp` instead. PR Close #48406 | 08 December 2022, 23:06:17 UTC |
| 77ba4aa | Angular Robot | 07 December 2022, 23:34:15 UTC | build: update cross-repo angular dependencies (#48398) See associated pull request for more information. (cherry picked from commit fb1d108ef127d51d7f0d065f2da93060dfe39c37) PR Close #48398 | 08 December 2022, 20:32:33 UTC |
| b55d2da | JoostK | 16 November 2022, 19:37:57 UTC | fix(compiler-cli): evaluate const tuple types statically (#48091) For standalone components it may be beneficial to group multiple declarations into a single array, that can then be imported all at once in `Component.imports`. If this array is declared within a library, however, would the AOT compiler need to extract the contents of the array from the declaration file. This requires that the array is constructed using an `as const` cast, which results in a readonly tuple declaration in the generated .d.ts file of the library: ```ts export declare const DECLARATIONS: readonly [typeof StandaloneDir]; ``` The partial evaluator logic did not support this syntax, so this pattern was not functional when a library is involved. This commit adds the necessary logic in the static interpreter to evaluate this type at compile time. Closes #48089 PR Close #48091 | 07 December 2022, 22:10:27 UTC |
| f273666 | Alan Agius | 07 December 2022, 15:45:56 UTC | refactor(compiler): replace deprecated `sourcemap-codec` (#48387) `sourcemap-codec` as been deprecated in favor of `@jridgewell/sourcemap-codec`. See: https://www.npmjs.com/package/sourcemap-codec?activeTab=versions PR Close #48387 | 07 December 2022, 22:09:17 UTC |
| d814284 | Piotr Kowalski | 01 December 2022, 22:28:50 UTC | docs: fix the name of stub component (#48318) PR Close #48318 | 07 December 2022, 22:08:25 UTC |
| 5d5b515 | Andrew Kushnir | 07 December 2022, 21:45:33 UTC | release: cut the v15.0.3 release | 07 December 2022, 21:54:02 UTC |
| bf44dc2 | Konstantin Kharitonov | 06 December 2022, 16:22:45 UTC | fix(common): Update `Location` to support base href containing `origin` (#48327) In case `APP_BASE_HREF` is set including `origin` the further usage of it might cause failure e.g. If an app is placed on `https://example.com` and bundles are on `https://cdn-example.com` you have to set `APP_BASE_HREF` up as `https://example.com/` and build the app with `--base-href` as `https://cdn-example.com/` but it does not work because of the bug Fixes #48175 PR Close #48327 | 07 December 2022, 17:18:01 UTC |
| 7df1989 | Angular Robot | 06 December 2022, 19:34:14 UTC | build: update cross-repo angular dependencies (#47882) (#48384) See associated pull request for more information. PR Close #47882 (cherry picked from commit 7c4e9ce5c0eb99f9cf6e4ad2faa9197d0ff986ec) PR Close #48384 | 07 December 2022, 17:09:30 UTC |
| 6b6bf63 | Angular Robot | 06 December 2022, 17:33:10 UTC | build: update all non-major dependencies (#48372) (#48384) See associated pull request for more information. PR Close #48372 (cherry picked from commit 126573d76b9456f55070fa0fdc54eeacc5762000) PR Close #48384 | 07 December 2022, 17:09:30 UTC |
| cb7365a | Alan Agius | 06 December 2022, 15:39:27 UTC | refactor(compiler): replace `flatten` and `map` with `flatMap`. (#48378) Replace custom `flatten` and `map` with native `flatMap` usage. Benchmark: | Test case name | Result | |---------------- |-------------------------------------------------------- | | flatten & map | flatten & map x 1,182 ops/sec ±2.18% (63 runs sampled) | | flatMap | flatMap x 6,011 ops/sec ±0.91% (35 runs sampled) | The fact that `flatMap` is faster is also highlighted in https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/flatMap PR Close #48378 | 07 December 2022, 17:08:26 UTC |
| a51e625 | Angular Robot | 06 December 2022, 06:03:04 UTC | build: update github/codeql-action action to v2.1.35 (#48371) See associated pull request for more information. PR Close #48371 | 07 December 2022, 17:07:34 UTC |
| e4dcaa5 | Kristiyan Kostadinov | 05 December 2022, 11:47:46 UTC | fix(core): unable to inject ChangeDetectorRef inside host directives (#48355) When injecting the `ChangeDetectorRef` into a node that matches a component, we create a new ref using the component's LView. This breaks down for host directives, because they run before the component's LView has been created. These changes resolve the issue by creating the LView before creating the node injector for the directives. Fixes #48249. PR Close #48355 | 07 December 2022, 17:06:46 UTC |
| c0d0417 | Alan Agius | 05 December 2022, 16:18:26 UTC | refactor(core): simplify array flatten logic (#48358) We can now use modern Javascript to get the same result. PR Close #48358 | 06 December 2022, 20:48:42 UTC |
| 5e2cd07 | Angular Robot | 06 December 2022, 18:35:55 UTC | build: update dependency jasmine-spec-reporter to v7 (#48367) See associated pull request for more information. PR Close #48367 | 06 December 2022, 19:43:05 UTC |
| 4c76f94 | Angular Robot | 06 December 2022, 18:35:42 UTC | build: update dependency @types/jasmine to v4 (#48365) See associated pull request for more information. PR Close #48365 | 06 December 2022, 18:57:04 UTC |
| 0e539eb | Angular Robot | 05 December 2022, 17:34:07 UTC | build: update eslint dependencies to v5.45.1 (#48223) See associated pull request for more information. PR Close #48223 | 06 December 2022, 18:52:16 UTC |
| 39b6cbc | Angular Robot | 06 December 2022, 17:34:01 UTC | build: update dependency karma-jasmine-html-reporter to v2 (#48369) See associated pull request for more information. PR Close #48369 | 06 December 2022, 18:09:14 UTC |
| 9a5d842 | dario-piotrowicz | 04 December 2022, 21:26:59 UTC | fix(compiler): make sure selectors inside container queries are correctly scoped (#48353) improve the emulated shadowDom implementation so that it can correctly scope selectors present inside the @container at-rule (recently added to the css specs) resolves #48264 PR Close #48353 | 06 December 2022, 17:59:00 UTC |
| 1e58a8c | Alan Agius | 06 December 2022, 11:49:32 UTC | docs: wrap json property in double quotes (#48375) Previously, the `budgets` was not wrapped in quotes which caused the JSON to be invalid. PR Close #48375 | 06 December 2022, 17:58:22 UTC |
| 40d6a06 | Alan Agius | 05 December 2022, 18:19:00 UTC | refactor(core): remove old AJD workaround for G3 (#48363) This workaround does not seem to be needed any longer. PR Close #48363 | 06 December 2022, 17:14:24 UTC |
| fc872b1 | Angular Robot | 06 December 2022, 00:05:46 UTC | build: update dependency ts-node to v10 (#48370) See associated pull request for more information. PR Close #48370 | 06 December 2022, 17:12:27 UTC |
| fdb2a38 | Angular Robot | 06 December 2022, 00:05:28 UTC | build: update dependency karma-jasmine to v5 (#48368) See associated pull request for more information. PR Close #48368 | 06 December 2022, 17:11:48 UTC |
| ac51e5c | Angular Robot | 05 December 2022, 23:05:26 UTC | build: update dependency jasmine-core to v4 (#48366) See associated pull request for more information. PR Close #48366 | 05 December 2022, 23:56:41 UTC |
| 45cc5f4 | Paul Gschwendtner | 05 December 2022, 13:23:16 UTC | build: switch new AIO preview action to use `aio: preview` label (#48345) The new AIO preview deployment should take over the existing `aio: preview` label- now after it being tested- and working as expected. PR Close #48345 | 05 December 2022, 22:52:38 UTC |
| 3f9cfae | Paul Gschwendtner | 30 November 2022, 15:43:23 UTC | build: remove docker-based AIO preview deploy setup (#48345) The docker-based AIO preview deploy setup is replaced with significantly simpler setup using GitHub actions provided by dev-infra (also something dev-infra can maintain better then). The actions under the hood leverage Firebase preview channels. PR Close #48345 | 05 December 2022, 22:52:38 UTC |
| dcab0f4 | Bob Watson | 05 December 2022, 15:45:23 UTC | docs: add example app for new landing page (#48360) PR Close #48360 | 05 December 2022, 22:37:47 UTC |
| 0b04da1 | Alan Agius | 05 December 2022, 13:35:02 UTC | refactor(core): remove several private utils and APIs (#48357) These APIs are no longer used. PR Close #48357 | 05 December 2022, 22:35:10 UTC |
| a4c82ba | Alan Agius | 05 December 2022, 13:19:35 UTC | refactor(compiler): remove unused `projection` const (#48357) `projection` const is unused in `serializePlaceholderValue`. PR Close #48357 | 05 December 2022, 22:35:09 UTC |
| 28b0b89 | Alan Agius | 05 December 2022, 13:18:59 UTC | refactor(common): remove unused `setDOM` (#48357) Remove unused `setDOM` method is unused. PR Close #48357 | 05 December 2022, 22:35:09 UTC |
| 50b1c2b | Alex Castle | 08 November 2022, 22:09:21 UTC | fix(common): Don't generate srcsets with very large sources (#47997) Fix an issue where users could inadvertently generate very large source images in ngOptimizedImage PR Close #47997 | 05 December 2022, 20:12:14 UTC |
| 9214e58 | Joey Perrott | 05 December 2022, 16:18:24 UTC | build: enable the ng-dev auth service (#48361) Enable the auth service for merging into the repository PR Close #48361 | 05 December 2022, 20:09:08 UTC |
| 0b388a0 | Paul Gschwendtner | 04 December 2022, 16:17:11 UTC | build: add more debug information for occasional windows flakiness (#48351) Ocassionally the NodeJS version is not correct after NVM on Windows. This adds some debug information that should help improve stability here. A recent attempt to update the `$PATH` did not seem to help. PR Close #48351 | 05 December 2022, 20:04:05 UTC |
| dc5f436 | piyush132000 | 04 December 2022, 05:46:03 UTC | docs: removed empty methods (#48343) Removed empty methods and import from files PR Close #48343 | 05 December 2022, 20:03:33 UTC |
| 7f31e55 | Derek Cormier | 02 December 2022, 20:49:22 UTC | build(bazel): mark an AIO sjs e2e test as flakey (#48331) Like a couple of the the other systemjs e2e tests, this one occasionally fails CI. PR Close #48331 | 05 December 2022, 20:02:29 UTC |
| 06c34cd | Andrew Scott | 23 November 2022, 23:17:14 UTC | refactor(router): Remove assignExtraOptionsToRouter helper function (#48313) This commit removes the unnecessary `assignExtraOptionsToRouter` helper function. This helper is not necessary because the options can be retrieved from DI and assigned during the construction on the Router. PR Close #48313 | 05 December 2022, 20:01:57 UTC |
| 58e5549 | Andrew Scott | 23 November 2022, 23:07:35 UTC | refactor(router): Eliminate constructor parameters in Router class (#48313) The Router constructor and `setupRouter` factory mainly exist as a legacy configuration. Since the Router's creation, the style in Angular has evolved quite a bit. This commit eliminates and cleans up some unnecessary comlicated code paths related to the router constructor/factory. Note that there are edits to the `setupTestingRouter` that could be seen as breaking. However, it is not for several reasons: 1. The function is documented as a factory function. If used as documented, the parameters should match what's available in DI 2. The function is totally unused by the Router itself and is not used in g3 either. I believe it was made publicApi by an error when updating documentation annotations long ago. PR Close #48313 | 05 December 2022, 20:01:57 UTC |
| 1b37306 | Derek Cormier | 04 December 2022, 03:51:04 UTC | build(bazel): set ci steps that build aio to 2xlarge+ (#48342) These steps builds AIO which is memory intensive. Running out of memory may be the cause of some ci flakiness. Change the executor size to test this theory. For context: The CLI process is randomly getting `Killed`, likely by the linux OOM killer. The Angular CLI builds happen on the host machine- no RBE. Without the Bazel migration they were previously already at ~63% peak RAM. With Bazel's overhead and e.g. remote caching, it seems to hit 100% (can be seen in CircleCI machine insights). OOM killer may then choose the highest consuming task. i.e. the Angular CLI and kill it. Angular CLI build ram consumption is proportional to the size of the app. AIO is not small https://app.circleci.com/pipelines/github/angular/angular/53992/workflows/ec47e3d8-2e7d-45b8-a802-7ec8ec4026c4/jobs/1265666/parallel-runs/0/steps/0-106 https://angular-team.slack.com/archives/C02PARQNMC1/p1670067910332809i PR Close #48342 | 05 December 2022, 11:40:56 UTC |
| 226441f | Paul Gschwendtner | 04 December 2022, 17:52:28 UTC | build: set target firebase project when setting deploy target (#48352) We now set the Firebase deploy target for AIO preview deployment via GitHub actions. It looks like configuring the deploy target also requires authentication / or a project. PR Close #48352 | 04 December 2022, 20:26:10 UTC |
| 38701ce | Paul Gschwendtner | 04 December 2022, 13:34:09 UTC | build: check out project before setting AIO preview targets (#48347) Checks out the Firebase project before setting the AIO preview targets. Surprisingly Firebase requires a project when setting resource identifiers for the targets. This is already done by the Firebase deploy action from @FirebaseExtended, but we need to do it earlier. PR Close #48347 | 04 December 2022, 16:14:11 UTC |
| 09388eb | Paul Gschwendtner | 04 December 2022, 11:23:53 UTC | build: use npx for setting firebase deploy targets in AIO preview (#48346) For the deploy job we still need to use the Firebase CLI to configure the proper hosting deploy targets. See: 011ef66a04d576b33e8828844a94960393fbc8aa. We don't have node modules installed in this job, and it would also be overkill to install them for just using firebase here. Since the action uses `npx firebase-tools` down the line anyway, we can use it without any speed downsides. PR Close #48346 | 04 December 2022, 13:18:40 UTC |
| 95886d8 | Paul Gschwendtner | 03 December 2022, 10:42:24 UTC | build: set firebase deploy target when deploying AIO preview (#48338) The AIO firebase project specifies `aio` as deploy target. This means that we need to configure this target before being able to deploy AIO previews. We use the default project target as target since the preview Firebase project does not use multi site targets. See: https://firebase.google.com/docs/hosting/multisites PR Close #48338 | 04 December 2022, 11:11:40 UTC |
| 6f79c2b | Angular Robot | 03 December 2022, 11:02:32 UTC | build: update actions/checkout action to v3 (#48337) See associated pull request for more information. PR Close #48337 | 03 December 2022, 16:09:10 UTC |
| 59f2d46 | Angular Robot | 03 December 2022, 10:33:21 UTC | build: update actions/checkout digest (#48336) See associated pull request for more information. PR Close #48336 | 03 December 2022, 10:45:39 UTC |
| 30226f0 | Paul Gschwendtner | 30 November 2022, 18:36:01 UTC | build: setup github actions for preview deployment of AIO (#48302) Sets up two new actions for supporting preview deployments of AIO by applying a label. i.e. `AIO preview`. PR Close #48302 | 03 December 2022, 10:13:26 UTC |
| 7bc6c2d | Paul Gschwendtner | 30 November 2022, 18:27:19 UTC | build: introduce common action for installing dependencies w/ cache in actions (#48302) Instead of repeating the node module installation step in future GitHub actions, a single place should contain the cache key etc. PR Close #48302 | 03 December 2022, 10:13:26 UTC |
| dd4fd1f | Paul Gschwendtner | 02 December 2022, 14:48:14 UTC | build: attempt to avoid nodejs version flakiness in `test_win` job (#48326) The `test_win` job is occasionally failing where a super old NodeJS version is used even though we installed a proper one with `nvm`. It's unclear how the CircleCI windows VMs differ here, it's coming up rarely and is hard to reproduce when SSH-ing into VMs. Our best guess is that the existing NodeJS version from the container/image is super old and somehow takes precedence over the NVM-managed NodeJS version. This could happen due to bad ordering in the `$PATH` environment variable, or NVM not properly being wired up there. We attempt to fix this by always setting `$PATH` to the NVM symlink directory manually- with highest priority. PR Close #48326 | 02 December 2022, 22:55:55 UTC |
| 49af83e | Andrew Kushnir | 01 December 2022, 22:49:00 UTC | docs: added `missingNgForOfLet` extended diagnostics details page (#48320) Closes #48288. PR Close #48320 | 02 December 2022, 22:54:10 UTC |
| 2131c55 | Andrew Kushnir | 01 December 2022, 22:27:37 UTC | docs: added `missingControlFlowDirective` extended diagnostics details page (#48319) Closes #48287. PR Close #48319 | 02 December 2022, 19:46:54 UTC |
| 2af6388 | Alan Agius | 30 November 2022, 09:37:19 UTC | refactor(platform-browser): simplify `flattenStyles` method (#48293) With this change we simplify the `flattenStyles` logic using modern JavaScript. PR Close #48293 | 02 December 2022, 19:36:13 UTC |
| 2eccfd4 | Paul Gschwendtner | 02 December 2022, 16:38:32 UTC | build: fix unnecessary large runfiles in AIO when composing boilerplate (#48329) The `example-boilerplate` NodeJS binary always depends on all files from the individual examples. This is not needed as for composition w/ the boilerplate, only the target example content + boilerplate is needed in the runfiles. This reduces the runfiles and therefore speeds up boilerplate creation (which can happen for all examples concurrently). PR Close #48329 | 02 December 2022, 17:47:44 UTC |
| f1cb455 | Paul Gschwendtner | 02 December 2022, 16:36:23 UTC | build: always ensure `node_modules` folders are not picked up in AIO (#48329) AIO has two risk places where `node_modules` folders may exist and may be accidentally picked up by Bazel- even though they are already added as part of `.bazelignore` and made visible through `.gitignore`. It doesn't hurt instructing Bazel to always ignore `node_modules` as part of the `glob` instruction. Co-authored-by: Joey Perrott <josephperrott@gmail.com> PR Close #48329 | 02 December 2022, 17:47:44 UTC |
| 520946d | Paul Gschwendtner | 02 December 2022, 16:23:58 UTC | build: do not use `--config=release` when building AIO for development (#48329) When building AIO using `yarn build` the `--config=release` is added. This was done as part of the Bazel migration to make sure the footer shows a Git revision via Bazel stamping. This does not provide enough benefits, compared to the downside of reduced caching. Bazel will discard the analysis cache when the stamp configuration changes. This may happen easily when you work in framework where `--config=release` is not used. Then when starting work in AIO: the config changes and the cache is discarded. This may even mean that existing framework package build artifacts may be discarded when an AIO local build is started. Co-authored-by: Joey Perrott <josephperrott@gmail.com> PR Close #48329 | 02 December 2022, 17:47:44 UTC |
| cd526c1 | Paul Gschwendtner | 01 December 2022, 21:38:57 UTC | build: cleanup bazelignore file (#48329) These folders are no longer used in the source tree, and only exist in the Bazel sandbox. We can rmeove them. Node modules are kept because people may create them when editing the integration `package.json` files. PR Close #48329 | 02 December 2022, 17:47:43 UTC |
