Revision 47420c799830d4676e544dbec56b2a7f787528f5 authored by Ryusuke Konishi on 07 April 2009, 02:01:45 UTC, committed by Linus Torvalds on 07 April 2009, 15:31:17 UTC
Pekka Enberg pointed out that double error handlings found after nilfs_transaction_end() can be avoided by separating abort operation: OK, I don't understand this. The only way nilfs_transaction_end() can fail is if we have NILFS_TI_SYNC set and we fail to construct the segment. But why do we want to construct a segment if we don't commit? I guess what I'm asking is why don't we have a separate nilfs_transaction_abort() function that can't fail for the erroneous case to avoid this double error value tracking thing? This does the separation and renames nilfs_transaction_end() to nilfs_transaction_commit() for clarification. Since, some calls of these functions were used just for exclusion control against the segment constructor, they are replaced with semaphore operations. Acked-by: Pekka Enberg <penberg@cs.helsinki.fi> Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent a2e7d2d
| File | Mode | Size |
|---|---|---|
| auth_gss | ||
| xprtrdma | ||
| Kconfig | -rw-r--r-- | 1.5 KB |
| Makefile | -rw-r--r-- | 477 bytes |
| auth.c | -rw-r--r-- | 13.3 KB |
| auth_generic.c | -rw-r--r-- | 4.7 KB |
| auth_null.c | -rw-r--r-- | 2.5 KB |
| auth_unix.c | -rw-r--r-- | 5.5 KB |
| cache.c | -rw-r--r-- | 30.6 KB |
| clnt.c | -rw-r--r-- | 38.1 KB |
| rpc_pipe.c | -rw-r--r-- | 22.0 KB |
| rpcb_clnt.c | -rw-r--r-- | 23.3 KB |
| sched.c | -rw-r--r-- | 25.6 KB |
| socklib.c | -rw-r--r-- | 4.5 KB |
| stats.c | -rw-r--r-- | 6.6 KB |
| sunrpc_syms.c | -rw-r--r-- | 1.4 KB |
| svc.c | -rw-r--r-- | 28.8 KB |
| svc_xprt.c | -rw-r--r-- | 32.5 KB |
| svcauth.c | -rw-r--r-- | 3.8 KB |
| svcauth_unix.c | -rw-r--r-- | 19.8 KB |
| svcsock.c | -rw-r--r-- | 33.9 KB |
| sysctl.c | -rw-r--r-- | 3.6 KB |
| timer.c | -rw-r--r-- | 2.4 KB |
| xdr.c | -rw-r--r-- | 27.0 KB |
| xprt.c | -rw-r--r-- | 29.6 KB |
| xprtsock.c | -rw-r--r-- | 56.4 KB |
Computing file changes ...
