Revision 47420c799830d4676e544dbec56b2a7f787528f5 authored by Ryusuke Konishi on 07 April 2009, 02:01:45 UTC, committed by Linus Torvalds on 07 April 2009, 15:31:17 UTC
Pekka Enberg pointed out that double error handlings found after nilfs_transaction_end() can be avoided by separating abort operation: OK, I don't understand this. The only way nilfs_transaction_end() can fail is if we have NILFS_TI_SYNC set and we fail to construct the segment. But why do we want to construct a segment if we don't commit? I guess what I'm asking is why don't we have a separate nilfs_transaction_abort() function that can't fail for the erroneous case to avoid this double error value tracking thing? This does the separation and renames nilfs_transaction_end() to nilfs_transaction_commit() for clarification. Since, some calls of these functions were used just for exclusion control against the segment constructor, they are replaced with semaphore operations. Acked-by: Pekka Enberg <penberg@cs.helsinki.fi> Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent a2e7d2d
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 3.4 KB |
| Makefile | -rw-r--r-- | 338 bytes |
| addr.c | -rw-r--r-- | 2.9 KB |
| addr.h | -rw-r--r-- | 3.6 KB |
| bcast.c | -rw-r--r-- | 20.8 KB |
| bcast.h | -rw-r--r-- | 5.5 KB |
| bearer.c | -rw-r--r-- | 17.6 KB |
| bearer.h | -rw-r--r-- | 6.1 KB |
| cluster.c | -rw-r--r-- | 14.6 KB |
| cluster.h | -rw-r--r-- | 3.6 KB |
| config.c | -rw-r--r-- | 19.4 KB |
| config.h | -rw-r--r-- | 3.0 KB |
| core.c | -rw-r--r-- | 7.1 KB |
| core.h | -rw-r--r-- | 9.9 KB |
| dbg.c | -rw-r--r-- | 11.0 KB |
| dbg.h | -rw-r--r-- | 2.8 KB |
| discover.c | -rw-r--r-- | 9.7 KB |
| discover.h | -rw-r--r-- | 2.3 KB |
| eth_media.c | -rw-r--r-- | 8.7 KB |
| handler.c | -rw-r--r-- | 4.0 KB |
| link.c | -rw-r--r-- | 86.6 KB |
| link.h | -rw-r--r-- | 9.8 KB |
| msg.c | -rw-r--r-- | 9.1 KB |
| msg.h | -rw-r--r-- | 18.1 KB |
| name_distr.c | -rw-r--r-- | 9.1 KB |
| name_distr.h | -rw-r--r-- | 2.1 KB |
| name_table.c | -rw-r--r-- | 28.2 KB |
| name_table.h | -rw-r--r-- | 4.1 KB |
| net.c | -rw-r--r-- | 9.7 KB |
| net.h | -rw-r--r-- | 2.4 KB |
| netlink.c | -rw-r--r-- | 3.4 KB |
| node.c | -rw-r--r-- | 19.9 KB |
| node.h | -rw-r--r-- | 5.5 KB |
| node_subscr.c | -rw-r--r-- | 2.8 KB |
| node_subscr.h | -rw-r--r-- | 2.6 KB |
| port.c | -rw-r--r-- | 40.3 KB |
| port.h | -rw-r--r-- | 6.3 KB |
| ref.c | -rw-r--r-- | 8.7 KB |
| ref.h | -rw-r--r-- | 2.1 KB |
| socket.c | -rw-r--r-- | 45.6 KB |
| subscr.c | -rw-r--r-- | 16.3 KB |
| subscr.h | -rw-r--r-- | 3.3 KB |
| user_reg.c | -rw-r--r-- | 6.5 KB |
| user_reg.h | -rw-r--r-- | 2.1 KB |
| zone.c | -rw-r--r-- | 4.6 KB |
| zone.h | -rw-r--r-- | 2.8 KB |
Computing file changes ...
