Skip to main content

Browse the archive

Revision 474ff2600889e16280dbc6ada8bfecb216169a70 authored by Maciej Żenczykowski on 22 September 2018, 08:34:01 UTC, committed by David S. Miller on 23 September 2018, 00:11:26 UTC 
net-ethtool: ETHTOOL_GUFO did not and should not require CAP_NET_ADMIN
 
So it should not fail with EPERM even though it is no longer implemented...

This is a fix for:
  (userns)$ egrep ^Cap /proc/self/status
  CapInh: 0000003fffffffff
  CapPrm: 0000003fffffffff
  CapEff: 0000003fffffffff
  CapBnd: 0000003fffffffff
  CapAmb: 0000003fffffffff

  (userns)$ tcpdump -i usb_rndis0
  tcpdump: WARNING: usb_rndis0: SIOCETHTOOL(ETHTOOL_GUFO) ioctl failed: Operation not permitted
  Warning: Kernel filter failed: Bad file descriptor
  tcpdump: can't remove kernel filter: Bad file descriptor

With this change it returns EOPNOTSUPP instead of EPERM.

See also https://github.com/the-tcpdump-group/libpcap/issues/689

Fixes: 08a00fea6de2 "net: Remove references to NETIF_F_UFO from ethtool."
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 8360ed6
History
File Mode Size
jedec_ddr.h -rw-r--r-- 3.6 KB
back to top