Revision 478990c81be2634ba313f577296687c6f9f4822c authored by Igor Canadi on 24 April 2014, 18:13:28 UTC, committed by Igor Canadi on 24 April 2014, 18:13:28 UTC
Summary:
I'm getting lots of e-mails with CompactionInputErrorParanoid failing. Most recent example early morning today was: http://ci-builds.fb.com/job/rocksdb_valgrind/562/consoleFull

I'm putting a stop to these e-mails. I investigated why the test is flakey and it turns out it's because of non-determinsim of compaction scheduling. If there is a compaction after the last flush, CorruptFile will corrupt the compacted file instead of file at level 0 (as it assumes). That makes `Check(9, 9)` fail big time.

I also saw some errors with table file getting outputed to >= 1 levels instead of 0. Also fixed that.

Test Plan: Ran corruption_test 100 times without a failure. Previously it usually failed at 10th occurrence.

Reviewers: dhruba, haobo, ljin

Reviewed By: ljin

CC: leveldb

Differential Revision: https://reviews.facebook.net/D18285
1 parent fc3127e
History
File Mode Size
build_tools
coverage
db
doc
hdfs
helpers
include
java
linters
port
table
tools
util
utilities
.arcconfig -rw-r--r-- 246 bytes
.clang-format -rw-r--r-- 138 bytes
.gitignore -rw-r--r-- 317 bytes
CONTRIBUTING.md -rw-r--r-- 759 bytes
HISTORY.md -rw-r--r-- 5.0 KB
INSTALL.md -rw-r--r-- 3.3 KB
LICENSE -rw-r--r-- 1.6 KB
Makefile -rw-r--r-- 20.2 KB
PATENTS -rw-r--r-- 1.4 KB
README -rw-r--r-- 2.9 KB
README.fb -rw-r--r-- 96 bytes
ROCKSDB_LITE.md -rw-r--r-- 1020 bytes

README

back to top