https://github.com/JuliaLang/julia
Revision 479743e4d7d5e6f54204dd0390fa475599fed30e authored by Elliot Saba on 31 August 2023, 15:32:56 UTC, committed by GitHub on 31 August 2023, 15:32:56 UTC
We used to be reporting the maximum system image size in hexadecimal,
while reporting the image that was just built in decimal. This is a
recipe for confusion when the size limit contains no blatantly
hexadecimal characters.

This PR addresses the issue by consistently printing out both values in
hexadecimal (making this more obvious by prefixing the numbers with
`0x`). In order to use `PRIxPTR` in both format strings, I have cast the
current image size to `uintptr_t` from `intmax_t`, which should be safe
in all situations.

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
1 parent 95af5a0
History
Tip revision: 479743e4d7d5e6f54204dd0390fa475599fed30e authored by Elliot Saba on 31 August 2023, 15:32:56 UTC
Consistently report sysimg size limits (#51119)
Tip revision: 479743e
File Mode Size
.devcontainer
.github
base
cli
contrib
deps
doc
etc
src
stdlib
test
.buildkite-external-version -rw-r--r-- 5 bytes
.clang-format -rw-r--r-- 3.3 KB
.clangd -rw-r--r-- 114 bytes
.codecov.yml -rw-r--r-- 52 bytes
.git-blame-ignore-revs -rw-r--r-- 371 bytes
.gitattributes -rw-r--r-- 65 bytes
.gitignore -rw-r--r-- 523 bytes
.mailmap -rw-r--r-- 12.7 KB
CITATION.bib -rw-r--r-- 513 bytes
CITATION.cff -rw-r--r-- 940 bytes
CONTRIBUTING.md -rw-r--r-- 23.4 KB
HISTORY.md -rw-r--r-- 372.5 KB
LICENSE.md -rw-r--r-- 1.3 KB
Make.inc -rw-r--r-- 55.7 KB
Makefile -rw-r--r-- 30.5 KB
NEWS.md -rw-r--r-- 1.5 KB
README.md -rw-r--r-- 7.3 KB
THIRDPARTY.md -rw-r--r-- 3.8 KB
VERSION -rw-r--r-- 11 bytes
julia.spdx.json -rw-r--r-- 35.8 KB
pkgimage.mk -rw-r--r-- 6.3 KB
sysimage.mk -rw-r--r-- 4.3 KB

README.md

back to top