| 47b6eb3 | Moritz Mack | 21 March 2024, 17:12:22 UTC | Re-mute SimpleThreadPoolIT.testThreadPoolMetrics (#106623) Mute test until remaining races are addressed. (related to #104652) | 21 March 2024, 17:12:22 UTC |
| 7c46c73 | Nik Everett | 21 March 2024, 17:01:15 UTC | ESQL: Generate docs for ceil (#106616) This replaces the hand maintained docs for `CEIL` and with the docs generated by the tests. There shouldn't be any diff in the generated docs. | 21 March 2024, 17:01:15 UTC |
| 25d586c | Mary Gouseti | 21 March 2024, 16:59:27 UTC | Make testXContentSerializationWithRolloverAndEffectiveRetention take into consideration a disabled lifecycle (#106612) | 21 March 2024, 16:59:27 UTC |
| 9c8c319 | Luigi Dell'Aquila | 21 March 2024, 16:53:29 UTC | Refactor ESQL HeapAttackIT to run on Serverless (#106586) | 21 March 2024, 16:53:29 UTC |
| a41e11f | Mark Vieira | 21 March 2024, 16:52:12 UTC | Improve stability of build complete archive creation (#106578) This is an attempt to fix some errors creating the diagnostic archive at the end of builds in CI. We've seen errors where we attempt to write more bytes than expected into the archive. The assumption here is that we are bundling files that are possibly still being written to. This _shouldn't_ happen, but it's useful to have these diagnostic bundles in either case. Closes https://github.com/elastic/elasticsearch/issues/106576 | 21 March 2024, 16:52:12 UTC |
| fa00e61 | Nik Everett | 21 March 2024, 16:52:04 UTC | ESQL: Values aggregation function (#106065) This creates the `VALUES` aggregation function which buffers all field values it receives and emits them as a multivalued field. It can use a significant amount of memory and will circuit break if it uses too much memory, but it's really useful for putting together self-join-like behavior. It sort of functions as a stop-gap measure until we have more self-join style things. In the future we'll have spill-to-disk for aggregations and, likely, some kind of self-join command for aggregations at least so this will be able to grow beyond memory. But for now, memory it is. Example: ``` FROM employees | EVAL first_letter = SUBSTRING(first_name, 0, 1) | STATS first_name=VALUES(first_name) BY first_letter | SORT first_letter ; first_name:keyword | first_letter:keyword [Anneke, Alejandro, Anoosh, Amabile, Arumugam] | A [Bezalel, Berni, Bojan, Basil, Brendon, Berhard, Breannda] | B [Chirstian, Cristinel, Claudi, Charlene] | C [Duangkaew, Divier, Domenick, Danel] | D ``` I made this work for everything but `geo_point` and `cartesian_point` because I'm not 100% sure how to integrate with those. We can grab those in a follow up. Closes #103600 | 21 March 2024, 16:52:04 UTC |
| 93a21e1 | David Turner | 21 March 2024, 16:30:18 UTC | AwaitsFix for #106618 | 21 March 2024, 16:38:09 UTC |
| a8586f3 | David Turner | 21 March 2024, 16:31:10 UTC | Document lack of logging BwC (#104459) Our guarantees around backwards compatibility and breaking changes do not apply to the Elasticsearch application logs. This commit adds a note to the docs about this. | 21 March 2024, 16:31:10 UTC |
| 76d1974 | Rene Groeschke | 21 March 2024, 16:29:38 UTC | Add gradle plugin for publishing docker based test fixtures (#106229) To make those docker images available for our testcontainer based fixtures we need to publish them on a regular basis to ensure the source and the images are in sync. This adds some convenience plugin to take care of publishing our docker test fixtures | 21 March 2024, 16:29:38 UTC |
| 521e06d | Ryan Ernst | 21 March 2024, 16:00:53 UTC | Remove node shutdown test check on snapshot build (#106518) Node shutdown is no longer guarded by a feature flag. This commit removes the test assumptions that only allowed some tests to run on snapshots which enable feature flags. | 21 March 2024, 16:00:53 UTC |
| de7e898 | István Zoltán Szabó | 21 March 2024, 15:41:31 UTC | [DOCS] Amends important note on delayed data detection. (#106610) | 21 March 2024, 15:41:31 UTC |
| bce11c6 | Nhat Nguyen | 21 March 2024, 15:24:32 UTC | Avoid using small inactive exchange timeout in breaker tests (#106394) The tests failed because we set an inactive exchange timeout too short, causing a timeout error instead of triggering the expected CircuitBreakingException. Closes #105681 Closes #105543 | 21 March 2024, 15:24:32 UTC |
| 3489906 | Nik Everett | 21 March 2024, 14:51:35 UTC | ESQL: Generate a few more docs (#106577) And improve the error message on csv test failures. | 21 March 2024, 14:51:35 UTC |
| 49d40c3 | Dianna Hohensee | 21 March 2024, 14:48:47 UTC | Complete placeholder AtomicRegister Coordinator tests (#106512) Porting over Coordinator tests to Stateless/AtomisRegisterCoordinatorTests | 21 March 2024, 14:48:47 UTC |
| f617694 | Mark Tozzi | 21 March 2024, 14:33:12 UTC | [ESQL] copy ql disjunction rule into esql (#106499) Similar to #105711, this migrates a QL optimization that depends on specific class types into ESQL to refer to the ESQL version of those classes. This is necessary for #105217, which changes the class hierarchy of the binary comparisons. I migrated the existing rules tests, and added new tests to the logical plan optimizer tests to cover this rule. | 21 March 2024, 14:33:12 UTC |
| dcc3d83 | Lisa Cawley | 21 March 2024, 14:20:56 UTC | [DOCS] Unhealthy transform rule check (#106521) | 21 March 2024, 14:20:56 UTC |
| ad47382 | Moritz Mack | 21 March 2024, 14:06:54 UTC | Wait in SimpleThreadPoolIT.testThreadPoolMetrics for threads to complete (#106580) Search threads might still be active even after returning a response. Waiting for all threads to be completed prevents a race between the collection of threadpool stats and measurements. | 21 March 2024, 14:06:54 UTC |
| 11a4e40 | István Zoltán Szabó | 21 March 2024, 13:57:10 UTC | [DOCS] Adjusts PUT inference API docs examples (#106604) Co-authored-by: David Kyle <david.kyle@elastic.co> | 21 March 2024, 13:57:10 UTC |
| dff4fd4 | Rassyan | 21 March 2024, 13:50:14 UTC | Log AffixSetting update when using addAffixMapUpdateConsumer (#97072) | 21 March 2024, 13:50:14 UTC |
| 26f7269 | Nik Everett | 21 March 2024, 13:46:23 UTC | ESQL: Escape regexes in tests (#106603) When we're generating raw strings to match we want to make sure it just matches exactly the string - so we should escape it. If we don't we'll get weird failures from syntax exceptions. Closes #106533 Closes #106538 | 21 March 2024, 13:46:23 UTC |
| e92a7a7 | István Zoltán Szabó | 21 March 2024, 13:33:10 UTC | [DOCS] Adds note to inference tutorial about similarity (#106567) | 21 March 2024, 13:33:10 UTC |
| 999dcb8 | Salvatore Campagna | 21 March 2024, 12:35:17 UTC | Unable to retrieve multiple stored field values (#106575) The issue happens when we try to use multiple stored fields through the FetchFieldsPhase, which we do when using `_fields` since we have a single shared instance of SingleFieldsVisitor per field and document and use a shared `currentValues` array. | 21 March 2024, 12:35:17 UTC |
| ffec5f6 | Martijn van Groningen | 21 March 2024, 12:17:19 UTC | Fix synthesizing id bug when reading routing value (#106600) Take `routingHashBytes` offset and length into account when decoding the routing hash as part of synthesizing the _id. | 21 March 2024, 12:17:19 UTC |
| e1e14e4 | Yang Wang | 21 March 2024, 11:29:20 UTC | Finer grained blobStore stats report in stateless (#106581) When stateless is enabled, the blobStore stats report keep the information about operation purposes by using combined keys of operation purpose and operation. Resolves: ES-7967 | 21 March 2024, 11:29:20 UTC |
| 8a7697b | Martijn van Groningen | 21 March 2024, 10:37:34 UTC | Improve short-circuiting downsample execution (#106563) This is relevant in the case multiple downsample api invocations have been executed for the same source index, target index and fixed interval. Whether the target index is ready, is now also checked just before starting the downsample persistent tasks. Relates to #106403 | 21 March 2024, 10:37:34 UTC |
| 32dbc28 | István Zoltán Szabó | 21 March 2024, 10:32:57 UTC | [DOCS] Adds disclaimer to semantic search tutorials (#106590) | 21 March 2024, 10:32:57 UTC |
| 992e9b5 | Tim Rühsen | 21 March 2024, 10:14:18 UTC | [Profiling] Switch to OTEL field host.arch (#106585) | 21 March 2024, 10:14:18 UTC |
| 2120683 | Przemysław Witek | 21 March 2024, 09:58:29 UTC | [Transform] Fix `_reset` API when called with `force=true` on a failed transform (#106574) | 21 March 2024, 09:58:29 UTC |
| c91409c | David Turner | 21 March 2024, 09:14:13 UTC | Improve threading in `TransportGetSnapshotsAction` (#106527) There's a comment about intentionally avoiding using the `SNAPSHOT_META` pool in `TransportGetSnapshotsAction`, but in fact we implicitly fork onto the `SNAPSHOT_META` pool in a few spots and end up doing much of the work there anyway. This commit fixes things to use the `MANAGEMENT` pool for all this work as originally intended. | 21 March 2024, 09:14:13 UTC |
| 4374a38 | Moritz Mack | 21 March 2024, 08:39:22 UTC | Use historical features for Yaml REST tests for bulk api (#106402) | 21 March 2024, 08:39:22 UTC |
| 19cffde | Kostas Krikellas | 21 March 2024, 06:00:37 UTC | Support non-keyword dimensions as routing fields in TSDB (#105501) * Fix test failure https://gradle-enterprise.elastic.co/s/icg66i6mwnjoi * Fix test failure https://gradle-enterprise.elastic.co/s/icg66i6mwnjoi * Nest pass-through objects within objects * Support numeric fields as pass-through dimensions * Update docs/changelog/105073.yaml * fix tests * fix tests * refactor dimension property * fix yaml * add numeric to routing builder * fix violation * fix yaml versions * handle all numeric values in dimension fields * use shardId in TSDB doc id * spotless fix * test fixes * index version guard * test fix * revert shardId changes * add routing id field mapper * Update docs/changelog/105501.yaml * fix shrunk test * use SortedDocValuesField * fix tests * delete unused yaml * submit test fixes * sync * restrict id override to latest version * update painless path * test fix * check for invalid id * fix painless tests * restore bwc routing changes * add unittest * refactor passthrough test * address comments * remove redundant variable * remove assert * fix id test * fix painless * skip storing routing field * skip generating the id when available * skip assert on routing in TranslogWriter * skip id mismatch assert * changelog update * revert redundant changes * remove supportsDimension * spotless * rename var for forcing dimension * small refactor * small refactor | 21 March 2024, 06:00:37 UTC |
| c4e9646 | Moritz Mack | 21 March 2024, 05:17:24 UTC | Re-enable the RemoteClusterSecurityBwcRestIT (#106570) This reverts commit 4ef0a8f1068f9701c087c54cdbd23f49742b7e7f / #106534 | 21 March 2024, 05:17:24 UTC |
| a130537 | Nik Everett | 20 March 2024, 20:32:12 UTC | ESQL: Use generated docs for abs and acos (#106510) ESQL: Use generated docs for abs and acos | 20 March 2024, 20:32:12 UTC |
| 2988799 | Mary Gouseti | 20 March 2024, 18:27:08 UTC | [DSL Global Retention] Use data stream global retention metadata (#106221) | 20 March 2024, 18:27:08 UTC |
| 52b311d | Martijn van Groningen | 20 March 2024, 18:19:24 UTC | Rename index names in 25_id_generation.yml file (#106558) Rename index names in yaml test to more easily find related log lines in es server log. Many yaml tests are being executed in the same qa cluster, this should help finding relevant logs for failures in this yaml file. Relates to #106550 | 20 March 2024, 18:19:24 UTC |
| 2523ed9 | Mark Vieira | 20 March 2024, 16:04:52 UTC | Validate that test cluster BWC nodes use the default distribution (#106559) We have instances where BWC tests configure old ES version nodes with the integTest distribution. This isn't a valid configuration, and while we in reality resolve the default distribution artifact, we have other configuration logic that behaves differently based on whether the integTest distro was _requested_. Specifically, what to set ES_JAVA_HOME to. This bug resulted in us attempting to run old nodes using the current bundled JDK version, which may be incompatible with that older version of Elasticsearch. Closes #104858 | 20 March 2024, 16:04:52 UTC |
| 43de7a4 | Ignacio Vera | 20 March 2024, 15:57:17 UTC | Introduce a generic HashMap backed by big arrays (#106418) this commit introduces a PagedHashMap which is equivalent of a Java HashMap but backed by big arrays. | 20 March 2024, 15:57:17 UTC |
| 58c9233 | Fang Xing | 20 March 2024, 15:45:54 UTC | [ES|QL] Centralize Datetime String Conversion (#106388) * centralize datetime string conversion | 20 March 2024, 15:45:54 UTC |
| 19cf318 | Ignacio Vera | 20 March 2024, 15:38:38 UTC | Use LogDocMergePolicy in GeoPointScriptFieldDistanceFeatureQueryTests#testMatches (#106557) | 20 March 2024, 15:38:38 UTC |
| b24e0d0 | Craig Taverner | 20 March 2024, 15:36:00 UTC | Fix 60_enrich/Enrich on keyword (fixes 106507) (#106513) * Mute failing test * Remove gradle mute, and change comment to indicate this is a fix It appears the difference that caused the problem is that the query now returns a field that used to be a keyword, but is now a text field, provided by the enrich lookup. So even though the enrich is still based on a keyword, this query now accesses code paths it did not before, and those have issues before 8.13.0 related to reading text from source. | 20 March 2024, 15:36:00 UTC |
| a368b48 | David Turner | 20 March 2024, 14:43:22 UTC | Release `TranslogSnapshot` buffer after iteration (#106398) Closes #106390 | 20 March 2024, 14:43:22 UTC |
| 7517424 | David Turner | 20 March 2024, 14:22:30 UTC | AwaitsFix for #106554 | 20 March 2024, 14:22:38 UTC |
| 5d05d81 | Fang Xing | 20 March 2024, 14:15:49 UTC | [ES|QL] Remove variadic functions' optional args from the output of show functions (#106454) * remove optional args from the output of show functions optionalArgs, argNames and argTypes for variadic functions * consistent names for arguments | 20 March 2024, 14:15:49 UTC |
| 09b6072 | István Zoltán Szabó | 20 March 2024, 14:07:41 UTC | [DOCS] Changes Cohere inference examples in tutorial and API docs (#106524) | 20 March 2024, 14:07:41 UTC |
| 61e8134 | Moritz Mack | 20 March 2024, 13:58:15 UTC | Unmute SimpleThreadPoolIT.testThreadPoolMetrics with additional logging (#106522) Add additional logging and more vocal assertions to better understand test failures (related to #104652) | 20 March 2024, 13:58:15 UTC |
| 2e8482a | David Turner | 20 March 2024, 13:47:14 UTC | Integrate threadpool scheduling with `AbstractRunnable` (#106542) Today `ThreadPool#scheduleWithFixedDelay` does not interact as expected with `AbstractRunnable`: if the task fails or is rejected then this isn't passed back to the relevant callback, and the task cannot specify that it should be force-executed. This commit fixes that. | 20 March 2024, 13:47:14 UTC |
| cf5fbfc | David Turner | 20 March 2024, 13:28:59 UTC | Force execution of `SearchService.Reaper` (#106544) If the search threadpool fills up then we may reject execution of `SearchService.Reaper` which means it stops retrying. We must instead force its execution so that it keeps on going. With #106542, closes #106543 | 20 March 2024, 13:28:59 UTC |
| 82221ff | Aurélien FOUCRET | 20 March 2024, 12:35:05 UTC | Ensure ILM policy is installed before starting the tests. (#106523) | 20 March 2024, 12:35:05 UTC |
| 9315f80 | Henning Andersen | 20 March 2024, 12:20:54 UTC | Enhance search tier GC options (#106526) For small nodes, we need a bit more wiggle room for new size and concurrent GC threads in order to stay below real memory circuit breaker limits on dedicated search nodes. ES-8087 | 20 March 2024, 12:20:54 UTC |
| 2087b65 | David Kyle | 20 March 2024, 11:15:21 UTC | [ML] Create inference_user and inference_admin roles (#106371) Defines new inference_user and inference_admin roles with the related cluster privileges manage_inference and monitor_inference. inference_user can list the models and preform inference, inference_admin can do the same plus create and delete models | 20 March 2024, 11:15:21 UTC |
| 0d6b368 | David Roberts | 20 March 2024, 11:03:21 UTC | [ML] Fork trained model stats work to thread pool threads (#99439) The steps that assemble the trained model stats response largely ran on the transport worker thread. Even though none of the steps look massively expensive, it's likely one of them is, because we've observed client lockups (Kibana) while trained model stats is running. This change moves the steps into the ML utility thread pool to avoid any risk of blocking the transport thread. --------- Co-authored-by: David Turner <david.turner@elastic.co> | 20 March 2024, 11:03:21 UTC |
| 504ef7c | David Turner | 20 March 2024, 10:55:56 UTC | Clarify threading in `SubscribableListener` (#106532) The docs about threading here are a little opaque to consumers, who typically just want to ensure that the listener is completed on a particular threadpool. This commit adds clearer docs about achieving that goal. | 20 March 2024, 10:55:56 UTC |
| 4ef0a8f | Simon Cooper | 20 March 2024, 10:40:35 UTC | Revert "Re-enable the RemoteClusterSecurityBwcRestIT (#106052)" (#106534) This reverts commit 9b0f1cea8ceb603e1990bef99b5f7e895d7f617d. | 20 March 2024, 10:40:35 UTC |
| fdd6d89 | Navarone Feekery | 20 March 2024, 10:30:18 UTC | [Connectors API] Add missing `_api_key_id` docs (#106469) | 20 March 2024, 10:30:18 UTC |
| 5afc59b | István Zoltán Szabó | 20 March 2024, 10:05:52 UTC | [DOCS] Creates a semantic_text field type docs page. (#106528) | 20 March 2024, 10:05:52 UTC |
| 9980eac | David Turner | 20 March 2024, 09:59:47 UTC | AwaitsFix for #106533 | 20 March 2024, 09:59:55 UTC |
| 430758d | Nikolaj Volgushev | 20 March 2024, 09:28:47 UTC | Test tweaks for compatible security tests (#106464) Test tweaks for serverless: * Valid application name in API key tests * Move from `cluster.health` to `info` call in roles test (the call is just used to check that a user with a cluster privilege is indeed able to execute the test) Closes: ES-7987 | 20 March 2024, 09:28:47 UTC |
| d01adff | Ioana Tagirta | 20 March 2024, 09:03:04 UTC | Add links to text_expansion in ELSER tutorial (#106490) * Add links to text_expansion in ELSER tutorial * Apply suggestions from code review Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com> --------- Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com> | 20 March 2024, 09:03:04 UTC |
| 32bc182 | Chris Hegarty | 20 March 2024, 08:50:16 UTC | ESQL: expose transport action to improve usage (#106463) This commits exposes the query transport action to improve usage. While one can perform all operations prior to this change, it has been suggested that adding the action would improve the symmetry of the API by allowing e.g. client().execute(builder.action(), builder.request()).actionGet(30, SECONDS); | 20 March 2024, 08:50:16 UTC |
| 6f607e4 | Lorenzo Dematté | 20 March 2024, 08:27:31 UTC | Use cluster features for ASYNC ESQL tests (#104466) + Add esql as rest test dependency for ml/native-multi-node-tests to work around the mixed testClusters/TestCluster nodes (so all have the esql plugin installed) | 20 March 2024, 08:27:31 UTC |
| c30999b | Yang Wang | 20 March 2024, 08:05:43 UTC | [Test] Ranged read should read non-empty content (#106000) Empty read is [short-circuited](https://github.com/elastic/elasticsearch/blob/e8039b9ecb2451752ac5377c44a6a0c662087a9f/modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobContainer.java#L115-L116) without going to the blob store. In order to test s3 blob store, ranged read should read at least one byte. This PR ensures that. Resolves: #105958 | 20 March 2024, 08:05:43 UTC |
| dbb7847 | Albert Zaharovits | 20 March 2024, 08:05:02 UTC | Expose lookup of realm domain config by realm id (#106424) The scope here is to expose a method (Realms#getRealmRef) that can be used to retrieve the realm domain assignments for any realm id. | 20 March 2024, 08:05:02 UTC |
| d5565b6 | Athena Brown | 19 March 2024, 23:08:41 UTC | Fix typo in OIDC docs (#106207) (#106517) Add missing _to_ in sentence (cherry picked from commit 40a9155b3b53925b335530da4e076e39e66ee8f7) Co-authored-by: Aaron Hanusa <aaron.hanusa@gmail.com> | 19 March 2024, 23:08:41 UTC |
| 8cbece4 | Nhat Nguyen | 19 March 2024, 22:05:04 UTC | Fix testCancelRequestWhenFailingFetchingPages (#106447) If we proceed without waiting for pages, we might cancel the main request before starting the data-node request. As a result, the exchange sinks on data-nodes won't be removed until the inactive_timeout elapses, which is longer than the assertBusy timeout. Closes #106443 | 19 March 2024, 22:05:04 UTC |
| edbff94 | Jonathan Buttner | 19 March 2024, 21:44:53 UTC | [ML] Inference API Rate limiter (#106330) * Working tests * Adding more tests * Adding comment * Switching to micros and addressing feedback * Removing nanos and adding test for bug fix --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> | 19 March 2024, 21:44:53 UTC |
| ea1672b | Nik Everett | 19 March 2024, 20:52:53 UTC | ESQL: Fix CSV tests (#106506) When we use `ROW` in ESQL we pick a random data set by just iterating the `Map`. It's random. Yay! And some of them don't work in this place. This just picks one that we know works. Closes #106501 | 19 March 2024, 20:52:53 UTC |
| 83bc94a | Ryan Ernst | 19 March 2024, 20:41:14 UTC | Mark node seen task as successful (#106502) The task for updating cluster state with nodes seen by shutdown was previously switched to use batched tasks. However, the task is never marked as complete, which leads to the tasks piling up. This commit marks the task as complete and re-enables a test that appears to succeed now. closes #76689 | 19 March 2024, 20:41:14 UTC |
| 55c3357 | Ryan Ernst | 19 March 2024, 20:40:52 UTC | Move common mrjar forbidden apis configuration to plugin (#106385) Since mrjars may use preview apis, forbidden apis must know about any preview apis from the jdk. However, we do not run forbidden apis with the preview enabled flag, nor in a separate jvm, so it does not know about these classes. Thus we ignore missing classes on source sets added by the mrjar plugin. This commit configures all sourcesets added by mrjar plugin to ignore forbidden apis missing classes. | 19 March 2024, 20:40:52 UTC |
| 444866a | Ryan Ernst | 19 March 2024, 19:51:57 UTC | Set explicit directory and file permissions on native libraries (#106505) The distributions already have correct permissions set on native libraries copied to them. However, the build itself to extract the native libs relies on the upstream file permissions. This commit sets explicit permissions on the copy task which extracts native libraries. | 19 March 2024, 19:51:57 UTC |
| 1541da5 | Nik Everett | 19 March 2024, 19:40:13 UTC | ESQL: Generate more docs (#106367) This modifies the ESQL test infrastructure to generate more of the documentation for functions. It generates the *Description* section, the *Examples* section, and the *Parameters* section as separate files so we can use them as needed. It also generates a `layout` file that's just a guess as to how to render the whole thing. In some cases it'll work and we can use that instead of hand maintaining a "top level" description file for the function. Most newly generated files are unused. We have to chose to pick them up by replacing the sections we were manually maintaining with an include of the generated section. Or by replacing the entire hand maintained file with the generated top level file. Relates to #104247 | 19 March 2024, 19:40:13 UTC |
| d362517 | Ryan Ernst | 19 March 2024, 19:31:35 UTC | Mute EsqlClientYamlIT esql/60_enrich/Enrich on keyword see https://github.com/elastic/elasticsearch/issues/106507 | 19 March 2024, 19:32:52 UTC |
| 2ab2a06 | Mark Vieira | 19 March 2024, 19:19:47 UTC | Update bundled JDK to Java 22 (#106482) | 19 March 2024, 19:19:47 UTC |
| bceb38d | Niels Bauman | 19 March 2024, 18:45:04 UTC | Fix default search timeout in watcher docs (#106404) | 19 March 2024, 18:45:04 UTC |
| bffd2a9 | Nik Everett | 19 March 2024, 18:35:14 UTC | ESQL: Regex improvements (#106429) This makes a couple of changes to regex processing in the compute engine: 1. Process utf-8 strings directly. This should save a ton of time. 2. Snip the `toString` output if it is too big - I chose 64kb of strings. 3. I changed the formatting of the automaton to a slightly customized `dot` output. Because automata are graphs. Everyone knows it. And they are a lot easier to read as graphs. `dot` is easy to convert into a graph. 4. I implement `EvaluatorMapper` for regex operations which is pretty standard for the rest of our operations. | 19 March 2024, 18:35:14 UTC |
| e36b3eb | Ryan Ernst | 19 March 2024, 18:15:02 UTC | Re-enable shutdown stalled test (#106498) NodeShutdownIT.testStalledShardMigrationProperlyDetected has been muted for a couple years. It apparently reproduced when the failure first started, but no longer reproduces on main. This commit re-enables the test and closes the test issue. We can open a new issue with any subsequent failure. closes #77456 | 19 March 2024, 18:15:02 UTC |
| 8eda6b2 | Ryan Ernst | 19 March 2024, 18:14:46 UTC | Wait for shard migration status update on shutdown (#106497) The shutdown integration tests test scenarios across multiple nodes. When checking if a shard is moved off a node that is shutting down, the shard migration status may not yet have been updated. This commit adds a busy wait to ensure the status has time to update before failing the test. closes #77488 | 19 March 2024, 18:14:46 UTC |
| acb16ff | Ryan Ernst | 19 March 2024, 18:14:18 UTC | Improve packaging test debugging (#106491) Packaging tests have several files that may be useful in debugging failures. Additionally, we sometimes have assertions for which we want to catch them and emit additional debugging info. This commit guards the common ways that Elasticsearch is started and assertions are run with dumping all debug information available. | 19 March 2024, 18:14:18 UTC |
| 1802aea | Craig Taverner | 19 March 2024, 18:14:08 UTC | ESQL: Enrich match text (#106435) * WIP Support ENRICH MATCH on TEXT * Disallow KEYWORD from range enrich The ingest processor does not support this, and there is no keyword_range type to complement the numerical, date and ip range types. * Revert: Disallow KEYWORD from range enrich We allow using KEYWORD to range match against ip_range. * Update docs/changelog/106435.yaml * Improve changelog entry * Added yaml test for ENRICH on TEXT fields * Allow TEXT for range, so text matches IP-range (plus test) | 19 March 2024, 18:14:08 UTC |
| 0f504c1 | Mark Vieira | 19 March 2024, 18:03:23 UTC | AwaitsFix #106501 | 19 March 2024, 18:04:26 UTC |
| 97b8977 | Tim Rühsen | 19 March 2024, 17:33:27 UTC | [Profiling] Accept OTEL host architecture values (#106494) | 19 March 2024, 17:33:27 UTC |
| 022dc4d | Niels Bauman | 19 March 2024, 17:25:23 UTC | Refactor (simplify) LocalHealthMonitor (#106324) This refactors the local health monitoring process by removing the HealthProgress record and the nextRunScheduled flag. This should simplify the process and thus (hopefully) make it easier to understand (and debug if needed). | 19 March 2024, 17:25:23 UTC |
| 085e02e | Nik Everett | 19 March 2024, 17:09:57 UTC | ESQL: Explain an exception message (#106488) It'll make tracking errors easier. | 19 March 2024, 17:09:57 UTC |
| 6731538 | Ryan Ernst | 19 March 2024, 17:09:18 UTC | Different string allocation on jdk 21/22 (#106492) Similar to https://github.com/elastic/elasticsearch/pull/106360, the methods for allocating a native string changed between Java 21 and 22. This commit adds another util method to handle the differences and uses it in the jdk systemd impl. | 19 March 2024, 17:09:18 UTC |
| e14dd54 | Craig Taverner | 19 March 2024, 16:58:37 UTC | Support ST_INTERSECTS between two geometry columns (#104907) * Support ST_INTERSECTS between geometry column and other geometry or string * Pushdown to lucene for ST_INTERSECTS on GEO_POINT * Get geo_shape working in ST_INTERSECTS bypassing SingleValueQuery * Initial work to support cartesian shape queries in ESQL * Fixed CSV tests for combined ST_INTERSECTS and ST_CENTROID * Fixed bug in point-in-shape query for CARTESIAN_POINT * Added unit tests for SpatialIntersects and fixed a few bugs found * Added comments to public ShapeQueryBuilder class * Move calls to random() later to avoid security exception * Refined type checking support in ST_INTERSECTS Improved the combinations supported as preparation for removing the uly try/catch way of detecting the difference between WKT and WKB in some code. * Fixed bugs in incorrect use of doc-values in parameter type matching Also made a few reminfments, including removing one try/catch approach to differentiating between WKT and WKB. * Removed second place where we used try/catch to differentiate WKT from WKB This was a workaround for a mistake in the planning, where we incorrectly mapped incoming types to the wrong FieldEvaluators. We fixed that mistake in an earlier commit. * Fixed flaky tests were GEO was treated as CARTSIAN We assumed if the incoming types were constants, they had no CRS, even when they did, which was wrong. For shapes crossing the dateline this lead to different (incorrect) behaviour. * Fixed a flaky test by removing some point==point optimizations * Moved spatial intersects to 'spatial' package When we developed the ST_CENTROID work, this was requested, so let's do it here too. * Use normal switch on enums * Cleanup some static utility methods Now all code paths that can convert a constant string to a geometry use the same code. * Fixed bugs with non-quantized coordinates, and cleaned up code a little * Fixed failing test after change to evaluator class names * Refactored SpatialRelatesFunction into three files, and made evaluatorRules static This was a general cleanup, making the code more organized, but did also achieve static evaluator rules so we don't re-created these on every query parsing. * Fixed compile error after rebase * Removed ConstantAndConstant support, using fold() correctly instead * better error on circles * Make sure compound predicates are supported in use-doc-values pushdown * Testing ENRICH with ST_INTERSECTS This required adding new data for an ENRICH index, and this data could be tested with a few other related tests, which were also added. * Added missing mixed-cluster rules for testing only with 8.14 * Fixed some mixed-cluster issues where we failed to mark test for only 8.14 Also added an interesting polygon-polygon intersection case from real data. * Fix flaky test where cartesian polygons were generated from geo * Remove support for string literals in ST_INTERSECTS * Fix failing tests after removing string support * Removed unused code from previous string literal support (WKT parsing) * Support case where both fields are points and doc-values If we have an ST_INTERSECTS and an ST_CENTROID, the centroid asks to load the points as doc-values, and the ST_INTERSECTS needs to therefor support two doc-values points. * Disallow more than one field from doc-values for ST_INTERSECTS * Remove unused evaluator classes * Add tests for multiple doc-values if not in same intersects * Fix errors after rebase on main * Fixed bug in missing support for spatial function expressions in EVAL When a spatial aggregate expects doc-values, this was not being communicated to spatial functions in EVAL, only in WHERE. * Reduce flaky tests when reading directly from enrich source indices The test framework does not expect enrich source indices to be used directly in queries, leading to duplicated results on multi-node clusters, so we edit the queries to be less sensitive to this case. * Fixed failing test * Code style * Fixed test file name and added function name annotation * Added documentation for st_intersects * Fixed failing show functions test * Code review changes, notably simplifying the type resolution * Fixed broken docs link | 19 March 2024, 16:58:37 UTC |
| 524747e | Jack Conradson | 19 March 2024, 16:23:53 UTC | Dedupe terms in terms queries (#106381) This avoids duplication of terms in a terms query deduplicating these in the base MappedFieldType. | 19 March 2024, 16:23:53 UTC |
| edc45f5 | Nhat Nguyen | 19 March 2024, 15:01:51 UTC | Revert "Auto remove sink handlers when completed (#106438)" This reverts commit 823f174c70ad4e93c8db38fe0d1cff4bb0e865da. | 19 March 2024, 15:01:51 UTC |
| 2489d23 | Craig Taverner | 19 March 2024, 14:53:29 UTC | Skip older versions for new test (#106480) This error message only works in 8.14 | 19 March 2024, 14:53:29 UTC |
| 8357d2b | Nhat Nguyen | 19 March 2024, 14:20:42 UTC | Fix assumption in TimeSeriesIT (#106448) This should be an assumption instead of an assertion. Closes #106444 | 19 March 2024, 14:20:42 UTC |
| 823f174 | Nhat Nguyen | 19 March 2024, 14:20:22 UTC | Auto remove sink handlers when completed (#106438) Rather than manually removing sink handlers upon completion, this PR registers a listener that automatically removes the handler from ExchangeService when it completes or fails. | 19 March 2024, 14:20:22 UTC |
| c1d0e8e | Nik Everett | 19 March 2024, 13:20:11 UTC | ESQL: Drop a parameter from `BlockHash` (#106417) This drops the `DriverContext` from `BlockHash` - we already have it in `BlockFactory`. | 19 March 2024, 13:20:11 UTC |
| 628689f | Tom Veasey | 19 March 2024, 13:14:14 UTC | [ML] Fix the position of spike, dip and distribution changes bucket when the sibling aggregation includes empty buckets (#106472) There was a bug in our indexing of the spike, dip and distribution change bucket. Specifically, we were not mapping the index in the values array, which skips empty buckets, back to the aggregation bucket index. The effect was that the reported buckets were offset to the left when the spike, dip or distribution change occurred after one or more empty buckets. | 19 March 2024, 13:14:14 UTC |
| 4e2f56b | Nikolaj Volgushev | 19 March 2024, 12:55:11 UTC | Inject authz denial messages (#106358) This PR moves authorization denied message creation from static methods to an injectable class. Relates: ES-7984 | 19 March 2024, 12:55:11 UTC |
| c0476c1 | Yang Wang | 19 March 2024, 12:48:36 UTC | Trivial typo fix for #105774 (#106471) As the title says. | 19 March 2024, 12:48:36 UTC |
| 1fbb085 | Bogdan Pintea | 19 March 2024, 12:02:34 UTC | ESQL: Rename `SHOW FUNCTIONS` to `META FUNCTIONS` (#106362) This renames the `show functions` command to `meta functions`. It also removes its documentation and usage tracking. | 19 March 2024, 12:02:34 UTC |
| 963a5b8 | Albert Zaharovits | 19 March 2024, 11:09:40 UTC | Refactor GetApiKeyResponse and QueryApiKeyResponse to return List instead of arrays (#106409) The plan is that GetApiKeyResponse and QueryApiKeyResponse will be receiving collections of api key info, optional profile uids, and optional sort values, that they will "zip" into a single list of records. Array vs List is not important in this context, but we use collections in the internal services and action handlers, so it is more consistent to also use them in the responses. | 19 March 2024, 11:09:40 UTC |
| 43b8ca0 | David Turner | 19 March 2024, 10:26:23 UTC | Extract `SnapshotNamePredicate` (#106397) The logic for selecting snapshots by name in `TransportGetSnapshotsAction` is a little convoluted, not easy to test, and as implemented today requires us to create several large lists or sets of snapshot IDs. This commit extracts the logic, adds a dedicated test suite, and replaces some intermediate lists with simple filtering. | 19 March 2024, 10:26:23 UTC |
| de3e2e4 | Moritz Mack | 19 March 2024, 10:26:08 UTC | Remove deprecated APM setting from RunTask (#105076) | 19 March 2024, 10:26:08 UTC |
| 3af0e93 | Niels Bauman | 19 March 2024, 09:33:28 UTC | Fix `DataStreamLifecycleTests.testEffectiveRetention` (#106456) | 19 March 2024, 09:33:28 UTC |
| 8272ae2 | Tanguy Leroux | 19 March 2024, 09:31:49 UTC | Mute S3RepositoryThirdPartyTests.testReadFromPositionLargerThanBlobLength (#106458) Muted for investigation Relates #106457 | 19 March 2024, 09:31:49 UTC |
| e4bf51d | Simon Cooper | 19 March 2024, 09:10:46 UTC | Refactor how roundup parsers are created (#106353) | 19 March 2024, 09:10:46 UTC |
