Revision 483b4ee60edbefdfbff0dd538fb81f368d9e7c0d authored by Suresh Siddha on 04 February 2009, 19:59:44 UTC, committed by Ingo Molnar on 04 February 2009, 21:31:19 UTC
Christian Borntraeger reports: > After a logical cpu offline, even on a complete idle system, there > is one cpu with full ticks. It turns out that nohz.cpu_mask has the > the offlined cpu still set. > > In select_nohz_load_balancer() we check if the system is completely > idle to turn of load balancing. We compare cpu_online_map with > nohz.cpu_mask. Since cpu_online_map is updated on cpu unplug, > but nohz.cpu_mask is not, the check fails and the scheduler believes > that we need an "idle load balancer" even on a fully idle system. > Since the ilb cpu does not deactivate the timer tick this breaks NOHZ. Fix the select_nohz_load_balancer() to not set the nohz.cpu_mask while a cpu is going offline. Reported-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com> Tested-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
1 parent 3562612
| File | Mode | Size |
|---|---|---|
| acpica | ||
| Kconfig | -rw-r--r-- | 10.2 KB |
| Makefile | -rw-r--r-- | 1.5 KB |
| ac.c | -rw-r--r-- | 9.3 KB |
| acpi_memhotplug.c | -rw-r--r-- | 14.5 KB |
| battery.c | -rw-r--r-- | 25.2 KB |
| blacklist.c | -rw-r--r-- | 6.5 KB |
| bus.c | -rw-r--r-- | 21.5 KB |
| button.c | -rw-r--r-- | 14.8 KB |
| cm_sbs.c | -rw-r--r-- | 2.9 KB |
| container.c | -rw-r--r-- | 6.9 KB |
| debug.c | -rw-r--r-- | 9.0 KB |
| dock.c | -rw-r--r-- | 30.4 KB |
| ec.c | -rw-r--r-- | 27.8 KB |
| event.c | -rw-r--r-- | 6.8 KB |
| fan.c | -rw-r--r-- | 9.0 KB |
| glue.c | -rw-r--r-- | 7.3 KB |
| numa.c | -rw-r--r-- | 6.8 KB |
| osl.c | -rw-r--r-- | 32.9 KB |
| pci_bind.c | -rw-r--r-- | 9.4 KB |
| pci_irq.c | -rw-r--r-- | 12.2 KB |
| pci_link.c | -rw-r--r-- | 24.1 KB |
| pci_root.c | -rw-r--r-- | 9.9 KB |
| pci_slot.c | -rw-r--r-- | 9.9 KB |
| power.c | -rw-r--r-- | 20.7 KB |
| proc.c | -rw-r--r-- | 13.0 KB |
| processor_core.c | -rw-r--r-- | 30.3 KB |
| processor_idle.c | -rw-r--r-- | 49.1 KB |
| processor_perflib.c | -rw-r--r-- | 19.9 KB |
| processor_thermal.c | -rw-r--r-- | 12.0 KB |
| processor_throttling.c | -rw-r--r-- | 32.5 KB |
| reboot.c | -rw-r--r-- | 1.2 KB |
| sbs.c | -rw-r--r-- | 28.1 KB |
| sbshc.c | -rw-r--r-- | 7.8 KB |
| sbshc.h | -rw-r--r-- | 960 bytes |
| scan.c | -rw-r--r-- | 38.5 KB |
| sleep.c | -rw-r--r-- | 19.3 KB |
| sleep.h | -rw-r--r-- | 236 bytes |
| system.c | -rw-r--r-- | 14.6 KB |
| tables.c | -rw-r--r-- | 8.6 KB |
| thermal.c | -rw-r--r-- | 48.1 KB |
| utils.c | -rw-r--r-- | 10.3 KB |
| video.c | -rw-r--r-- | 53.5 KB |
| video_detect.c | -rw-r--r-- | 8.3 KB |
| wakeup.c | -rw-r--r-- | 4.5 KB |
Computing file changes ...
