Revision 483b4ee60edbefdfbff0dd538fb81f368d9e7c0d authored by Suresh Siddha on 04 February 2009, 19:59:44 UTC, committed by Ingo Molnar on 04 February 2009, 21:31:19 UTC
Christian Borntraeger reports: > After a logical cpu offline, even on a complete idle system, there > is one cpu with full ticks. It turns out that nohz.cpu_mask has the > the offlined cpu still set. > > In select_nohz_load_balancer() we check if the system is completely > idle to turn of load balancing. We compare cpu_online_map with > nohz.cpu_mask. Since cpu_online_map is updated on cpu unplug, > but nohz.cpu_mask is not, the check fails and the scheduler believes > that we need an "idle load balancer" even on a fully idle system. > Since the ilb cpu does not deactivate the timer tick this breaks NOHZ. Fix the select_nohz_load_balancer() to not set the nohz.cpu_mask while a cpu is going offline. Reported-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com> Tested-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
1 parent 3562612
| File | Mode | Size |
|---|---|---|
| aoe | ||
| paride | ||
| DAC960.c | -rw-r--r-- | 259.5 KB |
| DAC960.h | -rw-r--r-- | 148.2 KB |
| Kconfig | -rw-r--r-- | 15.9 KB |
| Makefile | -rw-r--r-- | 1.1 KB |
| amiflop.c | -rw-r--r-- | 46.2 KB |
| ataflop.c | -rw-r--r-- | 51.0 KB |
| brd.c | -rw-r--r-- | 13.7 KB |
| cciss.c | -rw-r--r-- | 105.6 KB |
| cciss.h | -rw-r--r-- | 7.0 KB |
| cciss_cmd.h | -rw-r--r-- | 7.9 KB |
| cciss_scsi.c | -rw-r--r-- | 47.1 KB |
| cciss_scsi.h | -rw-r--r-- | 3.1 KB |
| cpqarray.c | -rw-r--r-- | 47.1 KB |
| cpqarray.h | -rw-r--r-- | 3.0 KB |
| cryptoloop.c | -rw-r--r-- | 4.9 KB |
| floppy.c | -rw-r--r-- | 116.2 KB |
| hd.c | -rw-r--r-- | 19.0 KB |
| ida_cmd.h | -rw-r--r-- | 6.8 KB |
| ida_ioctl.h | -rw-r--r-- | 2.6 KB |
| loop.c | -rw-r--r-- | 39.1 KB |
| nbd.c | -rw-r--r-- | 19.8 KB |
| pktcdvd.c | -rw-r--r-- | 76.4 KB |
| ps3disk.c | -rw-r--r-- | 14.3 KB |
| smart1,2.h | -rw-r--r-- | 7.1 KB |
| sunvdc.c | -rw-r--r-- | 19.3 KB |
| swim3.c | -rw-r--r-- | 29.3 KB |
| sx8.c | -rw-r--r-- | 40.0 KB |
| ub.c | -rw-r--r-- | 62.4 KB |
| umem.c | -rw-r--r-- | 30.0 KB |
| umem.h | -rw-r--r-- | 3.6 KB |
| viodasd.c | -rw-r--r-- | 21.7 KB |
| virtio_blk.c | -rw-r--r-- | 9.4 KB |
| xd.c | -rw-r--r-- | 33.7 KB |
| xd.h | -rw-r--r-- | 5.7 KB |
| xen-blkfront.c | -rw-r--r-- | 26.6 KB |
| xsysace.c | -rw-r--r-- | 33.4 KB |
| z2ram.c | -rw-r--r-- | 8.8 KB |
Computing file changes ...
