Revision 483b4ee60edbefdfbff0dd538fb81f368d9e7c0d authored by Suresh Siddha on 04 February 2009, 19:59:44 UTC, committed by Ingo Molnar on 04 February 2009, 21:31:19 UTC
Christian Borntraeger reports: > After a logical cpu offline, even on a complete idle system, there > is one cpu with full ticks. It turns out that nohz.cpu_mask has the > the offlined cpu still set. > > In select_nohz_load_balancer() we check if the system is completely > idle to turn of load balancing. We compare cpu_online_map with > nohz.cpu_mask. Since cpu_online_map is updated on cpu unplug, > but nohz.cpu_mask is not, the check fails and the scheduler believes > that we need an "idle load balancer" even on a fully idle system. > Since the ilb cpu does not deactivate the timer tick this breaks NOHZ. Fix the select_nohz_load_balancer() to not set the nohz.cpu_mask while a cpu is going offline. Reported-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com> Tested-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
1 parent 3562612
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 9.0 KB |
| Makefile | -rw-r--r-- | 1.8 KB |
| adb-iop.c | -rw-r--r-- | 6.2 KB |
| adb.c | -rw-r--r-- | 19.2 KB |
| adbhid.c | -rw-r--r-- | 34.8 KB |
| ans-lcd.c | -rw-r--r-- | 3.8 KB |
| ans-lcd.h | -rw-r--r-- | 206 bytes |
| apm_emu.c | -rw-r--r-- | 3.1 KB |
| mac_hid.c | -rw-r--r-- | 3.6 KB |
| macio-adb.c | -rw-r--r-- | 6.4 KB |
| macio_asic.c | -rw-r--r-- | 18.8 KB |
| macio_sysfs.c | -rw-r--r-- | 1.6 KB |
| mediabay.c | -rw-r--r-- | 21.5 KB |
| nvram.c | -rw-r--r-- | 2.5 KB |
| rack-meter.c | -rw-r--r-- | 15.4 KB |
| smu.c | -rw-r--r-- | 30.6 KB |
| therm_adt746x.c | -rw-r--r-- | 17.1 KB |
| therm_pm72.c | -rw-r--r-- | 61.8 KB |
| therm_pm72.h | -rw-r--r-- | 9.3 KB |
| therm_windtunnel.c | -rw-r--r-- | 12.1 KB |
| via-cuda.c | -rw-r--r-- | 15.6 KB |
| via-macii.c | -rw-r--r-- | 14.1 KB |
| via-maciisi.c | -rw-r--r-- | 15.4 KB |
| via-pmu-backlight.c | -rw-r--r-- | 4.4 KB |
| via-pmu-event.c | -rw-r--r-- | 2.1 KB |
| via-pmu-event.h | -rw-r--r-- | 177 bytes |
| via-pmu-led.c | -rw-r--r-- | 3.1 KB |
| via-pmu.c | -rw-r--r-- | 60.1 KB |
| via-pmu68k.c | -rw-r--r-- | 19.5 KB |
| windfarm.h | -rw-r--r-- | 3.7 KB |
| windfarm_core.c | -rw-r--r-- | 10.9 KB |
| windfarm_cpufreq_clamp.c | -rw-r--r-- | 2.4 KB |
| windfarm_lm75_sensor.c | -rw-r--r-- | 5.6 KB |
| windfarm_max6690_sensor.c | -rw-r--r-- | 4.3 KB |
| windfarm_pid.c | -rw-r--r-- | 3.7 KB |
| windfarm_pid.h | -rw-r--r-- | 2.7 KB |
| windfarm_pm112.c | -rw-r--r-- | 18.1 KB |
| windfarm_pm121.c | -rw-r--r-- | 24.8 KB |
| windfarm_pm81.c | -rw-r--r-- | 21.3 KB |
| windfarm_pm91.c | -rw-r--r-- | 18.3 KB |
| windfarm_smu_controls.c | -rw-r--r-- | 8.0 KB |
| windfarm_smu_sat.c | -rw-r--r-- | 8.9 KB |
| windfarm_smu_sensors.c | -rw-r--r-- | 11.3 KB |
Computing file changes ...
