Skip to main content

Browse the archive

Revision 4860abb91f3d7fbaf8147d54782149bb1fc45892 authored by Steve French on 06 February 2024, 22:34:22 UTC, committed by Steve French on 16 February 2024, 04:19:23 UTC 
smb: Fix regression in writes when non-standard maximum write size negotiated
 
The conversion to netfs in the 6.3 kernel caused a regression when
maximum write size is set by the server to an unexpected value which is
not a multiple of 4096 (similarly if the user overrides the maximum
write size by setting mount parm "wsize", but sets it to a value that
is not a multiple of 4096).  When negotiated write size is not a
multiple of 4096 the netfs code can skip the end of the final
page when doing large sequential writes, causing data corruption.

This section of code is being rewritten/removed due to a large
netfs change, but until that point (ie for the 6.3 kernel until now)
we can not support non-standard maximum write sizes.

Add a warning if a user specifies a wsize on mount that is not
a multiple of 4096 (and round down), also add a change where we
round down the maximum write size if the server negotiates a value
that is not a multiple of 4096 (we also have to check to make sure that
we do not round it down to zero).

Reported-by: R. Diez" <rdiez-2006@rd10.de>
Fixes: d08089f649a0 ("cifs: Change the I/O paths to use an iterator rather than a page list")
Suggested-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Acked-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Tested-by: Matthew Ruffell <matthew.ruffell@canonical.com>
Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
Cc: stable@vger.kernel.org # v6.3+
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent 8bde59b
Raw File
is_signed_type_kunit.c 
// SPDX-License-Identifier: GPL-2.0 OR MIT
/*
 *	./tools/testing/kunit/kunit.py run is_signed_type [--raw_output]
 */
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

#include <kunit/test.h>
#include <linux/compiler.h>

enum unsigned_enum {
	constant_a = 3,
};

enum signed_enum {
	constant_b = -1,
	constant_c = 2,
};

static void is_signed_type_test(struct kunit *test)
{
	KUNIT_EXPECT_EQ(test, is_signed_type(bool), false);
	KUNIT_EXPECT_EQ(test, is_signed_type(signed char), true);
	KUNIT_EXPECT_EQ(test, is_signed_type(unsigned char), false);
	KUNIT_EXPECT_EQ(test, is_signed_type(char), false);
	KUNIT_EXPECT_EQ(test, is_signed_type(int), true);
	KUNIT_EXPECT_EQ(test, is_signed_type(unsigned int), false);
	KUNIT_EXPECT_EQ(test, is_signed_type(long), true);
	KUNIT_EXPECT_EQ(test, is_signed_type(unsigned long), false);
	KUNIT_EXPECT_EQ(test, is_signed_type(long long), true);
	KUNIT_EXPECT_EQ(test, is_signed_type(unsigned long long), false);
	KUNIT_EXPECT_EQ(test, is_signed_type(enum unsigned_enum), false);
	KUNIT_EXPECT_EQ(test, is_signed_type(enum signed_enum), true);
	KUNIT_EXPECT_EQ(test, is_signed_type(void *), false);
	KUNIT_EXPECT_EQ(test, is_signed_type(const char *), false);
}

static struct kunit_case is_signed_type_test_cases[] = {
	KUNIT_CASE(is_signed_type_test),
	{}
};

static struct kunit_suite is_signed_type_test_suite = {
	.name = "is_signed_type",
	.test_cases = is_signed_type_test_cases,
};

kunit_test_suite(is_signed_type_test_suite);

MODULE_LICENSE("Dual MIT/GPL");
back to top