Revision 48cae885d5a896030588978f503c73c5ed5e62b1 authored by Stefan Weinhuber on 11 February 2009, 09:37:31 UTC, committed by Martin Schwidefsky on 11 February 2009, 09:37:40 UTC
In dasd_device_set_timer and dasd_block_set_timer we interpret the
return value of mod_timer in a wrong way. If the timer expires in
the small window between our check of timer_pending and the call to
mod_timer, then the timer will be set, mod_timer returns zero and
we will call add_timer for a timer that is already pending.
As del_timer and mod_timer do all the necessary checking themselves,
we can simplify our code and remove the race a the same time.

Signed-off-by: Stefan Weinhuber <wein@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
1 parent ca0b4b7
History
File Mode Size
Kconfig -rw-r--r-- 8.9 KB
Makefile -rw-r--r-- 620 bytes
acorn.c -rw-r--r-- 11.9 KB
acorn.h -rw-r--r-- 623 bytes
amiga.c -rw-r--r-- 3.4 KB
amiga.h -rw-r--r-- 116 bytes
atari.c -rw-r--r-- 3.8 KB
atari.h -rw-r--r-- 1.1 KB
check.c -rw-r--r-- 15.1 KB
check.h -rw-r--r-- 551 bytes
efi.c -rw-r--r-- 19.2 KB
efi.h -rw-r--r-- 4.2 KB
ibm.c -rw-r--r-- 5.1 KB
ibm.h -rw-r--r-- 70 bytes
karma.c -rw-r--r-- 1.1 KB
karma.h -rw-r--r-- 151 bytes
ldm.c -rw-r--r-- 43.7 KB
ldm.h -rw-r--r-- 5.5 KB
mac.c -rw-r--r-- 3.2 KB
mac.h -rw-r--r-- 1.3 KB
msdos.c -rw-r--r-- 14.2 KB
msdos.h -rw-r--r-- 151 bytes
osf.c -rw-r--r-- 1.7 KB
osf.h -rw-r--r-- 150 bytes
sgi.c -rw-r--r-- 2.2 KB
sgi.h -rw-r--r-- 155 bytes
sun.c -rw-r--r-- 3.8 KB
sun.h -rw-r--r-- 196 bytes
sysv68.c -rw-r--r-- 1.8 KB
sysv68.h -rw-r--r-- 89 bytes
ultrix.c -rw-r--r-- 1.2 KB
ultrix.h -rw-r--r-- 117 bytes

back to top