Revision 4954af9c5ee5bb1b5b9172ddbcbac03ca6e151ea authored by Keno Fischer on 01 September 2023, 19:52:14 UTC, committed by GitHub on 01 September 2023, 19:52:14 UTC
The change in #50429 moves around some dispatch boundaries and pushes the allocations in the offsetarrays `maximum!` test over the limit. The implementation of that code is massively type unstable. Somewhat, ironically, the whole original point of that test was to test that the implementation was not type-unstable (#28941), so actually opt our OffsetArrays implementation into the interface that's supposed to guarantee that. If this PR is fine here, I'll submit the same upstream to avoid diverging the implementations too much. Co-authored-by: Jameson Nash <vtjnash@gmail.com>
1 parent a173010
iostream.jl
# This file is a part of Julia. License is MIT: https://julialang.org/license
@testset "skipchars for IOStream" begin
mktemp() do path, file
function append_to_file(str)
mark(file)
print(file, str)
flush(file)
reset(file)
end
# test it doesn't error on eof
@test eof(skipchars(isspace, file))
# test it correctly skips
append_to_file(" ")
@test eof(skipchars(isspace, file))
# test it correctly detects comment lines
append_to_file("# \n ")
@test eof(skipchars(isspace, file, linecomment='#'))
# test it stops at the appropriate time
append_to_file(" not a space")
@test !eof(skipchars(isspace, file))
@test read(file, Char) == 'n'
# test it correctly ignores the contents of comment lines
append_to_file(" #not a space \n not a space")
@test !eof(skipchars(isspace, file, linecomment='#'))
@test read(file, Char) == 'n'
# test it correctly handles unicode
for (byte, char) in zip(1:4, ('@','߷','࿊','𐋺'))
append_to_file("abcdef$char")
@test ncodeunits(char) == byte
@test !eof(skipchars(isletter, file))
@test read(file, Char) == char
end
end
end
@testset "readbytes!" begin
mktemp() do path, file
function append_to_file(str)
mark(file)
print(file, str)
flush(file)
reset(file)
end
# Array
append_to_file("aaaaaaaaaaaaaaaaa")
# readbytes_some
b = UInt8[0]
readbytes!(file, b, all=false)
@test String(b) == "a"
# with resizing of b
b = UInt8[]
readbytes!(file, b, 2, all=false)
@test String(b) == "aa"
# readbytes_all with resizing
b = UInt8[]
readbytes!(file, b, 15)
@test String(b) == "aaaaaaaaaaaaaa"
# SubArray
append_to_file("aaaaaaaaaaaaaaaaa")
# readbytes_some
b = view(UInt8[0, 0, 0], 2:2)
readbytes!(file, b, all=false)
@test String(b) == "a"
b = view(UInt8[0, 0, 0], 2:3)
readbytes!(file, b, 2, all=false)
@test String(b) == "aa"
b = view(UInt8[0, 0, 0], 1:3)
readbytes!(file, b, 2, all=false)
@test b == UInt8['a', 'a', 0]
@test String(b[1:2]) == "aa"
# with resizing of b
b = view(UInt8[0, 0, 0], 1:0)
@test_throws MethodError readbytes!(file, b, 2, all=false)
@test isempty(b)
# readbytes_all
b = view(UInt8[0, 0, 0], 2:2)
readbytes!(file, b)
@test String(b) == "a"
b = view(UInt8[0, 0, 0], 2:3)
readbytes!(file, b, 2)
@test String(b) == "aa"
b = view(UInt8[0, 0, 0], 1:3)
readbytes!(file, b, 2)
@test b == UInt8['a', 'a', 0]
@test String(b[1:2]) == "aa"
# with resizing of b
b = view(UInt8[0, 0, 0], 1:0)
@test_throws MethodError readbytes!(file, b, 2)
@test !islocked(file.lock) # Issue #37218
@test isempty(b)
end
end
@testset "issue #18755" begin
mktemp() do path, io
write(io, zeros(UInt8, 131073))
@test position(io) == 131073
write(io, zeros(UInt8, 131073))
@test position(io) == 262146
end
end
@testset "issue #27951" begin
a = UInt8[1 3; 2 4]
s = view(a, [1,2], :)
mktemp() do path, io
write(io, s)
seek(io, 0)
b = Vector{UInt8}(undef, 4)
@test readbytes!(io, b) == 4
@test b == 0x01:0x04
end
end
@test Base.open_flags(read=false, write=true, append=false) == (read=false, write=true, create=true, truncate=true, append=false)
@testset "issue #30978" begin
mktemp() do path, io
x = rand(UInt8, 100)
write(path, x)
# Should not throw OutOfMemoryError
y = open(f -> read(f, typemax(Int)), path)
@test x == y
# Should resize y to right length
y = zeros(UInt8, 99)
open(f -> readbytes!(f, y, 101, all=true), path)
@test x == y
y = zeros(UInt8, 99)
open(f -> readbytes!(f, y, 101, all=false), path)
@test x == y
# Should never shrink y below original size
y = zeros(UInt8, 101)
open(f -> readbytes!(f, y, 102, all=true), path)
@test y == [x; 0]
y = zeros(UInt8, 101)
open(f -> readbytes!(f, y, 102, all=false), path)
@test y == [x; 0]
end
end
@testset "peek(::IOStream)" begin
mktemp() do _, file
@test_throws EOFError peek(file)
mark(file)
write(file, "Lávate las manos")
flush(file)
reset(file)
@test peek(file) == 0x4c
end
end
@testset "issue #36004" begin
f = tempname()
open(f, "w") do io
write(io, "test")
end
open(f, "r") do io
@test length(readavailable(io)) > 0
end
end
@testset "inference" begin
@test all(T -> T <: Union{UInt, Int}, Base.return_types(unsafe_write, (IO, Ptr{UInt8}, UInt)))
@test all(T -> T === Bool, Base.return_types(eof, (IO,)))
end
Computing file changes ...