Revision - 4a59015 - xattr: Fix setting security xattrs on sockfs - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

29 July 2024, 15:18:00 UTC

Revision 4a59015372840a6fc35d7fd40638a9d5dc3ec958 authored by Andreas Gruenbacher on 13 November 2016, 20:23:34 UTC, committed by Al Viro on 17 November 2016, 05:00:23 UTC

xattr: Fix setting security xattrs on sockfs

The IOP_XATTR flag is set on sockfs because sockfs supports getting the
"system.sockprotoname" xattr.  Since commit 6c6ef9f2, this flag is checked for
setxattr support as well.  This is wrong on sockfs because security xattr
support there is supposed to be provided by security_inode_setsecurity.  The
smack security module relies on socket labels (xattrs).

Fix this by adding a security xattr handler on sockfs that returns
-EAGAIN, and by checking for -EAGAIN in setxattr.

We cannot simply check for -EOPNOTSUPP in setxattr because there are
filesystems that neither have direct security xattr support nor support
via security_inode_setsecurity.  A more proper fix might be to move the
call to security_inode_setsecurity into sockfs, but it's not clear to me
if that is safe: we would end up calling security_inode_post_setxattr after
that as well.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

1 parent 961b708

Files
Changes

Permalinks

Tip revision: 4a59015372840a6fc35d7fd40638a9d5dc3ec958 authored by Andreas Gruenbacher on 13 November 2016, 20:23:34 UTC
xattr: Fix setting security xattrs on sockfs

Tip revision: 4a59015

File	Mode	Size
Documentation
arch
block
certs
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.cocciconfig	-rw-r--r--	59 bytes
.get_maintainer.ignore	-rw-r--r--	31 bytes
.gitattributes	-rw-r--r--	30 bytes
.gitignore	-rw-r--r--	1.3 KB
.mailmap	-rw-r--r--	7.5 KB
COPYING	-rw-r--r--	18.3 KB
CREDITS	-rw-r--r--	96.0 KB
Kbuild	-rw-r--r--	2.8 KB
Kconfig	-rw-r--r--	252 bytes
MAINTAINERS	-rw-r--r--	373.4 KB
Makefile	-rw-r--r--	57.4 KB
README	-rw-r--r--	17.9 KB
REPORTING-BUGS	-rw-r--r--	7.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

xattr: Fix setting security xattrs on sockfs

README