https://github.com/torvalds/linux
Revision 4cb205c0c50f613e2de91f0eb19d5247ed003e89 authored by Jia He on 28 August 2018, 04:53:26 UTC, committed by Thomas Gleixner on 06 September 2018, 18:31:59 UTC
Commit fe8e93504ce8 ("irqchip/gic-v3-its: Use full range of LPIs"), removes
the cap for lpi_id_bits, which causes the following warning to trigger on a
QDF2400 server:
WARNING: CPU: 0 PID: 0 at mm/page_alloc.c:4066 __alloc_pages_nodemask
...
Call trace:
__alloc_pages_nodemask+0x2d8/0x1188
alloc_pages_current+0x8c/0xd8
its_allocate_prop_table+0x5c/0xb8
its_init+0x220/0x3c0
gic_init_bases+0x250/0x380
gic_acpi_init+0x16c/0x2a4
In its_alloc_lpi_tables(), lpi_id_bits is 24 in QDF2400. The allocation in
allocate_prop_table() tries therefore to allocate 16M (order 12 if
pagesize=4k), which triggers the warning.
As said by MarcL
Capping lpi_id_bits at 16 (which is what we had before) is plenty,
will save a some memory, and gives some margin before we need to push
it up again.
Bring the upper limit of lpi_id_bits back to prevent
Fixes: fe8e93504ce8 ("irqchip/gic-v3-its: Use full range of LPIs")
Suggested-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Jia He <jia.he@hxt-semitech.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Tested-by: Olof Johansson <olof@lixom.net>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: linux-arm-kernel@lists.infradead.org
Link: https://lkml.kernel.org/r/1535432006-2304-1-git-send-email-jia.he@hxt-semitech.com
1 parent db44bf4
Tip revision: 4cb205c0c50f613e2de91f0eb19d5247ed003e89 authored by Jia He on 28 August 2018, 04:53:26 UTC
irqchip/gic-v3-its: Cap lpi_id_bits to reduce memory footprint
irqchip/gic-v3-its: Cap lpi_id_bits to reduce memory footprint
Tip revision: 4cb205c
| File | Mode | Size |
|---|---|---|
| bpf | ||
| cgroup | ||
| configs | ||
| debug | ||
| dma | ||
| events | ||
| gcov | ||
| irq | ||
| livepatch | ||
| locking | ||
| power | ||
| printk | ||
| rcu | ||
| sched | ||
| time | ||
| trace | ||
| .gitignore | -rw-r--r-- | 69 bytes |
| Kconfig.freezer | -rw-r--r-- | 52 bytes |
| Kconfig.hz | -rw-r--r-- | 1.6 KB |
| Kconfig.locks | -rw-r--r-- | 4.8 KB |
| Kconfig.preempt | -rw-r--r-- | 2.2 KB |
| Makefile | -rw-r--r-- | 4.1 KB |
| acct.c | -rw-r--r-- | 15.4 KB |
| async.c | -rw-r--r-- | 10.1 KB |
| audit.c | -rw-r--r-- | 62.4 KB |
| audit.h | -rw-r--r-- | 11.1 KB |
| audit_fsnotify.c | -rw-r--r-- | 6.1 KB |
| audit_tree.c | -rw-r--r-- | 23.9 KB |
| audit_watch.c | -rw-r--r-- | 14.8 KB |
| auditfilter.c | -rw-r--r-- | 34.2 KB |
| auditsc.c | -rw-r--r-- | 67.0 KB |
| backtracetest.c | -rw-r--r-- | 2.1 KB |
| bounds.c | -rw-r--r-- | 739 bytes |
| capability.c | -rw-r--r-- | 13.9 KB |
| compat.c | -rw-r--r-- | 11.9 KB |
| configs.c | -rw-r--r-- | 2.8 KB |
| context_tracking.c | -rw-r--r-- | 6.3 KB |
| cpu.c | -rw-r--r-- | 54.3 KB |
| cpu_pm.c | -rw-r--r-- | 6.0 KB |
| crash_core.c | -rw-r--r-- | 11.4 KB |
| crash_dump.c | -rw-r--r-- | 1.3 KB |
| cred.c | -rw-r--r-- | 21.5 KB |
| delayacct.c | -rw-r--r-- | 4.7 KB |
| dma.c | -rw-r--r-- | 3.3 KB |
| elfcore.c | -rw-r--r-- | 432 bytes |
| exec_domain.c | -rw-r--r-- | 1.1 KB |
| exit.c | -rw-r--r-- | 44.2 KB |
| extable.c | -rw-r--r-- | 4.8 KB |
| fail_function.c | -rw-r--r-- | 7.2 KB |
| fork.c | -rw-r--r-- | 61.9 KB |
| freezer.c | -rw-r--r-- | 4.5 KB |
| futex.c | -rw-r--r-- | 97.4 KB |
| futex_compat.c | -rw-r--r-- | 4.5 KB |
| groups.c | -rw-r--r-- | 4.9 KB |
| hung_task.c | -rw-r--r-- | 6.6 KB |
| iomem.c | -rw-r--r-- | 4.7 KB |
| irq_work.c | -rw-r--r-- | 4.4 KB |
| jump_label.c | -rw-r--r-- | 19.8 KB |
| kallsyms.c | -rw-r--r-- | 17.6 KB |
| kcmp.c | -rw-r--r-- | 5.7 KB |
| kcov.c | -rw-r--r-- | 11.0 KB |
| kexec.c | -rw-r--r-- | 7.8 KB |
| kexec_core.c | -rw-r--r-- | 30.9 KB |
| kexec_file.c | -rw-r--r-- | 30.6 KB |
| kexec_internal.h | -rw-r--r-- | 924 bytes |
| kmod.c | -rw-r--r-- | 5.0 KB |
| kprobes.c | -rw-r--r-- | 62.2 KB |
| ksysfs.c | -rw-r--r-- | 6.3 KB |
| kthread.c | -rw-r--r-- | 33.7 KB |
| latencytop.c | -rw-r--r-- | 7.9 KB |
| memremap.c | -rw-r--r-- | 10.4 KB |
| module-internal.h | -rw-r--r-- | 959 bytes |
| module.c | -rw-r--r-- | 111.9 KB |
| module_signing.c | -rw-r--r-- | 2.3 KB |
| notifier.c | -rw-r--r-- | 16.3 KB |
| nsproxy.c | -rw-r--r-- | 6.5 KB |
| padata.c | -rw-r--r-- | 27.1 KB |
| panic.c | -rw-r--r-- | 16.6 KB |
| params.c | -rw-r--r-- | 23.2 KB |
| pid.c | -rw-r--r-- | 11.2 KB |
| pid_namespace.c | -rw-r--r-- | 11.4 KB |
| profile.c | -rw-r--r-- | 14.8 KB |
| ptrace.c | -rw-r--r-- | 32.4 KB |
| range.c | -rw-r--r-- | 3.0 KB |
| reboot.c | -rw-r--r-- | 13.9 KB |
| relay.c | -rw-r--r-- | 32.1 KB |
| resource.c | -rw-r--r-- | 39.6 KB |
| rseq.c | -rw-r--r-- | 10.0 KB |
| seccomp.c | -rw-r--r-- | 34.3 KB |
| signal.c | -rw-r--r-- | 102.7 KB |
| smp.c | -rw-r--r-- | 21.3 KB |
| smpboot.c | -rw-r--r-- | 11.7 KB |
| smpboot.h | -rw-r--r-- | 640 bytes |
| softirq.c | -rw-r--r-- | 18.5 KB |
| stacktrace.c | -rw-r--r-- | 1.8 KB |
| stop_machine.c | -rw-r--r-- | 17.8 KB |
| sys.c | -rw-r--r-- | 61.9 KB |
| sys_ni.c | -rw-r--r-- | 8.8 KB |
| sysctl.c | -rw-r--r-- | 75.2 KB |
| sysctl_binary.c | -rw-r--r-- | 50.2 KB |
| task_work.c | -rw-r--r-- | 3.1 KB |
| taskstats.c | -rw-r--r-- | 15.4 KB |
| test_kprobes.c | -rw-r--r-- | 6.4 KB |
| torture.c | -rw-r--r-- | 21.0 KB |
| tracepoint.c | -rw-r--r-- | 15.8 KB |
| tsacct.c | -rw-r--r-- | 5.1 KB |
| ucount.c | -rw-r--r-- | 5.7 KB |
| uid16.c | -rw-r--r-- | 5.1 KB |
| uid16.h | -rw-r--r-- | 442 bytes |
| umh.c | -rw-r--r-- | 18.0 KB |
| up.c | -rw-r--r-- | 2.0 KB |
| user-return-notifier.c | -rw-r--r-- | 1.3 KB |
| user.c | -rw-r--r-- | 5.6 KB |
| user_namespace.c | -rw-r--r-- | 33.3 KB |
| utsname.c | -rw-r--r-- | 4.0 KB |
| utsname_sysctl.c | -rw-r--r-- | 3.4 KB |
| watchdog.c | -rw-r--r-- | 21.1 KB |
| watchdog_hld.c | -rw-r--r-- | 7.7 KB |
| workqueue.c | -rw-r--r-- | 159.4 KB |
| workqueue_internal.h | -rw-r--r-- | 2.2 KB |
Computing file changes ...
