Revision 4d59b6ccf000862beed6fc0765d3209f98a8d8a2 authored by Tejun Heo on 08 February 2017, 22:30:56 UTC, committed by Linus Torvalds on 08 February 2017, 23:41:43 UTC
Commit 513e3d2d11c9 ("cpumask: always use nr_cpu_ids in formatting and parsing functions") converted both cpumask printing and parsing functions to use nr_cpu_ids instead of nr_cpumask_bits. While this was okay for the printing functions as it just picked one of the two output formats that we were alternating between depending on a kernel config, doing the same for parsing wasn't okay. nr_cpumask_bits can be either nr_cpu_ids or NR_CPUS. We can always use nr_cpu_ids but that is a variable while NR_CPUS is a constant, so it can be more efficient to use NR_CPUS when we can get away with it. Converting the printing functions to nr_cpu_ids makes sense because it affects how the masks get presented to userspace and doesn't break anything; however, using nr_cpu_ids for parsing functions can incorrectly leave the higher bits uninitialized while reading in these masks from userland. As all testing and comparison functions use nr_cpumask_bits which can be larger than nr_cpu_ids, the parsed cpumasks can erroneously yield false negative results. This made the taskstats interface incorrectly return -EINVAL even when the inputs were correct. Fix it by restoring the parse functions to use nr_cpumask_bits instead of nr_cpu_ids. Link: http://lkml.kernel.org/r/20170206182442.GB31078@htj.duckdns.org Fixes: 513e3d2d11c9 ("cpumask: always use nr_cpu_ids in formatting and parsing functions") Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Martin Steigerwald <martin.steigerwald@teamix.de> Debugged-by: Ben Hutchings <ben.hutchings@codethink.co.uk> Cc: <stable@vger.kernel.org> [4.0+] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 0911d00
File | Mode | Size |
---|---|---|
ad1816a | ||
ad1848 | ||
cs423x | ||
es1688 | ||
galaxy | ||
gus | ||
msnd | ||
opti9xx | ||
sb | ||
wavefront | ||
wss | ||
Kconfig | -rw-r--r-- | 12.5 KB |
Makefile | -rw-r--r-- | 857 bytes |
adlib.c | -rw-r--r-- | 2.6 KB |
als100.c | -rw-r--r-- | 10.3 KB |
azt2320.c | -rw-r--r-- | 9.6 KB |
cmi8328.c | -rw-r--r-- | 13.3 KB |
cmi8330.c | -rw-r--r-- | 22.5 KB |
es18xx.c | -rw-r--r-- | 69.3 KB |
opl3sa2.c | -rw-r--r-- | 28.9 KB |
sc6000.c | -rw-r--r-- | 17.7 KB |
sscape.c | -rw-r--r-- | 32.6 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...