Revision 4d59b6ccf000862beed6fc0765d3209f98a8d8a2 authored by Tejun Heo on 08 February 2017, 22:30:56 UTC, committed by Linus Torvalds on 08 February 2017, 23:41:43 UTC
Commit 513e3d2d11c9 ("cpumask: always use nr_cpu_ids in formatting and parsing functions") converted both cpumask printing and parsing functions to use nr_cpu_ids instead of nr_cpumask_bits. While this was okay for the printing functions as it just picked one of the two output formats that we were alternating between depending on a kernel config, doing the same for parsing wasn't okay. nr_cpumask_bits can be either nr_cpu_ids or NR_CPUS. We can always use nr_cpu_ids but that is a variable while NR_CPUS is a constant, so it can be more efficient to use NR_CPUS when we can get away with it. Converting the printing functions to nr_cpu_ids makes sense because it affects how the masks get presented to userspace and doesn't break anything; however, using nr_cpu_ids for parsing functions can incorrectly leave the higher bits uninitialized while reading in these masks from userland. As all testing and comparison functions use nr_cpumask_bits which can be larger than nr_cpu_ids, the parsed cpumasks can erroneously yield false negative results. This made the taskstats interface incorrectly return -EINVAL even when the inputs were correct. Fix it by restoring the parse functions to use nr_cpumask_bits instead of nr_cpu_ids. Link: http://lkml.kernel.org/r/20170206182442.GB31078@htj.duckdns.org Fixes: 513e3d2d11c9 ("cpumask: always use nr_cpu_ids in formatting and parsing functions") Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Martin Steigerwald <martin.steigerwald@teamix.de> Debugged-by: Ben Hutchings <ben.hutchings@codethink.co.uk> Cc: <stable@vger.kernel.org> [4.0+] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 0911d00
File | Mode | Size |
---|---|---|
6fire | ||
bcd2000 | ||
caiaq | ||
hiface | ||
line6 | ||
misc | ||
usx2y | ||
Kconfig | -rw-r--r-- | 4.5 KB |
Makefile | -rw-r--r-- | 598 bytes |
card.c | -rw-r--r-- | 22.4 KB |
card.h | -rw-r--r-- | 6.6 KB |
clock.c | -rw-r--r-- | 11.7 KB |
clock.h | -rw-r--r-- | 339 bytes |
debug.h | -rw-r--r-- | 262 bytes |
endpoint.c | -rw-r--r-- | 33.0 KB |
endpoint.h | -rw-r--r-- | 1.3 KB |
format.c | -rw-r--r-- | 14.3 KB |
format.h | -rw-r--r-- | 292 bytes |
helper.c | -rw-r--r-- | 3.1 KB |
helper.h | -rw-r--r-- | 1.1 KB |
midi.c | -rw-r--r-- | 68.5 KB |
midi.h | -rw-r--r-- | 1.9 KB |
mixer.c | -rw-r--r-- | 70.2 KB |
mixer.h | -rw-r--r-- | 2.9 KB |
mixer_maps.c | -rw-r--r-- | 14.1 KB |
mixer_quirks.c | -rw-r--r-- | 48.4 KB |
mixer_quirks.h | -rw-r--r-- | 523 bytes |
mixer_scarlett.c | -rw-r--r-- | 28.1 KB |
mixer_scarlett.h | -rw-r--r-- | 169 bytes |
pcm.c | -rw-r--r-- | 47.6 KB |
pcm.h | -rw-r--r-- | 379 bytes |
power.h | -rw-r--r-- | 375 bytes |
proc.c | -rw-r--r-- | 6.0 KB |
proc.h | -rw-r--r-- | 211 bytes |
quirks-table.h | -rw-r--r-- | 76.9 KB |
quirks.c | -rw-r--r-- | 40.6 KB |
quirks.h | -rw-r--r-- | 1.3 KB |
stream.c | -rw-r--r-- | 20.7 KB |
stream.h | -rw-r--r-- | 286 bytes |
usbaudio.h | -rw-r--r-- | 3.5 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...