https://github.com/torvalds/linux
Revision 4d59e59cf45046fe1263a935f8abc418bb61215c authored by Ido Schimmel on 21 May 2020, 11:46:17 UTC, committed by David S. Miller on 22 May 2020, 23:05:42 UTC
The variable is used by log_test() to check if the test case completely
successfully or not. In case it is not initialized at the start of a
test case, it is possible for the test case to fail despite not
encountering any errors.

Example:

```
...
TEST: Trap group statistics                                         [ OK ]
TEST: Trap policer                                                  [FAIL]
	Policer drop counter was not incremented
TEST: Trap policer binding                                          [FAIL]
	Policer drop counter was not incremented
```

Failure of trap_policer_test() caused trap_policer_bind_test() to fail
as well.

Fix by adding missing initialization of the variable.

Fixes: 5fbff58e27a1 ("selftests: netdevsim: Add test cases for devlink-trap policers")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent be43224
History
Tip revision: 4d59e59cf45046fe1263a935f8abc418bb61215c authored by Ido Schimmel on 21 May 2020, 11:46:17 UTC
selftests: netdevsim: Always initialize 'RET' variable
Tip revision: 4d59e59

back to top