Revision - 4dcf357 - inference: Don't confuse frames in different interpreters (#53627) - origin: https://github.com/JuliaLang/julia

visit type:

https://github.com/JuliaLang/julia

19 April 2024, 06:28:37 UTC

Revision 4dcf35786ec164832e1eb961c9cdacae7974a27a authored by Keno Fischer on 08 March 2024, 06:26:43 UTC, committed by GitHub on 08 March 2024, 06:26:43 UTC

inference: Don't confuse frames in different interpreters (#53627)

Diffractor's abstract interpreter sometimes needs to do side queries
using the native interpreter. These are pushed onto the regular
inference callstack in anticipation of a future where compiler plugins
may want to recurse from the native interpreter back into the Diffractor
abstract interpreter. However, this introduced a subtle challenge: When
the native interpreter is looking at a frame that is currently on the
inference stack, it would treat them as the same, incorrectly merging
inference across the two abstract interpreters (which have different
semantics and may not be confused). The caches for the two abstract
interpreters were already different, so once things are inferred,
there's no problem (likely because things were already inferred on the
native interpreter), but if not, this could cause subtle and hard to
debug problems.

1 parent 321fb2c

Files
Changes

Permalinks

Tip revision: 4dcf35786ec164832e1eb961c9cdacae7974a27a authored by Keno Fischer on 08 March 2024, 06:26:43 UTC
inference: Don't confuse frames in different interpreters (#53627)

Tip revision: 4dcf357

File	Mode	Size
.devcontainer
.github
base
cli
contrib
deps
doc
etc
src
stdlib
test
.buildkite-external-version	-rw-r--r--	5 bytes
.clang-format	-rw-r--r--	3.3 KB
.clangd	-rw-r--r--	114 bytes
.codecov.yml	-rw-r--r--	52 bytes
.git-blame-ignore-revs	-rw-r--r--	371 bytes
.gitattributes	-rw-r--r--	65 bytes
.gitignore	-rw-r--r--	571 bytes
.mailmap	-rw-r--r--	12.7 KB
CITATION.bib	-rw-r--r--	513 bytes
CITATION.cff	-rw-r--r--	1012 bytes
CONTRIBUTING.md	-rw-r--r--	23.4 KB
HISTORY.md	-rw-r--r--	388.1 KB
LICENSE.md	-rw-r--r--	1.3 KB
Make.inc	-rw-r--r--	56.1 KB
Makefile	-rw-r--r--	30.3 KB
NEWS.md	-rw-r--r--	3.6 KB
README.md	-rw-r--r--	7.4 KB
THIRDPARTY.md	-rw-r--r--	3.9 KB
VERSION	-rw-r--r--	11 bytes
julia.spdx.json	-rw-r--r--	37.8 KB
pkgimage.mk	-rw-r--r--	7.1 KB
sysimage.mk	-rw-r--r--	4.2 KB
typos.toml	-rw-r--r--	78 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/JuliaLang/julia

inference: Don't confuse frames in different interpreters (#53627)

README.md