Revision 4e43e64d0f1332fcc503babad4dc31aead7131ca authored by Eric Dumazet on 28 June 2022, 12:12:48 UTC, committed by Jakub Kicinski on 30 June 2022, 03:41:09 UTC
As reported by syzbot, we should not use rcu_dereference()
when rcu_read_lock() is not held.
WARNING: suspicious RCU usage
5.19.0-rc2-syzkaller #0 Not tainted
net/ipv6/addrconf.c:5175 suspicious rcu_dereference_check() usage!
other info that might help us debug this:
rcu_scheduler_active = 2, debug_locks = 1
1 lock held by syz-executor326/3617:
#0: ffffffff8d5848e8 (rtnl_mutex){+.+.}-{3:3}, at: netlink_dump+0xae/0xc20 net/netlink/af_netlink.c:2223
stack backtrace:
CPU: 0 PID: 3617 Comm: syz-executor326 Not tainted 5.19.0-rc2-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
in6_dump_addrs+0x12d1/0x1790 net/ipv6/addrconf.c:5175
inet6_dump_addr+0x9c1/0xb50 net/ipv6/addrconf.c:5300
netlink_dump+0x541/0xc20 net/netlink/af_netlink.c:2275
__netlink_dump_start+0x647/0x900 net/netlink/af_netlink.c:2380
netlink_dump_start include/linux/netlink.h:245 [inline]
rtnetlink_rcv_msg+0x73e/0xc90 net/core/rtnetlink.c:6046
netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2501
netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
netlink_unicast+0x543/0x7f0 net/netlink/af_netlink.c:1345
netlink_sendmsg+0x917/0xe10 net/netlink/af_netlink.c:1921
sock_sendmsg_nosec net/socket.c:714 [inline]
sock_sendmsg+0xcf/0x120 net/socket.c:734
____sys_sendmsg+0x6eb/0x810 net/socket.c:2492
___sys_sendmsg+0xf3/0x170 net/socket.c:2546
__sys_sendmsg net/socket.c:2575 [inline]
__do_sys_sendmsg net/socket.c:2584 [inline]
__se_sys_sendmsg net/socket.c:2582 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2582
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x46/0xb0
Fixes: 88e2ca308094 ("mld: convert ifmcaddr6 to RCU")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Taehee Yoo <ap420073@gmail.com>
Link: https://lore.kernel.org/r/20220628121248.858695-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent fa152f6
| File | Mode | Size |
|---|---|---|
| agp | ||
| hw_random | ||
| ipmi | ||
| mwave | ||
| pcmcia | ||
| tpm | ||
| xilinx_hwicap | ||
| xillybus | ||
| Kconfig | -rw-r--r-- | 16.2 KB |
| Makefile | -rw-r--r-- | 1.4 KB |
| adi.c | -rw-r--r-- | 4.5 KB |
| apm-emulation.c | -rw-r--r-- | 17.3 KB |
| applicom.c | -rw-r--r-- | 24.1 KB |
| applicom.h | -rw-r--r-- | 2.5 KB |
| bsr.c | -rw-r--r-- | 8.2 KB |
| ds1620.c | -rw-r--r-- | 8.4 KB |
| dsp56k.c | -rw-r--r-- | 12.2 KB |
| dtlk.c | -rw-r--r-- | 16.3 KB |
| hangcheck-timer.c | -rw-r--r-- | 5.1 KB |
| hpet.c | -rw-r--r-- | 23.5 KB |
| lp.c | -rw-r--r-- | 27.4 KB |
| mem.c | -rw-r--r-- | 16.4 KB |
| misc.c | -rw-r--r-- | 6.9 KB |
| mspec.c | -rw-r--r-- | 7.1 KB |
| nsc_gpio.c | -rw-r--r-- | 3.5 KB |
| nvram.c | -rw-r--r-- | 13.5 KB |
| nwbutton.c | -rw-r--r-- | 7.9 KB |
| nwbutton.h | -rw-r--r-- | 1.1 KB |
| nwflash.c | -rw-r--r-- | 12.8 KB |
| pc8736x_gpio.c | -rw-r--r-- | 8.8 KB |
| powernv-op-panel.c | -rw-r--r-- | 5.1 KB |
| ppdev.c | -rw-r--r-- | 20.2 KB |
| ps3flash.c | -rw-r--r-- | 10.0 KB |
| random.c | -rw-r--r-- | 47.2 KB |
| scx200_gpio.c | -rw-r--r-- | 3.1 KB |
| sonypi.c | -rw-r--r-- | 40.4 KB |
| tb0219.c | -rw-r--r-- | 7.1 KB |
| tlclk.c | -rw-r--r-- | 23.3 KB |
| toshiba.c | -rw-r--r-- | 12.4 KB |
| ttyprintk.c | -rw-r--r-- | 5.1 KB |
| uv_mmtimer.c | -rw-r--r-- | 5.5 KB |
| virtio_console.c | -rw-r--r-- | 54.9 KB |
Computing file changes ...
