Revision 4e43e64d0f1332fcc503babad4dc31aead7131ca authored by Eric Dumazet on 28 June 2022, 12:12:48 UTC, committed by Jakub Kicinski on 30 June 2022, 03:41:09 UTC
As reported by syzbot, we should not use rcu_dereference() when rcu_read_lock() is not held. WARNING: suspicious RCU usage 5.19.0-rc2-syzkaller #0 Not tainted net/ipv6/addrconf.c:5175 suspicious rcu_dereference_check() usage! other info that might help us debug this: rcu_scheduler_active = 2, debug_locks = 1 1 lock held by syz-executor326/3617: #0: ffffffff8d5848e8 (rtnl_mutex){+.+.}-{3:3}, at: netlink_dump+0xae/0xc20 net/netlink/af_netlink.c:2223 stack backtrace: CPU: 0 PID: 3617 Comm: syz-executor326 Not tainted 5.19.0-rc2-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 in6_dump_addrs+0x12d1/0x1790 net/ipv6/addrconf.c:5175 inet6_dump_addr+0x9c1/0xb50 net/ipv6/addrconf.c:5300 netlink_dump+0x541/0xc20 net/netlink/af_netlink.c:2275 __netlink_dump_start+0x647/0x900 net/netlink/af_netlink.c:2380 netlink_dump_start include/linux/netlink.h:245 [inline] rtnetlink_rcv_msg+0x73e/0xc90 net/core/rtnetlink.c:6046 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2501 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline] netlink_unicast+0x543/0x7f0 net/netlink/af_netlink.c:1345 netlink_sendmsg+0x917/0xe10 net/netlink/af_netlink.c:1921 sock_sendmsg_nosec net/socket.c:714 [inline] sock_sendmsg+0xcf/0x120 net/socket.c:734 ____sys_sendmsg+0x6eb/0x810 net/socket.c:2492 ___sys_sendmsg+0xf3/0x170 net/socket.c:2546 __sys_sendmsg net/socket.c:2575 [inline] __do_sys_sendmsg net/socket.c:2584 [inline] __se_sys_sendmsg net/socket.c:2582 [inline] __x64_sys_sendmsg+0x132/0x220 net/socket.c:2582 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x46/0xb0 Fixes: 88e2ca308094 ("mld: convert ifmcaddr6 to RCU") Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Taehee Yoo <ap420073@gmail.com> Link: https://lore.kernel.org/r/20220628121248.858695-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent fa152f6
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 36.5 KB |
Makefile | -rw-r--r-- | 6.4 KB |
atmel-quadspi.c | -rw-r--r-- | 19.4 KB |
internals.h | -rw-r--r-- | 1.2 KB |
spi-altera-core.c | -rw-r--r-- | 5.0 KB |
spi-altera-dfl.c | -rw-r--r-- | 5.0 KB |
spi-altera-platform.c | -rw-r--r-- | 4.0 KB |
spi-amd.c | -rw-r--r-- | 8.2 KB |
spi-ar934x.c | -rw-r--r-- | 6.1 KB |
spi-armada-3700.c | -rw-r--r-- | 23.6 KB |
spi-aspeed-smc.c | -rw-r--r-- | 31.5 KB |
spi-at91-usart.c | -rw-r--r-- | 16.6 KB |
spi-ath79.c | -rw-r--r-- | 6.8 KB |
spi-atmel.c | -rw-r--r-- | 43.4 KB |
spi-au1550.c | -rw-r--r-- | 25.2 KB |
spi-axi-spi-engine.c | -rw-r--r-- | 15.0 KB |
spi-bcm-qspi.c | -rw-r--r-- | 44.0 KB |
spi-bcm-qspi.h | -rw-r--r-- | 2.5 KB |
spi-bcm2835.c | -rw-r--r-- | 41.5 KB |
spi-bcm2835aux.c | -rw-r--r-- | 16.7 KB |
spi-bcm63xx-hsspi.c | -rw-r--r-- | 13.9 KB |
spi-bcm63xx.c | -rw-r--r-- | 17.1 KB |
spi-bitbang-txrx.h | -rw-r--r-- | 4.8 KB |
spi-bitbang.c | -rw-r--r-- | 11.1 KB |
spi-brcmstb-qspi.c | -rw-r--r-- | 1011 bytes |
spi-butterfly.c | -rw-r--r-- | 7.7 KB |
spi-cadence-quadspi.c | -rw-r--r-- | 48.3 KB |
spi-cadence-xspi.c | -rw-r--r-- | 18.6 KB |
spi-cadence.c | -rw-r--r-- | 21.0 KB |
spi-cavium-octeon.c | -rw-r--r-- | 2.4 KB |
spi-cavium-thunderx.c | -rw-r--r-- | 2.7 KB |
spi-cavium.c | -rw-r--r-- | 3.5 KB |
spi-cavium.h | -rw-r--r-- | 7.2 KB |
spi-clps711x.c | -rw-r--r-- | 4.1 KB |
spi-coldfire-qspi.c | -rw-r--r-- | 12.6 KB |
spi-davinci.c | -rw-r--r-- | 26.4 KB |
spi-dln2.c | -rw-r--r-- | 20.6 KB |
spi-dw-bt1.c | -rw-r--r-- | 8.6 KB |
spi-dw-core.c | -rw-r--r-- | 26.9 KB |
spi-dw-dma.c | -rw-r--r-- | 16.6 KB |
spi-dw-mmio.c | -rw-r--r-- | 10.1 KB |
spi-dw-pci.c | -rw-r--r-- | 5.0 KB |
spi-dw.h | -rw-r--r-- | 8.6 KB |
spi-ep93xx.c | -rw-r--r-- | 19.1 KB |
spi-falcon.c | -rw-r--r-- | 10.2 KB |
spi-fsi.c | -rw-r--r-- | 13.4 KB |
spi-fsl-cpm.c | -rw-r--r-- | 9.9 KB |
spi-fsl-cpm.h | -rw-r--r-- | 1.4 KB |
spi-fsl-dspi.c | -rw-r--r-- | 35.1 KB |
spi-fsl-espi.c | -rw-r--r-- | 21.1 KB |
spi-fsl-lib.c | -rw-r--r-- | 4.1 KB |
spi-fsl-lib.h | -rw-r--r-- | 3.1 KB |
spi-fsl-lpspi.c | -rw-r--r-- | 23.7 KB |
spi-fsl-qspi.c | -rw-r--r-- | 25.9 KB |
spi-fsl-spi.c | -rw-r--r-- | 21.0 KB |
spi-fsl-spi.h | -rw-r--r-- | 1.8 KB |
spi-geni-qcom.c | -rw-r--r-- | 28.6 KB |
spi-gpio.c | -rw-r--r-- | 13.7 KB |
spi-hisi-kunpeng.c | -rw-r--r-- | 13.9 KB |
spi-hisi-sfc-v3xx.c | -rw-r--r-- | 13.6 KB |
spi-img-spfi.c | -rw-r--r-- | 19.5 KB |
spi-imx.c | -rw-r--r-- | 49.9 KB |
spi-ingenic.c | -rw-r--r-- | 13.6 KB |
spi-intel-pci.c | -rw-r--r-- | 2.8 KB |
spi-intel-platform.c | -rw-r--r-- | 978 bytes |
spi-intel.c | -rw-r--r-- | 33.9 KB |
spi-intel.h | -rw-r--r-- | 441 bytes |
spi-iproc-qspi.c | -rw-r--r-- | 3.8 KB |
spi-jcore.c | -rw-r--r-- | 5.4 KB |
spi-lantiq-ssc.c | -rw-r--r-- | 27.4 KB |
spi-lm70llp.c | -rw-r--r-- | 8.4 KB |
spi-loopback-test.c | -rw-r--r-- | 26.1 KB |
spi-lp8841-rtc.c | -rw-r--r-- | 5.4 KB |
spi-mem.c | -rw-r--r-- | 24.1 KB |
spi-meson-spicc.c | -rw-r--r-- | 22.3 KB |
spi-meson-spifc.c | -rw-r--r-- | 11.0 KB |
spi-mpc512x-psc.c | -rw-r--r-- | 15.6 KB |
spi-mpc52xx-psc.c | -rw-r--r-- | 12.8 KB |
spi-mpc52xx.c | -rw-r--r-- | 14.2 KB |
spi-mt65xx.c | -rw-r--r-- | 36.9 KB |
spi-mt7621.c | -rw-r--r-- | 9.4 KB |
spi-mtk-nor.c | -rw-r--r-- | 24.9 KB |
spi-mtk-snfi.c | -rw-r--r-- | 38.7 KB |
spi-mux.c | -rw-r--r-- | 5.2 KB |
spi-mxic.c | -rw-r--r-- | 21.0 KB |
spi-mxs.c | -rw-r--r-- | 16.0 KB |
spi-npcm-fiu.c | -rw-r--r-- | 21.3 KB |
spi-npcm-pspi.c | -rw-r--r-- | 10.3 KB |
spi-nxp-fspi.c | -rw-r--r-- | 33.3 KB |
spi-oc-tiny.c | -rw-r--r-- | 7.1 KB |
spi-omap-100k.c | -rw-r--r-- | 11.8 KB |
spi-omap-uwire.c | -rw-r--r-- | 12.4 KB |
spi-omap2-mcspi.c | -rw-r--r-- | 40.8 KB |
spi-orion.c | -rw-r--r-- | 21.3 KB |
spi-pic32-sqi.c | -rw-r--r-- | 18.0 KB |
spi-pic32.c | -rw-r--r-- | 22.2 KB |
spi-pl022.c | -rw-r--r-- | 67.0 KB |
spi-ppc4xx.c | -rw-r--r-- | 11.6 KB |
spi-pxa2xx-dma.c | -rw-r--r-- | 6.3 KB |
spi-pxa2xx-pci.c | -rw-r--r-- | 8.9 KB |
spi-pxa2xx.c | -rw-r--r-- | 48.8 KB |
spi-pxa2xx.h | -rw-r--r-- | 3.1 KB |
spi-qcom-qspi.c | -rw-r--r-- | 16.2 KB |
spi-qup.c | -rw-r--r-- | 33.3 KB |
spi-rb4xx.c | -rw-r--r-- | 5.2 KB |
spi-realtek-rtl.c | -rw-r--r-- | 4.6 KB |
spi-rockchip-sfc.c | -rw-r--r-- | 17.1 KB |
spi-rockchip.c | -rw-r--r-- | 27.5 KB |
spi-rpc-if.c | -rw-r--r-- | 5.2 KB |
spi-rspi.c | -rw-r--r-- | 37.1 KB |
spi-s3c24xx-regs.h | -rw-r--r-- | 1.3 KB |
spi-s3c24xx.c | -rw-r--r-- | 13.5 KB |
spi-s3c64xx.c | -rw-r--r-- | 38.9 KB |
spi-sc18is602.c | -rw-r--r-- | 8.1 KB |
spi-sh-hspi.c | -rw-r--r-- | 6.0 KB |
spi-sh-msiof.c | -rw-r--r-- | 38.7 KB |
spi-sh-sci.c | -rw-r--r-- | 4.7 KB |
spi-sh.c | -rw-r--r-- | 11.1 KB |
spi-sifive.c | -rw-r--r-- | 12.8 KB |
spi-slave-mt27xx.c | -rw-r--r-- | 13.7 KB |
spi-slave-system-control.c | -rw-r--r-- | 3.6 KB |
spi-slave-time.c | -rw-r--r-- | 2.9 KB |
spi-sprd-adi.c | -rw-r--r-- | 16.8 KB |
spi-sprd.c | -rw-r--r-- | 26.9 KB |
spi-st-ssc4.c | -rw-r--r-- | 10.4 KB |
spi-stm32-qspi.c | -rw-r--r-- | 21.2 KB |
spi-stm32.c | -rw-r--r-- | 56.9 KB |
spi-sun4i.c | -rw-r--r-- | 13.5 KB |
spi-sun6i.c | -rw-r--r-- | 18.3 KB |
spi-sunplus-sp7021.c | -rw-r--r-- | 17.0 KB |
spi-synquacer.c | -rw-r--r-- | 21.9 KB |
spi-tegra114.c | -rw-r--r-- | 41.5 KB |
spi-tegra20-sflash.c | -rw-r--r-- | 15.7 KB |
spi-tegra20-slink.c | -rw-r--r-- | 33.1 KB |
spi-tegra210-quad.c | -rw-r--r-- | 44.8 KB |
spi-test.h | -rw-r--r-- | 4.9 KB |
spi-ti-qspi.c | -rw-r--r-- | 22.4 KB |
spi-tle62x0.c | -rw-r--r-- | 7.0 KB |
spi-topcliff-pch.c | -rw-r--r-- | 45.1 KB |
spi-uniphier.c | -rw-r--r-- | 19.7 KB |
spi-xcomm.c | -rw-r--r-- | 5.8 KB |
spi-xilinx.c | -rw-r--r-- | 14.4 KB |
spi-xlp.c | -rw-r--r-- | 11.0 KB |
spi-xtensa-xtfpga.c | -rw-r--r-- | 3.7 KB |
spi-zynq-qspi.c | -rw-r--r-- | 22.8 KB |
spi-zynqmp-gqspi.c | -rw-r--r-- | 37.0 KB |
spi.c | -rw-r--r-- | 115.3 KB |
spidev.c | -rw-r--r-- | 22.2 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...