Revision 4e43e64d0f1332fcc503babad4dc31aead7131ca authored by Eric Dumazet on 28 June 2022, 12:12:48 UTC, committed by Jakub Kicinski on 30 June 2022, 03:41:09 UTC
As reported by syzbot, we should not use rcu_dereference()
when rcu_read_lock() is not held.
WARNING: suspicious RCU usage
5.19.0-rc2-syzkaller #0 Not tainted
net/ipv6/addrconf.c:5175 suspicious rcu_dereference_check() usage!
other info that might help us debug this:
rcu_scheduler_active = 2, debug_locks = 1
1 lock held by syz-executor326/3617:
#0: ffffffff8d5848e8 (rtnl_mutex){+.+.}-{3:3}, at: netlink_dump+0xae/0xc20 net/netlink/af_netlink.c:2223
stack backtrace:
CPU: 0 PID: 3617 Comm: syz-executor326 Not tainted 5.19.0-rc2-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
in6_dump_addrs+0x12d1/0x1790 net/ipv6/addrconf.c:5175
inet6_dump_addr+0x9c1/0xb50 net/ipv6/addrconf.c:5300
netlink_dump+0x541/0xc20 net/netlink/af_netlink.c:2275
__netlink_dump_start+0x647/0x900 net/netlink/af_netlink.c:2380
netlink_dump_start include/linux/netlink.h:245 [inline]
rtnetlink_rcv_msg+0x73e/0xc90 net/core/rtnetlink.c:6046
netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2501
netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
netlink_unicast+0x543/0x7f0 net/netlink/af_netlink.c:1345
netlink_sendmsg+0x917/0xe10 net/netlink/af_netlink.c:1921
sock_sendmsg_nosec net/socket.c:714 [inline]
sock_sendmsg+0xcf/0x120 net/socket.c:734
____sys_sendmsg+0x6eb/0x810 net/socket.c:2492
___sys_sendmsg+0xf3/0x170 net/socket.c:2546
__sys_sendmsg net/socket.c:2575 [inline]
__do_sys_sendmsg net/socket.c:2584 [inline]
__se_sys_sendmsg net/socket.c:2582 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2582
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x46/0xb0
Fixes: 88e2ca308094 ("mld: convert ifmcaddr6 to RCU")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Taehee Yoo <ap420073@gmail.com>
Link: https://lore.kernel.org/r/20220628121248.858695-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent fa152f6
| File | Mode | Size |
|---|---|---|
| events | ||
| xen-pciback | ||
| xenbus | ||
| xenfs | ||
| Kconfig | -rw-r--r-- | 11.5 KB |
| Makefile | -rw-r--r-- | 1.7 KB |
| acpi.c | -rw-r--r-- | 2.7 KB |
| arm-device.c | -rw-r--r-- | 4.2 KB |
| balloon.c | -rw-r--r-- | 19.4 KB |
| biomerge.c | -rw-r--r-- | 617 bytes |
| cpu_hotplug.c | -rw-r--r-- | 2.3 KB |
| dbgp.c | -rw-r--r-- | 1.2 KB |
| efi.c | -rw-r--r-- | 8.5 KB |
| evtchn.c | -rw-r--r-- | 16.1 KB |
| features.c | -rw-r--r-- | 1.2 KB |
| gntalloc.c | -rw-r--r-- | 14.8 KB |
| gntdev-common.h | -rw-r--r-- | 2.2 KB |
| gntdev-dmabuf.c | -rw-r--r-- | 20.1 KB |
| gntdev-dmabuf.h | -rw-r--r-- | 943 bytes |
| gntdev.c | -rw-r--r-- | 27.5 KB |
| grant-dma-iommu.c | -rw-r--r-- | 1.7 KB |
| grant-dma-ops.c | -rw-r--r-- | 8.2 KB |
| grant-table.c | -rw-r--r-- | 41.5 KB |
| manage.c | -rw-r--r-- | 8.3 KB |
| mcelog.c | -rw-r--r-- | 10.2 KB |
| mem-reservation.c | -rw-r--r-- | 3.1 KB |
| pci.c | -rw-r--r-- | 7.4 KB |
| pcpu.c | -rw-r--r-- | 8.4 KB |
| platform-pci.c | -rw-r--r-- | 4.1 KB |
| privcmd-buf.c | -rw-r--r-- | 4.1 KB |
| privcmd.c | -rw-r--r-- | 22.4 KB |
| privcmd.h | -rw-r--r-- | 180 bytes |
| pvcalls-back.c | -rw-r--r-- | 29.8 KB |
| pvcalls-front.c | -rw-r--r-- | 32.0 KB |
| pvcalls-front.h | -rw-r--r-- | 826 bytes |
| swiotlb-xen.c | -rw-r--r-- | 11.5 KB |
| sys-hypervisor.c | -rw-r--r-- | 12.5 KB |
| time.c | -rw-r--r-- | 4.2 KB |
| unpopulated-alloc.c | -rw-r--r-- | 5.5 KB |
| xen-acpi-pad.c | -rw-r--r-- | 3.7 KB |
| xen-acpi-processor.c | -rw-r--r-- | 16.9 KB |
| xen-balloon.c | -rw-r--r-- | 7.1 KB |
| xen-front-pgdir-shbuf.c | -rw-r--r-- | 14.2 KB |
| xen-scsiback.c | -rw-r--r-- | 48.4 KB |
| xlate_mmu.c | -rw-r--r-- | 7.8 KB |
Computing file changes ...
