https://github.com/web-platform-tests/wpt
Revision 4e5f09f89e6f1976dd49a57ba46cd447c7e19a1e authored by Alex Moshchuk on 13 April 2018, 15:22:14 UTC, committed by Chromium WPT Sync on 13 April 2018, 15:22:14 UTC
Changes from original attempt at https://crrev.com/c/999182:
- fix flakiness in two additional ChromeOS login tests
- fix CSP WPT tests to not depend on ordering between iframe's onload
  and postMessage - see https://crbug.com/832319.

Previously, we sent the IPC to forward a cross-process postMessage
immediately.  This caused a behavioral difference from the
same-process case where the postMessage is always scheduled.  Namely,
in a scenario like this:

  frame.postMessage(...);
  doSomethingThatSendsIPCsToFrame(frame);

the IPCs from JS following the postMessage would've been ordered
incorrectly, causing |frame| to see their side effects after the
postMessage dispatch in the cross-process case, whereas they would be
seen before the postMessage dispatch in the same-process case.  One
example of this is frame.focus(), and another is a frame element
onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
a postMessage dispatched from an inline script while the frame was
still loading.

To resolve these ordering concerns, this CL changes cross-process
postMessage to do a PostTask on the sender side before sending the
message to the browser process.  This improves the current state of
the world, but does not yet achieve a perfect match for the IPC
ordering in the same-process case - see discussion on the bug.

Bug: 828529
Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
Reviewed-on: https://chromium-review.googlesource.com/999182
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550284}
Reviewed-on: https://chromium-review.googlesource.com/1011287
Cr-Commit-Position: refs/heads/master@{#550621}
1 parent f90d3d6
History
Tip revision: 4e5f09f89e6f1976dd49a57ba46cd447c7e19a1e authored by Alex Moshchuk on 13 April 2018, 15:22:14 UTC
Reland: Use PostTask to schedule cross-process postMessage forwarding.
Tip revision: 4e5f09f
File Mode Size
resources
OWNERS -rw-r--r-- 27 bytes
bounding-box.html -rw-r--r-- 1.6 KB
client-rect.html -rw-r--r-- 1.3 KB
containing-block.html -rw-r--r-- 2.0 KB
cross-origin-iframe.html -rw-r--r-- 1.6 KB
disconnect.html -rw-r--r-- 1.3 KB
display-none.html -rw-r--r-- 1.6 KB
edge-inclusive-intersection.html -rw-r--r-- 1.9 KB
iframe-no-root.html -rw-r--r-- 2.1 KB
multiple-targets.html -rw-r--r-- 2.6 KB
multiple-thresholds.html -rw-r--r-- 3.1 KB
observer-attributes.html -rw-r--r-- 1.1 KB
observer-exceptions.html -rw-r--r-- 1.9 KB
observer-in-iframe.html -rw-r--r-- 209 bytes
observer-without-js-reference.html -rw-r--r-- 1.2 KB
remove-element.html -rw-r--r-- 2.2 KB
root-margin.html -rw-r--r-- 2.6 KB
same-document-no-root.html -rw-r--r-- 1.7 KB
same-document-root.html -rw-r--r-- 2.6 KB
same-document-zero-size-target.html -rw-r--r-- 1.6 KB
shadow-content.html -rw-r--r-- 1.3 KB
timestamp.html -rw-r--r-- 3.8 KB
unclipped-root.html -rw-r--r-- 1.5 KB
zero-area-element-hidden.html -rw-r--r-- 1.1 KB
zero-area-element-visible.html -rw-r--r-- 1.1 KB

back to top