https://github.com/web-platform-tests/wpt
Revision 4e5f09f89e6f1976dd49a57ba46cd447c7e19a1e authored by Alex Moshchuk on 13 April 2018, 15:22:14 UTC, committed by Chromium WPT Sync on 13 April 2018, 15:22:14 UTC
Changes from original attempt at https://crrev.com/c/999182:
- fix flakiness in two additional ChromeOS login tests
- fix CSP WPT tests to not depend on ordering between iframe's onload
  and postMessage - see https://crbug.com/832319.

Previously, we sent the IPC to forward a cross-process postMessage
immediately.  This caused a behavioral difference from the
same-process case where the postMessage is always scheduled.  Namely,
in a scenario like this:

  frame.postMessage(...);
  doSomethingThatSendsIPCsToFrame(frame);

the IPCs from JS following the postMessage would've been ordered
incorrectly, causing |frame| to see their side effects after the
postMessage dispatch in the cross-process case, whereas they would be
seen before the postMessage dispatch in the same-process case.  One
example of this is frame.focus(), and another is a frame element
onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
a postMessage dispatched from an inline script while the frame was
still loading.

To resolve these ordering concerns, this CL changes cross-process
postMessage to do a PostTask on the sender side before sending the
message to the browser process.  This improves the current state of
the world, but does not yet achieve a perfect match for the IPC
ordering in the same-process case - see discussion on the bug.

Bug: 828529
Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
Reviewed-on: https://chromium-review.googlesource.com/999182
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550284}
Reviewed-on: https://chromium-review.googlesource.com/1011287
Cr-Commit-Position: refs/heads/master@{#550621}
1 parent f90d3d6
History
Tip revision: 4e5f09f89e6f1976dd49a57ba46cd447c7e19a1e authored by Alex Moshchuk on 13 April 2018, 15:22:14 UTC
Reland: Use PostTask to schedule cross-process postMessage forwarding.
Tip revision: 4e5f09f
File Mode Size
mp4
webm
OWNERS -rw-r--r-- 22 bytes
SourceBuffer-abort-readyState.html -rw-r--r-- 2.4 KB
SourceBuffer-abort-removed.html -rw-r--r-- 1.8 KB
SourceBuffer-abort-updating.html -rw-r--r-- 3.5 KB
SourceBuffer-abort.html -rw-r--r-- 1.2 KB
URL-createObjectURL-null.html -rw-r--r-- 428 bytes
URL-createObjectURL-revoke.html -rw-r--r-- 2.4 KB
URL-createObjectURL.html -rw-r--r-- 551 bytes
generate-config-change-tests.py -rwxr-xr-x 9.4 KB
import_tests.sh -rwxr-xr-x 1.2 KB
interfaces.html -rw-r--r-- 4.6 KB
manifest.txt -rw-r--r-- 2.0 KB
mediasource-activesourcebuffers.html -rw-r--r-- 13.6 KB
mediasource-addsourcebuffer-mode.html -rw-r--r-- 1.4 KB
mediasource-addsourcebuffer.html -rw-r--r-- 7.3 KB
mediasource-append-buffer.html -rw-r--r-- 29.1 KB
mediasource-appendbuffer-quota-exceeded.html -rw-r--r-- 2.2 KB
mediasource-appendwindow.html -rw-r--r-- 9.0 KB
mediasource-attach-stops-delaying-load-event.html -rw-r--r-- 2.3 KB
mediasource-avtracks.html -rw-r--r-- 7.3 KB
mediasource-buffered.html -rw-r--r-- 11.6 KB
mediasource-closed.html -rw-r--r-- 6.3 KB
mediasource-config-change-mp4-a-bitrate.html -rw-r--r-- 713 bytes
mediasource-config-change-mp4-av-audio-bitrate.html -rw-r--r-- 800 bytes
mediasource-config-change-mp4-av-framesize.html -rw-r--r-- 799 bytes
mediasource-config-change-mp4-av-video-bitrate.html -rw-r--r-- 799 bytes
mediasource-config-change-mp4-v-bitrate.html -rw-r--r-- 729 bytes
mediasource-config-change-mp4-v-framerate.html -rw-r--r-- 734 bytes
mediasource-config-change-mp4-v-framesize.html -rw-r--r-- 735 bytes
mediasource-config-change-webm-a-bitrate.html -rw-r--r-- 716 bytes
mediasource-config-change-webm-av-audio-bitrate.html -rw-r--r-- 803 bytes
mediasource-config-change-webm-av-framesize.html -rw-r--r-- 802 bytes
mediasource-config-change-webm-av-video-bitrate.html -rw-r--r-- 802 bytes
mediasource-config-change-webm-v-bitrate.html -rw-r--r-- 732 bytes
mediasource-config-change-webm-v-framerate.html -rw-r--r-- 737 bytes
mediasource-config-change-webm-v-framesize.html -rw-r--r-- 738 bytes
mediasource-config-changes.js -rw-r--r-- 4.6 KB
mediasource-detach.html -rw-r--r-- 2.3 KB
mediasource-duration-boundaryconditions.html -rw-r--r-- 3.6 KB
mediasource-duration.html -rw-r--r-- 20.8 KB
mediasource-endofstream-invaliderror.html -rw-r--r-- 2.3 KB
mediasource-endofstream.html -rw-r--r-- 3.6 KB
mediasource-errors.html -rw-r--r-- 11.3 KB
mediasource-getvideoplaybackquality.html -rw-r--r-- 5.9 KB
mediasource-is-type-supported.html -rw-r--r-- 3.2 KB
mediasource-liveseekable.html -rw-r--r-- 6.1 KB
mediasource-multiple-attach.html -rw-r--r-- 5.1 KB
mediasource-play-then-seek-back.html -rw-r--r-- 2.2 KB
mediasource-play.html -rw-r--r-- 2.5 KB
mediasource-preload.html -rw-r--r-- 3.0 KB
mediasource-redundant-seek.html -rw-r--r-- 3.7 KB
mediasource-remove.html -rw-r--r-- 12.5 KB
mediasource-removesourcebuffer.html -rw-r--r-- 7.9 KB
mediasource-seek-beyond-duration.html -rw-r--r-- 5.1 KB
mediasource-seek-during-pending-seek.html -rw-r--r-- 9.2 KB
mediasource-seekable.html -rw-r--r-- 3.7 KB
mediasource-sequencemode-append-buffer.html -rw-r--r-- 8.8 KB
mediasource-sourcebuffer-mode-timestamps.html -rw-r--r-- 1.7 KB
mediasource-sourcebuffer-mode.html -rw-r--r-- 7.4 KB
mediasource-sourcebuffer-trackdefaults.html -rw-r--r-- 3.9 KB
mediasource-sourcebufferlist.html -rw-r--r-- 4.5 KB
mediasource-timestamp-offset.html -rw-r--r-- 5.8 KB
mediasource-trackdefault.html -rw-r--r-- 4.4 KB
mediasource-trackdefaultlist.html -rw-r--r-- 3.9 KB
mediasource-util.js -rw-r--r-- 15.1 KB

back to top