https://github.com/web-platform-tests/wpt
Revision 4e5f09f89e6f1976dd49a57ba46cd447c7e19a1e authored by Alex Moshchuk on 13 April 2018, 15:22:14 UTC, committed by Chromium WPT Sync on 13 April 2018, 15:22:14 UTC
Changes from original attempt at https://crrev.com/c/999182:
- fix flakiness in two additional ChromeOS login tests
- fix CSP WPT tests to not depend on ordering between iframe's onload
  and postMessage - see https://crbug.com/832319.

Previously, we sent the IPC to forward a cross-process postMessage
immediately.  This caused a behavioral difference from the
same-process case where the postMessage is always scheduled.  Namely,
in a scenario like this:

  frame.postMessage(...);
  doSomethingThatSendsIPCsToFrame(frame);

the IPCs from JS following the postMessage would've been ordered
incorrectly, causing |frame| to see their side effects after the
postMessage dispatch in the cross-process case, whereas they would be
seen before the postMessage dispatch in the same-process case.  One
example of this is frame.focus(), and another is a frame element
onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
a postMessage dispatched from an inline script while the frame was
still loading.

To resolve these ordering concerns, this CL changes cross-process
postMessage to do a PostTask on the sender side before sending the
message to the browser process.  This improves the current state of
the world, but does not yet achieve a perfect match for the IPC
ordering in the same-process case - see discussion on the bug.

Bug: 828529
Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
Reviewed-on: https://chromium-review.googlesource.com/999182
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550284}
Reviewed-on: https://chromium-review.googlesource.com/1011287
Cr-Commit-Position: refs/heads/master@{#550621}
1 parent f90d3d6
History
Tip revision: 4e5f09f89e6f1976dd49a57ba46cd447c7e19a1e authored by Alex Moshchuk on 13 April 2018, 15:22:14 UTC
Reland: Use PostTask to schedule cross-process postMessage forwarding.
Tip revision: 4e5f09f
File Mode Size
leaktests
reference
resources
untriaged
Document-prototype-adoptNode.html -rw-r--r-- 1.0 KB
Document-prototype-currentScript.html -rw-r--r-- 4.2 KB
Document-prototype-importNode.html -rw-r--r-- 1.1 KB
DocumentOrShadowRoot-prototype-elementFromPoint.html -rw-r--r-- 12.5 KB
Element-interface-attachShadow-custom-element.html -rw-r--r-- 1.1 KB
Element-interface-attachShadow.html -rw-r--r-- 5.3 KB
Element-interface-shadowRoot-attribute.html -rw-r--r-- 2.6 KB
Extensions-to-Event-Interface.html -rw-r--r-- 11.3 KB
HTMLSlotElement-interface.html -rw-r--r-- 16.1 KB
MouseEvent-prototype-offsetX-offsetY.html -rw-r--r-- 6.9 KB
Node-prototype-cloneNode.html -rw-r--r-- 2.5 KB
OWNERS -rw-r--r-- 44 bytes
Range-prototype-insertNode.html -rw-r--r-- 635 bytes
ShadowRoot-interface.html -rw-r--r-- 6.0 KB
Slotable-interface.html -rw-r--r-- 4.5 KB
event-composed-path-after-dom-mutation.html -rw-r--r-- 1.9 KB
event-composed-path-with-related-target.html -rw-r--r-- 11.8 KB
event-composed-path.html -rw-r--r-- 9.9 KB
event-composed.html -rw-r--r-- 2.9 KB
event-inside-shadow-tree.html -rw-r--r-- 7.4 KB
event-inside-slotted-node.html -rw-r--r-- 14.4 KB
event-post-dispatch.html -rw-r--r-- 8.4 KB
event-with-related-target.html -rw-r--r-- 12.6 KB
historical.html -rw-r--r-- 767 bytes
layout-slot-no-longer-assigned.html -rw-r--r-- 555 bytes
layout-slot-no-longer-fallback.html -rw-r--r-- 541 bytes
scroll-to-the-fragment-in-shadow-tree.html -rw-r--r-- 6.0 KB
slotchange-customelements.html -rw-r--r-- 1.9 KB
slotchange-event.html -rw-r--r-- 23.5 KB
slotchange.html -rw-r--r-- 6.3 KB
slots-fallback-in-document.html -rw-r--r-- 1.6 KB
slots-fallback.html -rw-r--r-- 8.0 KB
slots.html -rw-r--r-- 15.4 KB

back to top