https://github.com/web-platform-tests/wpt
Revision 4e5f09f89e6f1976dd49a57ba46cd447c7e19a1e authored by Alex Moshchuk on 13 April 2018, 15:22:14 UTC, committed by Chromium WPT Sync on 13 April 2018, 15:22:14 UTC
Changes from original attempt at https://crrev.com/c/999182:
- fix flakiness in two additional ChromeOS login tests
- fix CSP WPT tests to not depend on ordering between iframe's onload
  and postMessage - see https://crbug.com/832319.

Previously, we sent the IPC to forward a cross-process postMessage
immediately.  This caused a behavioral difference from the
same-process case where the postMessage is always scheduled.  Namely,
in a scenario like this:

  frame.postMessage(...);
  doSomethingThatSendsIPCsToFrame(frame);

the IPCs from JS following the postMessage would've been ordered
incorrectly, causing |frame| to see their side effects after the
postMessage dispatch in the cross-process case, whereas they would be
seen before the postMessage dispatch in the same-process case.  One
example of this is frame.focus(), and another is a frame element
onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
a postMessage dispatched from an inline script while the frame was
still loading.

To resolve these ordering concerns, this CL changes cross-process
postMessage to do a PostTask on the sender side before sending the
message to the browser process.  This improves the current state of
the world, but does not yet achieve a perfect match for the IPC
ordering in the same-process case - see discussion on the bug.

Bug: 828529
Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
Reviewed-on: https://chromium-review.googlesource.com/999182
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550284}
Reviewed-on: https://chromium-review.googlesource.com/1011287
Cr-Commit-Position: refs/heads/master@{#550621}
1 parent f90d3d6
History
Tip revision: 4e5f09f89e6f1976dd49a57ba46cd447c7e19a1e authored by Alex Moshchuk on 13 April 2018, 15:22:14 UTC
Reland: Use PostTask to schedule cross-process postMessage forwarding.
Tip revision: 4e5f09f
File Mode Size
tools
OWNERS -rw-r--r-- 71 bytes
alternate.css -rw-r--r-- 34 bytes
crossorigin-anon-script.js -rw-r--r-- 29 bytes
crossorigin-anon-script.js.headers -rw-r--r-- 31 bytes
crossorigin-anon-style.css -rw-r--r-- 37 bytes
crossorigin-anon-style.css.headers -rw-r--r-- 31 bytes
crossorigin-creds-script.js -rw-r--r-- 30 bytes
crossorigin-creds-script.js.sub.headers -rw-r--r-- 123 bytes
crossorigin-creds-style.css -rw-r--r-- 37 bytes
crossorigin-creds-style.css.sub.headers -rw-r--r-- 123 bytes
crossorigin-ineligible-script.js -rw-r--r-- 35 bytes
crossorigin-ineligible-style.css -rw-r--r-- 37 bytes
ed25519-broken-signature.js -rw-r--r-- 39 bytes
ed25519-broken-signature.js.headers -rw-r--r-- 108 bytes
ed25519-multi-signature-headers.js -rw-r--r-- 24 bytes
ed25519-multi-signature-headers.js.headers -rw-r--r-- 191 bytes
ed25519-multi-signature.js -rw-r--r-- 24 bytes
ed25519-multi-signature.js.headers -rw-r--r-- 158 bytes
ed25519-multi-signature2.js -rw-r--r-- 24 bytes
ed25519-multi-signature2.js.headers -rw-r--r-- 160 bytes
ed25519-no-signature.js -rw-r--r-- 27 bytes
ed25519-signature.js -rw-r--r-- 24 bytes
ed25519-signature.js.headers -rw-r--r-- 108 bytes
ed25519-signature2.js -rw-r--r-- 24 bytes
ed25519-signature2.js.headers -rw-r--r-- 108 bytes
ed25519-style-multi-signature-headers.css -rw-r--r-- 37 bytes
ed25519-style-multi-signature-headers.css.headers -rw-r--r-- 191 bytes
ed25519-style-multi-signature.css -rw-r--r-- 37 bytes
ed25519-style-multi-signature.css.headers -rw-r--r-- 158 bytes
ed25519-style-multi-signature2.css -rw-r--r-- 37 bytes
ed25519-style-multi-signature2.css.headers -rw-r--r-- 160 bytes
ed25519-style-no-signature.css -rw-r--r-- 37 bytes
ed25519-style-wrong-signature.css -rw-r--r-- 37 bytes
ed25519-style-wrong-signature.css.headers -rw-r--r-- 108 bytes
ed25519-style.css -rw-r--r-- 37 bytes
ed25519-style.css.headers -rw-r--r-- 109 bytes
matching-digest.js -rw-r--r-- 21 bytes
non-matching-digest.js -rw-r--r-- 25 bytes
style.css -rw-r--r-- 37 bytes
subresource-css-ed25519.tentative.html -rw-r--r-- 3.4 KB
subresource-ed25519-with-csp.tentative.html -rw-r--r-- 1.9 KB
subresource-ed25519.tentative.html -rw-r--r-- 2.7 KB
subresource-integrity.sub.html -rw-r--r-- 14.5 KB

back to top