Revision 4e5f09f89e6f1976dd49a57ba46cd447c7e19a1e authored by Alex Moshchuk on 13 April 2018, 15:22:14 UTC, committed by Chromium WPT Sync on 13 April 2018, 15:22:14 UTC
Changes from original attempt at https://crrev.com/c/999182:
- fix flakiness in two additional ChromeOS login tests
- fix CSP WPT tests to not depend on ordering between iframe's onload
  and postMessage - see https://crbug.com/832319.

Previously, we sent the IPC to forward a cross-process postMessage
immediately.  This caused a behavioral difference from the
same-process case where the postMessage is always scheduled.  Namely,
in a scenario like this:

  frame.postMessage(...);
  doSomethingThatSendsIPCsToFrame(frame);

the IPCs from JS following the postMessage would've been ordered
incorrectly, causing |frame| to see their side effects after the
postMessage dispatch in the cross-process case, whereas they would be
seen before the postMessage dispatch in the same-process case.  One
example of this is frame.focus(), and another is a frame element
onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
a postMessage dispatched from an inline script while the frame was
still loading.

To resolve these ordering concerns, this CL changes cross-process
postMessage to do a PostTask on the sender side before sending the
message to the browser process.  This improves the current state of
the world, but does not yet achieve a perfect match for the IPC
ordering in the same-process case - see discussion on the bug.

Bug: 828529
Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
Reviewed-on: https://chromium-review.googlesource.com/999182
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550284}
Reviewed-on: https://chromium-review.googlesource.com/1011287
Cr-Commit-Position: refs/heads/master@{#550621}
1 parent f90d3d6
History
File Mode Size
ahem.md -rw-r--r-- 2.8 KB
assumptions.md -rw-r--r-- 1.7 KB
css-metadata.md -rw-r--r-- 5.0 KB
css-user-styles.md -rw-r--r-- 2.4 KB
file-names.md -rw-r--r-- 1.8 KB
general-guidelines.md -rw-r--r-- 7.1 KB
idlharness.md -rw-r--r-- 6.0 KB
index.md -rw-r--r-- 2.9 KB
lint-tool.md -rw-r--r-- 6.6 KB
manual.md -rw-r--r-- 3.0 KB
reftests.md -rw-r--r-- 6.9 KB
rendering.md -rw-r--r-- 3.5 KB
server-features.md -rw-r--r-- 3.4 KB
submission-process.md -rw-r--r-- 1.9 KB
testdriver.md -rw-r--r-- 2.0 KB
testharness-api.md -rw-r--r-- 27.6 KB
testharness.md -rw-r--r-- 4.0 KB
visual.md -rw-r--r-- 1.2 KB

back to top