Revision 4e5f09f89e6f1976dd49a57ba46cd447c7e19a1e authored by Alex Moshchuk on 13 April 2018, 15:22:14 UTC, committed by Chromium WPT Sync on 13 April 2018, 15:22:14 UTC
Changes from original attempt at https://crrev.com/c/999182:
- fix flakiness in two additional ChromeOS login tests
- fix CSP WPT tests to not depend on ordering between iframe's onload
and postMessage - see https://crbug.com/832319.
Previously, we sent the IPC to forward a cross-process postMessage
immediately. This caused a behavioral difference from the
same-process case where the postMessage is always scheduled. Namely,
in a scenario like this:
frame.postMessage(...);
doSomethingThatSendsIPCsToFrame(frame);
the IPCs from JS following the postMessage would've been ordered
incorrectly, causing |frame| to see their side effects after the
postMessage dispatch in the cross-process case, whereas they would be
seen before the postMessage dispatch in the same-process case. One
example of this is frame.focus(), and another is a frame element
onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
a postMessage dispatched from an inline script while the frame was
still loading.
To resolve these ordering concerns, this CL changes cross-process
postMessage to do a PostTask on the sender side before sending the
message to the browser process. This improves the current state of
the world, but does not yet achieve a perfect match for the IPC
ordering in the same-process case - see discussion on the bug.
Bug: 828529
Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
Reviewed-on: https://chromium-review.googlesource.com/999182
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550284}
Reviewed-on: https://chromium-review.googlesource.com/1011287
Cr-Commit-Position: refs/heads/master@{#550621}
1 parent f90d3d6
index.html
---
layout: page
---
<nav class="home">
<ul>
<li>
<a href="{{ site.baseurl }}{% link introduction.md %}">
<div>
{% include svg/octicons/tools.svg %}
</div>
<h2>
Introduction
</h2>
</a>
<p>You should probably start here! Contains a high-level
overview of the testsuite and how to get set up locally.</p>
</li>
<li>
<a href="{{ site.baseurl }}{% link _writing-tests/index.md %}">
<div>
{% include svg/octicons/pencil.svg %}
</div>
<h2>
Writing Tests
</h2>
</a>
<p>Guidelines and advice for those writing tests.</p>
</li>
<li>
<a href="{{ site.baseurl }}{% link _running-tests/index.md %}">
<div>
{% include svg/triangle-right.svg %}
</div>
<h2>
Running Tests
</h2>
</a>
<p>How to run tests, either those you just wrote or those that
already exist.</p>
</li>
<li>
<a href="{{ site.baseurl }}{% link _reviewing-tests/index.md %}">
<div>
{% include svg/octicons/git-pull-request.svg %}
</div>
<h2>
Reviewing Tests
</h2>
</a>
<p>Some hints and tips for those reviewing tests.</p>
</li>
<li>
<a href="{{ site.baseurl }}{% link _appendix/index.md %}">
<div>
{% include svg/octicons/package.svg %}
</div>
<h2>
Appendices
</h2>
</a>
<p>A load of other useful resources.</p>
</li>
</ul>
</nav>
Computing file changes ...
