| 4f87691 | Ethan Buchman | 19 January 2019, 21:08:57 UTC | [types] hash of ConsensusParams includes only a subset of fields (#3165) * types: dont hash entire ConsensusParams * update encoding spec * update blockchain spec * spec: consensus params hash * changelog | 19 January 2019, 21:08:57 UTC |
| 40c887b | Ismail Khoffi | 19 January 2019, 20:55:08 UTC | Normalize priorities to not exceed total voting power (#3049) * more proposer priority tests - test that we don't reset to zero when updating / adding - test that same power validators alternate * add another test to track / simulate similar behaviour as in #2960 * address some of Chris' review comments * address some more of Chris' review comments * temporarily pushing branch with the following changes: The total power might change if: - a validator is added - a validator is removed - a validator is updated Decrement the accums (of all validators) directly after any of these events (by the inverse of the change) * Fix 2960 by re-normalizing / scaling priorities to be in bounds of total power, additionally: - remove heap where it doesn't make sense - avg. only at the end of IncrementProposerPriority instead of each iteration - update (and slightly improve) TestAveragingInIncrementProposerPriorityWithVotingPower to reflect above changes * Fix 2960 by re-normalizing / scaling priorities to be in bounds of total power, additionally: - remove heap where it doesn't make sense - avg. only at the end of IncrementProposerPriority instead of each iteration - update (and slightly improve) TestAveragingInIncrementProposerPriorityWithVotingPower to reflect above changes * fix tests * add comment * update changelog pending & some minor changes * comment about division will floor the result & fix typo * Update TestLargeGenesisValidator: - remove TODO and increase large genesis validator's voting power accordingly * move changelog entry to P2P Protocol * Ceil instead of flooring when dividing & update test * quickly fix failing TestProposerPriorityDoesNotGetResetToZero: - divide by Ceil((maxPriority - minPriority) / 2*totalVotingPower) * fix typo: rename getValWitMostPriority -> getValWithMostPriority * test proposer frequencies * return absolute value for diff. keep testing * use for loop for div * cleanup, more tests * spellcheck * get rid of using floats: manually ceil where necessary * Remove float, simplify, fix tests to match chris's proof (#3157) | 19 January 2019, 20:55:08 UTC |
| d3e8889 | Ethan Buchman | 19 January 2019, 19:08:41 UTC | update btcd fork for v0.1.1 (#3164) * update btcd fork for v0.1.1 * changelog | 19 January 2019, 19:08:41 UTC |
| d17969e | Ethan Buchman | 18 January 2019, 17:39:21 UTC | Merge pull request #3154 from tendermint/master Merge master back to develop | 18 January 2019, 17:39:21 UTC |
| 0726329 | Ethan Buchman | 18 January 2019, 17:38:48 UTC | Merge pull request #3153 from tendermint/release/v0.28.1 Release/v0.28.1 | 18 January 2019, 17:38:48 UTC |
| 5a2e69d | Ethan Buchman | 18 January 2019, 17:11:02 UTC | changelog and version | 18 January 2019, 17:11:02 UTC |
| f5f1416 | bradyjoestar | 18 January 2019, 08:09:12 UTC | json2wal: increase reader's buffer size (#3147) ``` panic: failed to unmarshal json: unexpected end of JSON input goroutine 1 [running]: main.main() /root/gelgo/src/github.com/tendermint/tendermint/scripts/json2wal/main.go:66 +0x73f ``` Closes #3146 | 18 January 2019, 08:09:12 UTC |
| 4d36647 | Henry Harder | 18 January 2019, 07:46:34 UTC | Add ParadigmCore to ecosystem.json (#3145) Adding the OrderStream network client (alpha), ParadigmCore, to the `ecosystem.json` file. | 18 January 2019, 07:46:34 UTC |
| 8fd8f80 | Ethan Buchman | 18 January 2019, 02:46:40 UTC | Bucky/fix evidence halt (#34) * consensus: createProposalBlock function * blockExecutor.CreateProposalBlock - factored out of consensus pkg into a method on blockExec - new private interfaces for mempool ("txNotifier") and evpool with one function each - consensus tests still require more mempool methods * failing test for CreateProposalBlock * Fix bug in include evidece into block * evidence: change maxBytes to maxSize * MaxEvidencePerBlock - changed to return both the max number and the max bytes - preparation for #2590 * changelog * fix linter * Fix from review Co-Authored-By: ebuchman <ethan@coinculture.info> | 18 January 2019, 02:46:40 UTC |
| 8799105 | Anton Kaliaev | 17 January 2019, 13:42:57 UTC | docs: fix RPC links (#3141) | 17 January 2019, 13:42:57 UTC |
| c69dbb2 | Thane Thomson | 17 January 2019, 13:10:56 UTC | Consolidates deadline tests for privval Unix/TCP (#3143) * Consolidates deadline tests for privval Unix/TCP Following on from #3115 and #3132, this converts fundamental timeout errors from the client's `acceptConnection()` method so that these can be detected by the test for the TCP connection. Timeout deadlines are now tested for both TCP and Unix domain socket connections. There is also no need for the additional secret connection code: the connection will time out at the `acceptConnection()` phase for TCP connections, and will time out when attempting to obtain the `RemoteSigner`'s public key for Unix domain socket connections. * Removes extraneous logging * Adds IsConnTimeout helper function This commit adds a helper function to detect whether an error is either a fundamental networking timeout error, or an `ErrConnTimeout` error specific to the `RemoteSigner` class. * Adds a test for the IsConnTimeout() helper function * Separates tests logically for IsConnTimeout | 17 January 2019, 13:10:56 UTC |
| bc88740 | Gautham Santhosh | 17 January 2019, 11:30:51 UTC | docs: fix broken link (#3142) | 17 January 2019, 11:30:51 UTC |
| 55d7238 | Dev Ojha | 16 January 2019, 21:03:19 UTC | Add comment to simple_merkle get_split_point (#3136) * Add comment to simple_merkle get_split_point * fix grammar error | 16 January 2019, 21:03:19 UTC |
| 4a037f9 | Ethan Buchman | 16 January 2019, 21:02:51 UTC | Merge pull request #3138 from tendermint/master Merge master back to develop | 16 January 2019, 21:02:51 UTC |
| aa40cfc | Ethan Buchman | 16 January 2019, 21:01:58 UTC | Merge pull request #3135 from tendermint/release/v0.28.0 Release/v0.28.0 | 16 January 2019, 21:01:58 UTC |
| 6d6d103 | Ethan Buchman | 16 January 2019, 18:41:37 UTC | fixes from review (#3137) | 16 January 2019, 18:41:37 UTC |
| 239ebe2 | Ethan Buchman | 16 January 2019, 15:21:15 UTC | fix changelog fmt (#3134) | 16 January 2019, 15:21:15 UTC |
| 0cba0e1 | Ethan Buchman | 16 January 2019, 15:16:23 UTC | update changelog and upgrading (#3133) | 16 January 2019, 15:16:23 UTC |
| d4e6720 | Thane Thomson | 16 January 2019, 15:05:34 UTC | Expanding tests to cover Unix sockets version of client (#3132) * Adds a random suffix to temporary Unix sockets during testing * Adds Unix domain socket tests for client (FAILING) This adds Unix domain socket tests for the privval client. Right now, one of the tests (TestRemoteSignerRetry) fails, probably because the Unix domain socket state is known instantaneously on both sides by the OS. Committing this to collaborate on the error. * Removes extraneous logging * Completes testing of Unix sockets client version This completes the testing of the client connecting via Unix sockets. There are two specific tests (TestSocketPVDeadline and TestRemoteSignerRetryTCPOnly) that are only relevant to TCP connections. * Renames test to show TCP-specificity * Adds testing into closures for consistency (forgot previously) * Moves test specific to RemoteSigner into own file As per discussion on #3132, `TestRemoteSignerRetryTCPOnly` doesn't really belong with the client tests. This moves it into its own file related to the `RemoteSigner` class. | 16 January 2019, 15:05:34 UTC |
| dcb8f88 | Anton Kaliaev | 15 January 2019, 17:16:33 UTC | add "chain_id" label for all metrics (#3123) * add "chain_id" label for all metrics Refs #3082 * fix labels extraction | 15 January 2019, 17:16:33 UTC |
| a2a62c9 | Thane Thomson | 15 January 2019, 16:17:50 UTC | Merge pull request #3121 from thanethomson/release/v0.28.0 Adds tests for Unix sockets | 15 January 2019, 16:17:50 UTC |
| 3191ee8 | Thane Thomson | 15 January 2019, 16:06:57 UTC | Dropping "construct" prefix as per #3121 | 15 January 2019, 16:06:57 UTC |
| 308b7e3 | Thane Thomson | 15 January 2019, 15:58:33 UTC | Merge branch 'release/v0.28.0' into release/v0.28.0 | 15 January 2019, 15:58:33 UTC |
| 73ea5ef | Kunal Dhariwal | 15 January 2019, 13:12:35 UTC | docs: update link for rpc docs (#3129) | 15 January 2019, 13:12:35 UTC |
| d1afa0e | Ethan Buchman | 15 January 2019, 12:55:57 UTC | privval: fixes from review (#3126) https://github.com/tendermint/tendermint/pull/2923#pullrequestreview-192065694 | 15 January 2019, 12:55:57 UTC |
| ca00cd6 | Thane Thomson | 15 January 2019, 08:14:41 UTC | Make privval listener testing generic This cuts out two tests by constructing test cases and iterating through them, rather than having separate sets of tests for TCP and Unix listeners. This is as per the feedback from #3121. | 15 January 2019, 08:14:41 UTC |
| 4daca1a | Anton Kaliaev | 14 January 2019, 22:35:31 UTC | return maxPerPage (not defaultPerPage) if per_page is greater than max (#3124) it's more user-friendly. Refs #3065 | 14 January 2019, 22:35:31 UTC |
| bc00a03 | Anton Kaliaev | 14 January 2019, 22:33:33 UTC | makefile: fix build-docker-localnode target (#3122) cd does not work because it's executed in a subprocess so it has to be either chained by && or ; See https://stackoverflow.com/q/1789594/820520 for more details. Fixes #3058 | 14 January 2019, 22:33:33 UTC |
| 5f4d8e0 | Anton Kaliaev | 14 January 2019, 19:10:13 UTC | [log] fix year format (#3125) Refs #3060 | 14 January 2019, 19:10:13 UTC |
| 7b2c4bb | Ethan Buchman | 14 January 2019, 16:53:43 UTC | update ADR-020 (#3116) | 14 January 2019, 16:53:43 UTC |
| 5f93220 | Thane Thomson | 14 January 2019, 09:41:09 UTC | Adds tests for Unix sockets As per #3115, adds simple Unix socket connect/accept deadline tests in pretty much the same way as the TCP connect/accept deadline tests work. | 14 January 2019, 09:41:09 UTC |
| ec53ce3 | Dev Ojha | 13 January 2019, 23:02:38 UTC | Simple merkle rfc compatibility (#2713) * Begin simple merkle compatibility PR * Fix query_test * Use trillian test vectors * Change the split point per RFC 6962 * update spec * refactor innerhash to match spec * Update changelog * Address @liamsi's comments * Write the comment requested by @liamsi | 13 January 2019, 23:02:38 UTC |
| 1f68318 | Ismail Khoffi | 13 January 2019, 22:56:36 UTC | fix order of BlockID and Timestamp in Vote and Proposal (#3078) * Consistent order fields of Timestamp/BlockID fields in CanonicalVote and CanonicalProposal * update spec too * Introduce and use IsZero & IsComplete: - update IsZero method according to spec and introduce IsComplete - use methods in validate basic to validate: proposals come with a "complete" blockId and votes are either complete or empty - update spec: BlockID.IsNil() -> BlockID.IsZero() and fix typo * BlockID comes first * fix tests | 13 January 2019, 22:56:36 UTC |
| 1ccc091 | Ismail Khoffi | 13 January 2019, 22:40:50 UTC | More ProposerPriority tests (#2966) * more proposer priority tests - test that we don't reset to zero when updating / adding - test that same power validators alternate * add another test to track / simulate similar behaviour as in #2960 * address some of Chris' review comments * address some more of Chris' review comments | 13 January 2019, 22:40:50 UTC |
| fc031d9 | Ethan Buchman | 13 January 2019, 22:15:34 UTC | Bucky/v0.28.0 (#3119) * changelog pending and upgrading * linkify and version bump * changelog shuffle | 13 January 2019, 22:15:34 UTC |
| 1895cde | Zarko Milosevic | 13 January 2019, 19:47:00 UTC | [WIP] Fill in consensus core details in ADR 030 (#2696) * Initial work towards making ConsensusCore spec complete * Initial version of executor and complete consensus | 13 January 2019, 19:47:00 UTC |
| be00cd1 | Gian Felipe | 13 January 2019, 19:34:29 UTC | Hotfix/validating query result length (#3053) * Validating that there are txs in the query results before loop throught the array * Created tests to validate the error has been fixed * Added comments * Fixing misspeling * check if the variable "skipCount" is bigger than zero. If it is not, we set it to 0. If it, we do not do anything. * using function that validates the skipCount variable * undo Gopkg.lock changes | 13 January 2019, 19:34:29 UTC |
| a6011c0 | Ismail Khoffi | 13 January 2019, 19:31:31 UTC | Close and retry a RemoteSigner on err (#2923) * Close and recreate a RemoteSigner on err * Update changelog * Address Anton's comments / suggestions: - update changelog - restart TCPVal - shut down on `ErrUnexpectedResponse` * re-init remote signer client with fresh connection if Ping fails - add/update TODOs in secret connection - rename tcp.go -> tcp_client.go, same with ipc to clarify their purpose * account for `conn returned by waitConnection can be `nil` - also add TODO about RemoteSigner conn field * Tests for retrying: IPC / TCP - shorter info log on success - set conn and use it in tests to close conn * Tests for retrying: IPC / TCP - shorter info log on success - set conn and use it in tests to close conn - add rwmutex for conn field in IPC * comments and doc.go * fix ipc tests. fixes #2677 * use constants for tests * cleanup some error statements * fixes #2784, race in tests * remove print statement * minor fixes from review * update comment on sts spec * cosmetics * p2p/conn: add failing tests * p2p/conn: make SecretConnection thread safe * changelog * IPCVal signer refactor - use a .reset() method - don't use embedded RemoteSignerClient - guard RemoteSignerClient with mutex - drop the .conn - expose Close() on RemoteSignerClient * apply IPCVal refactor to TCPVal * remove mtx from RemoteSignerClient * consolidate IPCVal and TCPVal, fixes #3104 - done in tcp_client.go - now called SocketVal - takes a listener in the constructor - make tcpListener and unixListener contain all the differences * delete ipc files * introduce unix and tcp dialer for RemoteSigner * rename files - drop tcp_ prefix - rename priv_validator.go to file.go * bring back listener options * fix node * fix priv_val_server * fix node test * minor cleanup and comments | 13 January 2019, 19:31:31 UTC |
| ef94a32 | Ethan Buchman | 13 January 2019, 18:46:25 UTC | Make SecretConnection thread safe (#3111) * p2p/conn: add failing tests * p2p/conn: make SecretConnection thread safe * changelog * fix from review | 13 January 2019, 18:46:25 UTC |
| 7f607d0 | Mauricio Serna | 11 January 2019, 22:41:02 UTC | docs: fix p2p readme links (#3109) | 11 January 2019, 22:41:02 UTC |
| 81c51cd | Anton Kaliaev | 11 January 2019, 14:24:45 UTC | rpc: include peer's remote IP in `/net_info` (#3052) Refs #3047 | 11 January 2019, 14:24:45 UTC |
| 51094f9 | Ethan Buchman | 11 January 2019, 13:28:29 UTC | update README (#3097) * update README * fix from review | 11 January 2019, 13:28:29 UTC |
| 7644d27 | Alessio Treglia | 10 January 2019, 23:37:34 UTC | Ensure multisig keys have 20-byte address (#3103) * Ensure multisig keys have 20-byte address Use crypto.AddressHash() to avoid returning 32-byte long address. Closes: #3102 * fix pointer * fix test | 10 January 2019, 23:37:34 UTC |
| 764cfe3 | Alessio Treglia | 10 January 2019, 22:47:20 UTC | Don't use pointer receivers for PubKeyMultisigThreshold (#3100) * Don't use pointer receivers for PubKeyMultisigThreshold * test that showcases panic when PubKeyMultisigThreshold are used in sdk: - deserialization will fail in `readInfo` which tries to read a `crypto.PubKey` into a `localInfo` (called by cosmos-sdk/client/keys.GetKeyInfo) * Update changelog * Rename routeTable to nameTable, multisig key is no longer a pointer * sed -i 's/PubKeyAminoRoute/PubKeyAminoName/g' `grep -lrw PubKeyAminoRoute .` upon Jae's request * AminoRoutes -> AminoNames * sed -e 's/PrivKeyAminoRoute/PrivKeyAminoName/g' * Update crypto/encoding/amino/amino.go Co-Authored-By: alessio <quadrispro@ubuntu.com> | 10 January 2019, 22:47:20 UTC |
| 616c3a4 | srmo | 06 January 2019, 09:00:12 UTC | cs: prettify logging of ignored votes (#3086) Refs #3038 | 06 January 2019, 09:00:12 UTC |
| 04e97f5 | Piotr Husiatyński | 06 January 2019, 08:40:15 UTC | fix build scripts (#3085) * fix build scripts Search for the right variable when introspecting Go code. `Version` was renamed to `TMCoreSemVer`. This is regression introduced in b95ac688af14d130e6ad0b580ed9a8181f6c487c * fix all `Version` introspections. Use `TMCoreSemVer` instead of `Version` | 06 January 2019, 08:40:15 UTC |
| 56a4fb4 | Ethan Buchman | 03 January 2019, 01:18:45 UTC | add signing spec (#3061) * add signing spec * fixes from review * more fixes * fixes from review | 03 January 2019, 01:18:45 UTC |
| 49017a5 | srmo | 01 January 2019, 07:42:39 UTC | 3070 [docs] unindent text as it is supposed to behave the same as the parts before (#3075) | 01 January 2019, 07:42:39 UTC |
| 6a80412 | Ismail Khoffi | 22 December 2018, 05:36:45 UTC | Remove privval.GetAddress(), memoize pubkey (#2948) privval: remove GetAddress(), memoize pubkey | 22 December 2018, 05:36:45 UTC |
| 2348f38 | needkane | 21 December 2018, 22:37:28 UTC | Update node_info.go (#3059) | 21 December 2018, 22:37:28 UTC |
| 41e2eee | yutianwu | 21 December 2018, 21:58:27 UTC | R4R: Split immutable and mutable parts of priv_validator.json (#2870) * split immutable and mutable parts of priv_validator.json * fix bugs * minor changes * retrig test * delete scripts/wire2amino.go * fix test * fixes from review * privval: remove mtx * rearrange priv_validator.go * upgrade path * write tests for the upgrade * fix for unsafe_reset_all * add test * add reset test | 21 December 2018, 21:58:27 UTC |
| a88e283 | Ethan Buchman | 21 December 2018, 21:39:02 UTC | Merge pull request #3063 from tendermint/master Merge master back to develop | 21 December 2018, 21:39:02 UTC |
| 1e1ca15 | Ethan Buchman | 21 December 2018, 21:35:45 UTC | Merge pull request #3062 from tendermint/release/v0.27.4 Release/v0.27.4 | 21 December 2018, 21:35:45 UTC |
| c6604b5 | Ethan Buchman | 21 December 2018, 21:31:28 UTC | changelog and version | 21 December 2018, 21:31:28 UTC |
| c510f82 | Anton Kaliaev | 17 December 2018, 16:35:05 UTC | mempool: move tx to back, not front (#3036) because we pop txs from the front if the cache is full Refs #3035 | 21 December 2018, 21:28:21 UTC |
| daddeba | Zach | 19 December 2018, 17:45:12 UTC | circleci: update go version (#3051) | 19 December 2018, 17:45:12 UTC |
| 30f346f | Zach | 17 December 2018, 19:02:26 UTC | docs: add rpc link to docs navbar and re-org sidebar (#3041) * add rpc to docs navbar and close #3000 * Update config.js | 17 December 2018, 19:02:26 UTC |
| 4d8f29f | Anton Kaliaev | 17 December 2018, 16:52:33 UTC | set allow_duplicate_ip to false (#2992) * config: cors options are arrays of strings, not strings Fixes #2980 * docs: update tendermint-core/configuration.html page * set allow_duplicate_ip to false * in `tendermint testnet`, set allow_duplicate_ip to true Refs #2712 * fixes after Ismail's review | 17 December 2018, 16:52:33 UTC |
| 2182f6a | Zach | 17 December 2018, 16:51:53 UTC | update go version & other cleanup (#3018) * update go version & other cleanup * fix lints * go one.eleven.four * keep circle on 1.11.3 for now | 17 December 2018, 16:51:53 UTC |
| a06912b | Anton Kaliaev | 17 December 2018, 16:35:05 UTC | mempool: move tx to back, not front (#3036) because we pop txs from the front if the cache is full Refs #3035 | 17 December 2018, 16:35:05 UTC |
| 0ff7151 | Zach | 17 December 2018, 04:34:13 UTC | fix docs / proxy app (#2988) * fix docs / proxy app, closes #2986 * counter_serial * review comments * list all possible options * add changelog entries | 17 December 2018, 04:34:13 UTC |
| 385977d | Ethan Buchman | 16 December 2018, 19:30:46 UTC | Merge pull request #3033 from tendermint/master Merge pull request #3032 from tendermint/release/v0.27.3 | 16 December 2018, 19:30:46 UTC |
| 0138530 | Ethan Buchman | 16 December 2018, 19:30:23 UTC | Merge pull request #3032 from tendermint/release/v0.27.3 Release/v0.27.3 | 16 December 2018, 19:30:23 UTC |
| 0533c73 | Ethan Buchman | 16 December 2018, 19:19:38 UTC | crypto: revert to mainline Go crypto lib (#3027) * crypto: revert to mainline Go crypto lib We used to use a fork for a modified bcrypt so we could pass our own randomness but this was largely unecessary, unused, and a burden. So now we just use the mainline Go crypto lib. * changelog * fix tests * version and changelog | 16 December 2018, 19:19:38 UTC |
| 1beb455 | Ethan Buchman | 16 December 2018, 19:13:57 UTC | Merge pull request #3031 from tendermint/master Merge pull request #3030 from tendermint/release/v0.27.2 | 16 December 2018, 19:13:57 UTC |
| 4a568fc | Ethan Buchman | 16 December 2018, 19:13:30 UTC | Merge pull request #3030 from tendermint/release/v0.27.2 Release/v0.27.2 | 16 December 2018, 19:13:30 UTC |
| b3141d7 | Ethan Buchman | 16 December 2018, 19:05:58 UTC | makeNodeInfo returns error (#3029) * makeNodeInfo returns error * version and changelog | 16 December 2018, 19:05:58 UTC |
| 9a6dd96 | Jae Kwon | 16 December 2018, 17:27:16 UTC | Revert to using defers in addrbook. (#3025) * Revert to using defers in addrbook. ValidateBasic->Validate since it requires DNS * Update CHANGELOG_PENDING | 16 December 2018, 17:27:16 UTC |
| 9fa9596 | Ethan Buchman | 16 December 2018, 17:25:19 UTC | Merge pull request #3026 from tendermint/master Merge pull request #3023 from tendermint/release/v0.27.1 | 16 December 2018, 17:25:19 UTC |
| 1f09818 | Ethan Buchman | 16 December 2018, 17:24:54 UTC | Merge pull request #3023 from tendermint/release/v0.27.1 Release/v0.27.1 | 16 December 2018, 17:24:54 UTC |
| e4806f9 | Ethan Buchman | 15 December 2018, 20:58:09 UTC | Bucky/v0.27.1 (#3022) * update changelog * linkify * changelog and version | 15 December 2018, 20:58:09 UTC |
| b53a271 | Anton Kaliaev | 15 December 2018, 20:38:13 UTC | docs: networks/docker-compose: small fixes (#3017) | 15 December 2018, 20:38:13 UTC |
| a75dab4 | Hleb Albau | 15 December 2018, 20:32:35 UTC | #2980 fix cors doc (#3013) | 15 December 2018, 20:32:35 UTC |
| 7c9e767 | Ethan Buchman | 15 December 2018, 20:26:27 UTC | 2980 fix cors (#3021) * config: cors options are arrays of strings, not strings Fixes #2980 * docs: update tendermint-core/configuration.html page * set allow_duplicate_ip to false * in `tendermint testnet`, set allow_duplicate_ip to true Refs #2712 * fixes after Ismail's review * Revert "set allow_duplicate_ip to false" This reverts commit 24c1094ebcf2bd35f2642a44d7a1e5fb5c178fb1. | 15 December 2018, 20:26:27 UTC |
| f82a8ff | JamesRay | 15 December 2018, 19:33:30 UTC | During replay, when appHeight==0, only saveState if stateHeight is also 0 (#3006) * optimize addProposalBlockPart * optimize addProposalBlockPart * if ProposalBlockParts and LockedBlockParts both exist,let LockedBlockParts overwrite ProposalBlockParts. * fix tryAddBlock * broadcast lockedBlockParts in higher priority * when appHeight==0, it's better fetch genDoc than state.validators. * not save state if replay from height 1 * only save state if replay from height 1 when stateHeight is also 1 * only save state if replay from height 1 when stateHeight is also 1 * only save state if replay from height 0 when stateHeight is also 0 * handshake info's response version only update when stateHeight==0 * save the handshake responseInfo appVersion | 15 December 2018, 19:33:30 UTC |
| ae275d7 | Anton Kaliaev | 15 December 2018, 19:27:02 UTC | mempool: notifyTxsAvailable if there're txs left, but recheck=false (#2991) (left after committing a block) Fixes #2961 -------------- ORIGINAL ISSUE Tendermint version : 0.26.4-b771798d ABCI app : kv-store Environment: OS (e.g. from /etc/os-release): macOS 10.14.1 What happened: Set mempool.recheck = false and create empty block = false in config.toml. When transactions get added right between a new empty block is being proposed and committed, the proposer won't propose new block for that transactions immediately after. That transactions are stuck in the mempool until a new transaction is added and trigger the proposer. What you expected to happen: If there is a transaction left in the mempool, new block should be proposed immediately. Have you tried the latest version: yes How to reproduce it (as minimally and precisely as possible): Fire two transaction using broadcast_tx_sync with specific delay between them. (You may need to do it multiple time before the right delay is found, on my machine the delay is 0.98s) Logs (paste a small part showing an error (< 10 lines) or link a pastebin, gist, etc. containing more of the log file): https://pastebin.com/0Wt6uhPF Config (you can paste only the changes you've made): [mempool] recheck = false create_empty_block = false Anything else we need to know: In mempool.go, we found that proposer will immediately propose new block if Last committed block has some transaction (causing AppHash to changed) or mem.notifyTxsAvailable() is called. Our scenario is as followed. A transaction is fired, it will create 1 block with 1 tx (line 1-4 in the log) and 1 empty block. After the empty block is proposed but before it is committed, second transaction is fired and added to mempool. (line 8-16) Now, since the last committed block is empty and mem.notifyTxsAvailable() will be called only if mempool.recheck = true. The proposer won't immediately propose new block, causing the second transaction to stuck in mempool until another transaction is added to mempool and trigger mem.notifyTxsAvailable(). | 15 December 2018, 19:27:02 UTC |
| f5cca9f | Zach | 15 December 2018, 19:01:28 UTC | docs: update DOCS_README (#3019) Co-Authored-By: zramsay <zach.ramsay@gmail.com> | 15 December 2018, 19:01:28 UTC |
| 3fbe9f2 | Zach | 14 December 2018, 05:32:09 UTC | docs: add edit on Github links (#3014) | 14 December 2018, 05:32:09 UTC |
| f7e463f | mircea-c | 12 December 2018, 09:48:53 UTC | circleci: add a job to automatically update docs (#3005) | 12 December 2018, 09:48:53 UTC |
| bc2a9b2 | Dev Ojha | 12 December 2018, 09:31:35 UTC | mempool: add a comment and missing changelog entry (#2996) Refs #2994 | 12 December 2018, 09:31:35 UTC |
| 9e075d8 | Zach | 12 December 2018, 09:20:02 UTC | docs: enable full-text search (#3004) | 12 December 2018, 09:20:02 UTC |
| 8003786 | Zach | 11 December 2018, 18:21:54 UTC | docs: fixes from 'first time' review (#2999) | 11 December 2018, 18:21:54 UTC |
| 2594cec | Daniil Lashin | 11 December 2018, 08:41:02 UTC | add UnconfirmedTxs/NumUnconfirmedTxs methods to HTTP/Local clients (#2964) | 11 December 2018, 08:41:02 UTC |
| df32ea4 | Dev Ojha | 11 December 2018, 08:17:21 UTC | Make testing logger that doesn't write to stdout (#2997) | 11 December 2018, 08:17:21 UTC |
| f69e2c6 | Anton Kaliaev | 10 December 2018, 20:24:58 UTC | p2p: set MConnection#created during init (#2990) Fixes #2715 In crawlPeersRoutine, which is performed when seedMode is run, there is logic that disconnects the peer's state information at 3-hour intervals through the duration value. The duration value is calculated by referring to the created value of MConnection. When MConnection is created for the first time, the created value is not initiated, so it is not disconnected every 3 hours but every time it is disconnected. So, normal nodes are connected to seedNode and disconnected immediately, so address exchange does not work properly. https://github.com/tendermint/tendermint/blob/master/p2p/pex/pex_reactor.go#L629 This point is not work correctly. I think, https://github.com/tendermint/tendermint/blob/master/p2p/conn/connection.go#L148 created variable is missing the current time setting. | 10 December 2018, 20:24:58 UTC |
| d5d0d2b | Dev Ojha | 10 December 2018, 17:56:49 UTC | Make mempool fail txs with negative gas wanted (#2994) This is only one part of #2989. We also need to fix the application, and add rules to consensus to ensure this. | 10 December 2018, 17:56:49 UTC |
| 41eaf0e | Anton Kaliaev | 09 December 2018, 18:29:51 UTC | turn off strict routability every time (#2983) previously, we're turning it off only when --populate-persistent-peers flag was used, which is obviously incorrect. Fixes https://github.com/cosmos/cosmos-sdk/issues/2983 | 09 December 2018, 18:29:51 UTC |
| 68b4678 | Zach | 07 December 2018, 15:41:19 UTC | docs: relative links in docs/spec/readme.md, js-amino lib (#2977) Co-Authored-By: zramsay <zach.ramsay@gmail.com> | 07 December 2018, 15:41:19 UTC |
| 2f64717 | Leo Wang | 07 December 2018, 08:30:58 UTC | return an error if validator set is empty in genesis file and after InitChain (#2971) Fixes #2951 | 07 December 2018, 08:30:58 UTC |
| c4a1cfc | Anton Kaliaev | 07 December 2018, 08:28:02 UTC | don't ignore key when executing CONTAINS (#2924) Fixes #2912 | 07 December 2018, 08:28:02 UTC |
| 0f96bea | Ethan Buchman | 05 December 2018, 21:51:04 UTC | Merge pull request #2976 from tendermint/master Merge pull request #2975 from tendermint/release/v0.27.0 | 05 December 2018, 21:51:04 UTC |
| 9c236ff | Ethan Buchman | 05 December 2018, 21:50:36 UTC | Merge pull request #2975 from tendermint/release/v0.27.0 Release/v0.27.0 | 05 December 2018, 21:50:36 UTC |
| 9f8761d | Ethan Buchman | 05 December 2018, 20:19:30 UTC | update changelog and upgrading (#2974) | 05 December 2018, 20:19:30 UTC |
| 5413c11 | Anton Kaliaev | 05 December 2018, 19:21:46 UTC | kv indexer: add separator to start key when matching ranges (#2925) * kv indexer: add separator to start key when matching ranges to avoid including false positives Refs #2908 * refactor code * add a test case | 05 December 2018, 19:21:46 UTC |
| a14fd8e | Ethan Buchman | 05 December 2018, 12:32:27 UTC | p2p: fix peer count mismatch #2332 (#2969) * p2p: test case for peer count mismatch #2332 * p2p: fix peer count mismatch #2332 * changelog * use httptest.Server to scrape Prometheus metrics | 05 December 2018, 12:32:27 UTC |
| 1bb7e31 | Ethan Buchman | 05 December 2018, 00:16:06 UTC | p2p: panic on transport error (#2968) * p2p: panic on transport error Addresses #2823. Currently, the acceptRoutine exits if the transport returns an error trying to accept a new connection. Once this happens, the node can't accept any new connections. So here, we panic instead. While we could potentially be more intelligent by rerunning the acceptRoutine, the error may indicate something more fundamental (eg. file desriptor limit) that requires a restart anyways. We can leave it to process managers to handle that restart, and notify operators about the panic. * changelog | 05 December 2018, 00:16:06 UTC |
| 222b897 | Ethan Buchman | 04 December 2018, 13:30:29 UTC | Minor log changes (#2959) * node: allow state and code to have diff block versions * node: pex is a log module | 04 December 2018, 13:30:29 UTC |
| d9a1aad | Anton Kaliaev | 03 December 2018, 12:17:06 UTC | docs: add client#Start/Stop to examples in RPC docs (#2939) follow-up on https://github.com/tendermint/tendermint/pull/2936 | 03 December 2018, 12:17:06 UTC |
| 8ef0c26 | Anton Kaliaev | 03 December 2018, 12:15:36 UTC | check if deliverTxResCh is still open, return an err otherwise (#2947) deliverTxResCh, like any other eventBus (pubsub) channel, is closed when eventBus is stopped. We must check if the channel is still open. The alternative approach is to not close any channels, which seems a bit odd. Fixes #2408 | 03 December 2018, 12:15:36 UTC |
| c4d93fd | Ismail Khoffi | 30 November 2018, 19:43:16 UTC | explicitly type MaxTotalVotingPower to int64 (#2953) | 30 November 2018, 19:43:16 UTC |
