Revision 50338b889dc504c69e0cb316ac92d1b9e51f3c8a authored by Török Edwin on 15 June 2011, 21:06:14 UTC, committed by Al Viro on 16 June 2011, 15:27:39 UTC
Git bisection shows that commit e6bc45d65df8599fdbae73be9cec4ceed274db53 causes BUG_ONs under high I/O load: kernel BUG at fs/inode.c:1368! [ 2862.501007] Call Trace: [ 2862.501007] [<ffffffff811691d8>] d_kill+0xf8/0x140 [ 2862.501007] [<ffffffff81169c19>] dput+0xc9/0x190 [ 2862.501007] [<ffffffff8115577f>] fput+0x15f/0x210 [ 2862.501007] [<ffffffff81152171>] filp_close+0x61/0x90 [ 2862.501007] [<ffffffff81152251>] sys_close+0xb1/0x110 [ 2862.501007] [<ffffffff814c14fb>] system_call_fastpath+0x16/0x1b A reliable way to reproduce this bug is: Login to KDE, run 'rsnapshot sync', and apt-get install openjdk-6-jdk, and apt-get remove openjdk-6-jdk. The buggy part of the patch is this: struct inode *inode = NULL; ..... - if (nd.last.name[nd.last.len]) - goto slashes; inode = dentry->d_inode; - if (inode) - ihold(inode); + if (nd.last.name[nd.last.len] || !inode) + goto slashes; + ihold(inode) ... if (inode) iput(inode); /* truncate the inode here */ If nd.last.name[nd.last.len] is nonzero (and thus goto slashes branch is taken), and dentry->d_inode is non-NULL, then this code now does an additional iput on the inode, which is wrong. Fix this by only setting the inode variable if nd.last.name[nd.last.len] is 0. Reference: https://lkml.org/lkml/2011/6/15/50 Reported-by: Norbert Preining <preining@logic.at> Reported-by: Török Edwin <edwintorok@gmail.com> Cc: "Theodore Ts'o" <tytso@mit.edu> Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Török Edwin <edwintorok@gmail.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent a685e08
File | Mode | Size |
---|---|---|
include | ||
.gitignore | -rw-r--r-- | 73 bytes |
Kconfig | -rw-r--r-- | 1023 bytes |
Makefile | -rw-r--r-- | 1.8 KB |
apparmorfs.c | -rw-r--r-- | 5.6 KB |
audit.c | -rw-r--r-- | 4.5 KB |
capability.c | -rw-r--r-- | 3.8 KB |
context.c | -rw-r--r-- | 5.4 KB |
domain.c | -rw-r--r-- | 21.2 KB |
file.c | -rw-r--r-- | 12.8 KB |
ipc.c | -rw-r--r-- | 3.1 KB |
lib.c | -rw-r--r-- | 3.3 KB |
lsm.c | -rw-r--r-- | 24.6 KB |
match.c | -rw-r--r-- | 8.9 KB |
path.c | -rw-r--r-- | 5.8 KB |
policy.c | -rw-r--r-- | 31.5 KB |
policy_unpack.c | -rw-r--r-- | 16.6 KB |
procattr.c | -rw-r--r-- | 4.6 KB |
resource.c | -rw-r--r-- | 3.9 KB |
sid.c | -rw-r--r-- | 1.2 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...