Revision 50338b889dc504c69e0cb316ac92d1b9e51f3c8a authored by Török Edwin on 15 June 2011, 21:06:14 UTC, committed by Al Viro on 16 June 2011, 15:27:39 UTC
Git bisection shows that commit e6bc45d65df8599fdbae73be9cec4ceed274db53 causes
BUG_ONs under high I/O load:
kernel BUG at fs/inode.c:1368!
[ 2862.501007] Call Trace:
[ 2862.501007] [<ffffffff811691d8>] d_kill+0xf8/0x140
[ 2862.501007] [<ffffffff81169c19>] dput+0xc9/0x190
[ 2862.501007] [<ffffffff8115577f>] fput+0x15f/0x210
[ 2862.501007] [<ffffffff81152171>] filp_close+0x61/0x90
[ 2862.501007] [<ffffffff81152251>] sys_close+0xb1/0x110
[ 2862.501007] [<ffffffff814c14fb>] system_call_fastpath+0x16/0x1b
A reliable way to reproduce this bug is:
Login to KDE, run 'rsnapshot sync', and apt-get install openjdk-6-jdk,
and apt-get remove openjdk-6-jdk.
The buggy part of the patch is this:
struct inode *inode = NULL;
.....
- if (nd.last.name[nd.last.len])
- goto slashes;
inode = dentry->d_inode;
- if (inode)
- ihold(inode);
+ if (nd.last.name[nd.last.len] || !inode)
+ goto slashes;
+ ihold(inode)
...
if (inode)
iput(inode); /* truncate the inode here */
If nd.last.name[nd.last.len] is nonzero (and thus goto slashes branch is taken),
and dentry->d_inode is non-NULL, then this code now does an additional iput on
the inode, which is wrong.
Fix this by only setting the inode variable if nd.last.name[nd.last.len] is 0.
Reference: https://lkml.org/lkml/2011/6/15/50
Reported-by: Norbert Preining <preining@logic.at>
Reported-by: Török Edwin <edwintorok@gmail.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Török Edwin <edwintorok@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent a685e08
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 356 bytes |
| Makefile | -rw-r--r-- | 120 bytes |
| common.c | -rw-r--r-- | 54.6 KB |
| common.h | -rw-r--r-- | 32.6 KB |
| domain.c | -rw-r--r-- | 14.6 KB |
| file.c | -rw-r--r-- | 33.2 KB |
| gc.c | -rw-r--r-- | 9.0 KB |
| group.c | -rw-r--r-- | 3.6 KB |
| load_policy.c | -rw-r--r-- | 2.2 KB |
| memory.c | -rw-r--r-- | 7.3 KB |
| mount.c | -rw-r--r-- | 8.7 KB |
| realpath.c | -rw-r--r-- | 4.2 KB |
| securityfs_if.c | -rw-r--r-- | 4.2 KB |
| tomoyo.c | -rw-r--r-- | 7.8 KB |
| util.c | -rw-r--r-- | 22.9 KB |
Computing file changes ...
