Revision 505e428374bc17a2c0bd388c2e8d892e9cd8eef2 authored by Michael S. Tsirkin on 14 December 2014, 16:52:51 UTC, committed by Michael Ellerman on 18 December 2014, 08:11:09 UTC
At the moment, if p and x are both of the same bitwise type (eg. __le32), get_user(x, p) produces a sparse warning. This is because *p is loaded into a long then cast back to typeof(*p). When typeof(*p) is a bitwise type (which is uncommon), such a cast needs __force, otherwise sparse produces a warning. For non-bitwise types __force should have no effect, and should not hide any legitimate errors. Note that we are casting to typeof(*p) not typeof(x). Even with the cast, if x and *p are of different types we should get the warning, so I think we are not loosing the ability to detect any actual errors. virtio would like to use bitwise types with get_user() so fix these spurious warnings by adding __force. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> [mpe: Fill in changelog with more details] Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
1 parent c8742f8
| File | Mode | Size |
|---|---|---|
| Makefile | -rw-r--r-- | 255 bytes |
| hv_fcopy_daemon.c | -rw-r--r-- | 4.4 KB |
| hv_get_dhcp_info.sh | -rwxr-xr-x | 895 bytes |
| hv_get_dns_info.sh | -rwxr-xr-x | 622 bytes |
| hv_kvp_daemon.c | -rw-r--r-- | 37.6 KB |
| hv_set_ifconfig.sh | -rwxr-xr-x | 1.8 KB |
| hv_vss_daemon.c | -rw-r--r-- | 5.9 KB |
Computing file changes ...
