| 518a2dd | Roman Lebedev | 03 October 2016, 20:40:15 UTC | Clahe iop: process(): no need for VLA. use #define | 04 October 2016, 18:06:50 UTC |
| 8088f2c | Roman Lebedev | 03 October 2016, 20:39:44 UTC | Denoiseprofile iop: process_wavelets(): no need for VLA. use #define | 04 October 2016, 18:06:50 UTC |
| 0bd5206 | Roman Lebedev | 03 October 2016, 20:36:17 UTC | Metadata view lib: _metadata_view_update_values(): no need for VLA. | 04 October 2016, 18:06:50 UTC |
| 872311a | Roman Lebedev | 03 October 2016, 20:29:42 UTC | Recentcollect lib: _lib_recentcollection_updated(): no need for VLA. | 04 October 2016, 18:06:49 UTC |
| a633f04 | Roman Lebedev | 03 October 2016, 20:26:54 UTC | Focus: dt_focus_draw_clusters(): use malloc(), not VLA | 04 October 2016, 18:06:49 UTC |
| a1763d0 | Roman Lebedev | 03 October 2016, 20:33:30 UTC | Cups_print: dt_get_papers(): no need for VLA. | 04 October 2016, 18:06:49 UTC |
| 0839c1a | Roman Lebedev | 03 October 2016, 20:23:28 UTC | Imageio png: read_header(): no need for VLA. use #define | 04 October 2016, 18:06:49 UTC |
| df58e87 | Roman Lebedev | 03 October 2016, 20:22:43 UTC | CMake: let's also enable -Wvla | 04 October 2016, 18:06:49 UTC |
| 7a0ed95 | Roman Lebedev | 03 October 2016, 16:16:23 UTC | CMake: make stack/object size warning a error. Now that all the issues i see are fixed, this is safe to do. | 04 October 2016, 18:06:49 UTC |
| c7cdbd8 | Roman Lebedev | 03 October 2016, 14:37:40 UTC | dt-view: don't do unbound stack-based VLA's | 04 October 2016, 18:06:49 UTC |
| aa83ea1 | Roman Lebedev | 03 October 2016, 14:34:50 UTC | dt-chart: thinplate: thinplate_match(): don't do unbound stack-based VLA's | 04 October 2016, 18:06:49 UTC |
| a17f31b | Roman Lebedev | 03 October 2016, 14:29:09 UTC | dt-chart: thinplate: solve(): don't do unbound stack-based VLA's | 04 October 2016, 18:06:48 UTC |
| c0f72e8 | Roman Lebedev | 03 October 2016, 16:24:58 UTC | dt-chart: parse_cht(): don't do unbound stack-based VLA's | 04 October 2016, 18:06:48 UTC |
| bd8235f | Roman Lebedev | 04 October 2016, 09:05:12 UTC | dt-chart: process_data(): don't do unbound stack-based VLA's | 04 October 2016, 18:06:48 UTC |
| 3dcc78c | Roman Lebedev | 03 October 2016, 13:39:32 UTC | dt-g-c: don't do unbound stack-based VLA's | 04 October 2016, 18:06:48 UTC |
| a37034d | Roman Lebedev | 03 October 2016, 13:36:11 UTC | dt-cli: don't do unbound stack-based VLA's | 04 October 2016, 18:06:48 UTC |
| 8d01bc1 | Roman Lebedev | 03 October 2016, 13:28:43 UTC | Png format: write_image(): don't do unbound stack-based VLA's | 04 October 2016, 18:06:48 UTC |
| 5d1e7b1 | Roman Lebedev | 04 October 2016, 09:24:51 UTC | Jpeg format: write_image(): don't do unbound stack-based VLA's | 04 October 2016, 18:06:48 UTC |
| 6b7410f | Roman Lebedev | 03 October 2016, 13:26:02 UTC | Pdf format: write_image(): don't do unbound stack-based VLA's | 04 October 2016, 18:06:47 UTC |
| 95eb869 | Roman Lebedev | 04 October 2016, 18:06:33 UTC | Demosaic iop: process_vng_cl(): don't do unbound stack-based VLA's Tes, this was technically not VLA, but gcc is stupid. | 04 October 2016, 18:06:36 UTC |
| 05ad5d3 | Roman Lebedev | 03 October 2016, 13:04:11 UTC | Colormapping iop: process(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:04 UTC |
| b05a06d | Roman Lebedev | 03 October 2016, 12:54:05 UTC | Colormapping iop: kmeans(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:04 UTC |
| d86b185 | Roman Lebedev | 03 October 2016, 12:51:11 UTC | Colortransfer iop: process(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:04 UTC |
| ef01814 | Roman Lebedev | 03 October 2016, 12:44:09 UTC | Colortransfer iop: kmeans(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:04 UTC |
| 2bb5381 | Roman Lebedev | 03 October 2016, 12:35:59 UTC | Clahe iop: process(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:04 UTC |
| d907060 | Roman Lebedev | 03 October 2016, 12:28:43 UTC | Dither iop: process_random(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:04 UTC |
| f322e09 | Roman Lebedev | 03 October 2016, 12:27:13 UTC | Vignette iop: process(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:03 UTC |
| 2822336 | Roman Lebedev | 03 October 2016, 12:25:04 UTC | Spots iop: process(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:03 UTC |
| f3bb208 | Roman Lebedev | 03 October 2016, 12:20:44 UTC | Denoiseprofile iop: process_wavelets_cl(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:03 UTC |
| 6c6dcf8 | Roman Lebedev | 03 October 2016, 12:13:42 UTC | Soften iop: process_cl(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:03 UTC |
| 51b353d | Roman Lebedev | 03 October 2016, 12:10:17 UTC | Soften iop: process_sse2(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:03 UTC |
| 5b65a08 | Roman Lebedev | 03 October 2016, 12:07:42 UTC | Soften iop: process(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:03 UTC |
| e4ee4d0 | Roman Lebedev | 03 October 2016, 11:59:29 UTC | Highpass iop: process_cl(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:03 UTC |
| ffc503d | Roman Lebedev | 03 October 2016, 11:55:40 UTC | Sharpen iop: process(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:02 UTC |
| 754fef8 | Roman Lebedev | 03 October 2016, 11:53:14 UTC | Sharpen iop: process_sse2(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:02 UTC |
| e841e32 | Roman Lebedev | 03 October 2016, 11:53:03 UTC | Sharpen iop: process_cl(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:02 UTC |
| 8059a6f | Roman Lebedev | 03 October 2016, 11:01:35 UTC | Atrous iop: process_cl(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:02 UTC |
| 509d043 | Roman Lebedev | 03 October 2016, 10:55:13 UTC | Bloom iop: process(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:02 UTC |
| 4aa6a10 | Roman Lebedev | 03 October 2016, 10:45:50 UTC | Bilateral iop: permutohedral: merge_splat_threads(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:02 UTC |
| b759caf | Roman Lebedev | 04 October 2016, 09:39:31 UTC | Bilateral iop: process(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:02 UTC |
| 5456803 | Roman Lebedev | 03 October 2016, 10:32:09 UTC | equalizer_eaw: dt_iop_equalizer_iwtf(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:02 UTC |
| 2535ae4 | Roman Lebedev | 03 October 2016, 10:31:53 UTC | equalizer_eaw: dt_iop_equalizer_wtf(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:01 UTC |
| 6fbb094 | Roman Lebedev | 03 October 2016, 15:06:58 UTC | Colorchecker iop: commit_params(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:01 UTC |
| 8a79ea6 | Roman Lebedev | 03 October 2016, 14:26:31 UTC | svd.h: dsvd(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:01 UTC |
| 4a79528 | Roman Lebedev | 03 October 2016, 09:47:59 UTC | Colorchecker iop: process_cl(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:01 UTC |
| cefb101 | Roman Lebedev | 03 October 2016, 09:43:33 UTC | Globaltonemap iop: process_cl(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:01 UTC |
| 045e2c9 | Roman Lebedev | 03 October 2016, 09:37:15 UTC | Ashift iop: remove_outliers(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:01 UTC |
| b4b5d20 | Roman Lebedev | 04 October 2016, 09:27:23 UTC | Ashift iop: ransac: don't do unbound stack-based VLA's | 04 October 2016, 17:07:01 UTC |
| 7bc2093 | Roman Lebedev | 03 October 2016, 09:29:28 UTC | Lighttable view: expose_filemanager(): : don't do unbound stack-based VLA's | 04 October 2016, 17:07:01 UTC |
| 43ce0bd | Roman Lebedev | 03 October 2016, 09:27:56 UTC | Lighttable view: expose_full_preview(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:00 UTC |
| b71a320 | Roman Lebedev | 03 October 2016, 09:04:33 UTC | Lua: load_from_lua(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:00 UTC |
| 58e8481 | Roman Lebedev | 03 October 2016, 09:02:20 UTC | dt_gtkentry_build_completion_tooltip_text(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:00 UTC |
| 3285221 | Roman Lebedev | 04 October 2016, 09:19:38 UTC | Masks: group: dt_group_get_mask(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:00 UTC |
| 6aa0799 | Roman Lebedev | 03 October 2016, 08:35:51 UTC | Masks: path: _path_get_points_border(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:00 UTC |
| ff51679 | Roman Lebedev | 03 October 2016, 08:28:21 UTC | pixelpipe_picker(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:00 UTC |
| 2017796 | Roman Lebedev | 03 October 2016, 08:26:54 UTC | pixelpipe_picker_cl(): don't do unbound stack-based VLA's | 04 October 2016, 17:07:00 UTC |
| ca1a3d3 | Roman Lebedev | 03 October 2016, 14:52:22 UTC | OpenCL: dt_opencl_benchmark_cpu(): don't do unbound stack-based VLA's | 04 October 2016, 17:06:59 UTC |
| f1374c8 | Roman Lebedev | 03 October 2016, 14:48:29 UTC | OpenCL: dt_opencl_benchmark_cpu(): don't do unbound stack-based VLA's | 04 October 2016, 17:06:59 UTC |
| 20cd5a5 | Roman Lebedev | 03 October 2016, 14:47:37 UTC | OpenCL: dt_opencl_benchmark_gpu(): don't do unbound stack-based VLA's | 04 October 2016, 17:06:59 UTC |
| c06f238 | Roman Lebedev | 03 October 2016, 16:42:03 UTC | dt_opencl_events_profiling(): don't do unbound stack-based VLA's | 04 October 2016, 17:06:59 UTC |
| 89bc071 | Roman Lebedev | 03 October 2016, 16:38:54 UTC | dt_opencl_build_program(): don't do unbound stack-based VLA's | 04 October 2016, 17:06:59 UTC |
| 3825b7b | Roman Lebedev | 03 October 2016, 07:40:24 UTC | dt_opencl_priority_parse(): don't do unbound stack-based VLA's | 04 October 2016, 17:06:59 UTC |
| f2efb3f | Roman Lebedev | 03 October 2016, 07:36:26 UTC | Imageio png: read_image(): don't do unbound stack-based VLA's | 04 October 2016, 17:06:59 UTC |
| 0bb1cdf | Roman Lebedev | 03 October 2016, 07:33:57 UTC | dt_imageio_jpeg_write_with_icc_profile(): don't do unbound stack-based VLA's | 04 October 2016, 17:06:59 UTC |
| 2fa00a4 | Roman Lebedev | 03 October 2016, 07:30:45 UTC | dt_imageio_jpeg_compress(): don't do unbound stack-based VLA's | 04 October 2016, 17:06:58 UTC |
| 4053330 | Roman Lebedev | 04 October 2016, 17:05:17 UTC | dt_gaussian_blur(): don't do unbound stack-based VLA's /home/lebedevri/darktable/src/common/gaussian.c: In function ‘dt_gaussian_blur._omp_fn.1’: /home/lebedevri/darktable/src/common/gaussian.c:248:9: error: stack usage might be unbounded [-Werror=stack-usage=] #pragma omp parallel for default(none) shared(temp, Labmin, Labmax, a0, a1, a2, a3, b1, b2, coefp, \ ^~~ [ 30%] Building C object src/CMakeFiles/lib_darktable.dir/common/imageio_jpeg.c.o /home/lebedevri/darktable/src/common/gaussian.c: In function ‘dt_gaussian_blur._omp_fn.0’: /home/lebedevri/darktable/src/common/gaussian.c:176:9: error: stack usage might be unbounded [-Werror=stack-usage=] #pragma omp parallel for default(none) shared(temp, Labmin, Labmax, a0, a1, a2, a3, b1, b2, coefp, \ ^~~ | 04 October 2016, 17:06:45 UTC |
| 6b29bdd | Roman Lebedev | 03 October 2016, 16:06:46 UTC | CMake: enable -Wstack-usage, -Wframe-larger-than and -Wlarger-than Right now i have set it to 8M. This is much more that is actually meaningful. Even glibc does not support more than this. Musl default stack size is ~80K. So this will only catch unbound VLA's and alloca()'s With any luck, may help fixing some strange crashes. Will help with musl. They are Wno-error= to help with bisecting :) Only for gcc because clang seems to support only some of those, and in some different notation... | 03 October 2016, 21:02:44 UTC |
| e336032 | Roman Lebedev | 02 October 2016, 22:39:55 UTC | colorbalance iop: fix clang build: N_(): expression result unused [ 52%] Building C object src/iop/CMakeFiles/colorbalance.dir/introspection_colorbalance.c.o In file included from /home/lebedevri/darktable/build/src/iop/introspection_colorbalance.c:21: /home/lebedevri/darktable/src/iop/colorbalance.c:593:6: error: expression result unused [-Werror,-Wunused-value] N_("factor of lift"); ^~~~~~~~~~~~~~~~ and so on | 02 October 2016, 22:43:30 UTC |
| 4c67841 | Tobias Ellinghaus | 02 October 2016, 22:31:27 UTC | Deal with duplicated presets when splitting db In the new db we have a UNIQUE index on (name, operation, op_version) for presets which makes insertions fail for libraries that have the same values more than once in the db. I don't know how such a state can be reached, but apparently it happens. | 02 October 2016, 22:37:32 UTC |
| 6040db9 | Roman Lebedev | 02 October 2016, 22:28:43 UTC | ci-script: in case of errors during make, continue with -j1 -k To record as much of the problems into the log as possible. | 02 October 2016, 22:28:49 UTC |
| ce4def9 | Roman Lebedev | 02 October 2016, 21:35:14 UTC | g_object_set(): do NOT use NULL as sentinel, that is just wrong. NULL should not be passed to a variadic function without explicitly casting it to the right type. NULL is arbitrary null pointer constant (with whatever type, unless you assume posix where it must be void*) The variadic function expects the arguments to be some type (depends on how it uses va_arg) Using the wrong type with va_arg is UB. After a long and fruitful disscussion in #musl and #gtk+, i have come to conclusion that #musl is right in this and #gtk+ is #gtk+ :) Fixed mostly by semantic patch: @@ type T; @@ <... g_object_set( ... , ( - NULL | - (T*)NULL ) + HI_IM_GCHAR ) ...> And then mass-replace s/HI_IM_GCHAR/(gchar *)0/ | 02 October 2016, 21:42:58 UTC |
| 4066521 | Tobias Ellinghaus | 02 October 2016, 20:30:31 UTC | [l10n] Update German translation Not at 100% but almost there ... | 02 October 2016, 20:30:31 UTC |
| f363889 | Tobias Ellinghaus | 02 October 2016, 20:29:12 UTC | Some small string changes This fixes a few wordings and marks some strings for translation that intltool isn't smart enough to pick up due to #define magic | 02 October 2016, 20:29:12 UTC |
| a834990 | Roman Lebedev | 02 October 2016, 19:30:19 UTC | Include fcntl.h, not sys/fcntl.h Everywhere else we include fcntl.h anyway, no point in including different things in different places. Musl: /usr/include/sys/fcntl.h:1:2: error: #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h> [-Werror=cpp] #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h> | 02 October 2016, 19:30:24 UTC |
| 1d3e5ef | Roman Lebedev | 02 October 2016, 19:19:51 UTC | dt_colorspaces_set_display_profile(): define *widget only if needed. Fixes compilation with wayland: darktable/src/common/colorspaces.c:1407:14: warning: unused variable ‘widget’ [-Wunused-variable] GtkWidget *widget = dt_ui_center(darktable.gui->ui); | 02 October 2016, 19:20:29 UTC |
| a24fd63 | Roman Lebedev | 02 October 2016, 19:06:10 UTC | Dockerfile: explicitly use ld.gold as ld While it may be just immeasurably faster, it is known to cause more build issues than traditional ld.bfd Since the point of this CI is to catch the issues... Plus, at this time, ld.gold seems like the future. | 02 October 2016, 19:06:13 UTC |
| 19211b1 | Roman Lebedev | 02 October 2016, 18:30:45 UTC | blend.c: #pragma omp shared(*) cleanup, drop bogus stderr There are no functionality changes. May break build on some strange platforms? | 02 October 2016, 18:31:02 UTC |
| d06bae5 | Roman Lebedev | 02 October 2016, 18:03:42 UTC | .travis.yml: ugh, correctly specify script location | 02 October 2016, 18:03:46 UTC |
| ef275b1 | Roman Lebedev | 02 October 2016, 17:52:58 UTC | .travis.yml: specify -pipe, use helper script. Maybe will be faster. Should be more readable and extendable. Will eat more memory. | 02 October 2016, 17:52:58 UTC |
| a0a3f17 | Ger Siemerink | 02 October 2016, 15:42:58 UTC | Updated Dutch translation | 02 October 2016, 15:42:58 UTC |
| 149a194 | houz | 02 October 2016, 14:08:03 UTC | Merge pull request #1274 from darktable-org/db_split Split db into library.db and global data.db | 02 October 2016, 14:08:03 UTC |
| 4cbc04f | Tobias Ellinghaus | 02 October 2016, 14:00:57 UTC | The `presets` table is in data, not main | 02 October 2016, 14:00:57 UTC |
| 0fc4981 | Alexandre Prokoudine | 02 October 2016, 11:28:17 UTC | Update Russian translation | 02 October 2016, 11:28:17 UTC |
| 188b601 | Roman Lebedev | 02 October 2016, 10:36:59 UTC | Rawoverexposed: use C_() for olid color schemes | 02 October 2016, 10:37:38 UTC |
| c2a424b | Roman Lebedev | 01 October 2016, 21:36:54 UTC | dt_dev_pixelpipe_process_rec(): fix clang build. In file included from darktable/src/develop/pixelpipe.c:22: darktable/src/develop/pixelpipe_hb.c:744:24: error: address of array 'module->op' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] if(module && module->op) strncpy(module_name, module->op, sizeof(module_name)); ~~ ~~~~~~~~^~ Was broken in ce77e71f8b698230b76832071408a2e90284655b. | 01 October 2016, 21:36:59 UTC |
| b9759ca | Ger Siemerink | 01 October 2016, 16:47:37 UTC | Updated Dutch translation | 01 October 2016, 16:47:37 UTC |
| ce77e71 | Ulrich Pegelow | 01 October 2016, 14:46:29 UTC | pixelpipe: duplicte module name into local variable in dt_dev_pixelpipe_process_rec() aim: in case of crashes within dt_dev_pixelpipe_process_rec() we get easier access to the the module context in which it happened | 01 October 2016, 14:46:29 UTC |
| e5914e2 | Ulrich Pegelow | 01 October 2016, 10:00:26 UTC | rawoverexposed: fix last commit adding (void *)cast to make compilers happy | 01 October 2016, 10:00:26 UTC |
| 884ef2d | Ulrich Pegelow | 01 October 2016, 07:30:46 UTC | rawoverexposed: enable OpenCL processing for xtrans raws | 01 October 2016, 07:30:46 UTC |
| ab4b01b | Tobias Ellinghaus | 30 September 2016, 20:36:37 UTC | Split db into library.db and global data.db The new data.db contains styles, presets and tags. | 30 September 2016, 20:36:37 UTC |
| ee15d4c | Ulrich Pegelow | 30 September 2016, 15:33:23 UTC | opencl: remove bogus 'static' keyword in extended.cl | 30 September 2016, 15:33:23 UTC |
| e1db642 | Ulrich Pegelow | 30 September 2016, 14:00:57 UTC | rawoverexposed: fix OpenCL codepath | 30 September 2016, 14:00:57 UTC |
| 6a03af6 | Roman Lebedev | 30 September 2016, 10:26:43 UTC | Validate AppData via `appstream-util validate` Note that this is different from the other validations. `appstream-util validate` takes about 3sec on my machine. I do not like it. So let's try running it only right after generating output file. NOTE: if you manually modify generated darktable.appdata.xml, it will not validate it !!! That is something for `make check`, probably. | 30 September 2016, 10:26:49 UTC |
| 33d8193 | Roman Lebedev | 29 September 2016, 16:41:45 UTC | Revert "Let's not fail the build if jsonschema check fails for now." This reverts commit dad8372b2475dde5d5df935b944896e2c4724983. | 29 September 2016, 16:41:45 UTC |
| 930f0d0 | Roman Lebedev | 29 September 2016, 16:35:08 UTC | CMake: don't mkdir /packaging/debian | 29 September 2016, 16:36:06 UTC |
| 8156d26 | Roman Lebedev | 29 September 2016, 14:50:06 UTC | CMake: better protect against source changes. This does actually catch creation of packaging/debian dir | 29 September 2016, 16:36:04 UTC |
| 027e71a | houz | 29 September 2016, 16:33:57 UTC | Merge pull request #1273 from TuTPhoto/master Update darktable.xml | 29 September 2016, 16:33:57 UTC |
| 97942f5 | Pascal Obry | 29 September 2016, 16:02:35 UTC | Update French translation. | 29 September 2016, 16:02:35 UTC |
| 42a2340 | Pascal Obry | 19 September 2016, 16:15:45 UTC | Add defensive code against broken .icc file. Tentative fix for #11160. | 29 September 2016, 15:34:52 UTC |
| 316dd1e | Roman Lebedev | 29 September 2016, 13:40:18 UTC | Dockerfile: set locale to C.UTF-8 | 29 September 2016, 13:45:22 UTC |
